[SYCL][ABI-Break] ABI-neutralize the data member of Exception message (#13549)

Currently, the exception class contains the data member `MMsg `whose
type is `shared_ptr<std::string>`.
This may cause an ABI-incompatibility issue when the user code and SYCL
lib are built with different C++11 ABI setting.
To solve this issue, this PR changes the type of `MMsg` to
`shared_ptr<detail::string>`.

---------

Signed-off-by: Byoungro So <[email protected]>

Author: bso-intel

sycl/include/sycl/exception.hpp

@@ -16,6 +16,9 @@
 #include <sycl/detail/defines_elementary.hpp> // for __SYCL2020_DEPRECATED
 #include <sycl/detail/export.hpp>             // for __SYCL_EXPORT
 #include <sycl/detail/pi.h>                   // for pi_int32
+#ifdef __INTEL_PREVIEW_BREAKING_CHANGES
+#include <sycl/detail/string.hpp>
+#endif
 
 #include <exception>    // for exception
 #include <memory>       // for allocator, shared_ptr, make...
@@ -106,7 +109,11 @@ class __SYCL_EXPORT exception : public virtual std::exception {
 private:
   // Exceptions must be noexcept copy constructible, so cannot use std::string
   // directly.
+#ifdef __INTEL_PREVIEW_BREAKING_CHANGES
+  std::shared_ptr<detail::string> MMsg;
+#else
   std::shared_ptr<std::string> MMsg;
+#endif
   pi_int32 MPIErr = 0;
   std::shared_ptr<context> MContext;
   std::error_code MErrC = make_error_code(sycl::errc::invalid);
@@ -124,14 +131,20 @@ class __SYCL_EXPORT exception : public virtual std::exception {
   }
 
   exception(const std::string &Msg)
-      : MMsg(std::make_shared<std::string>(Msg)), MContext(nullptr) {}
-
-  // base constructor for all SYCL 2020 constructors
-  // exception(context *ctxPtr, std::error_code Ec, const std::string
-  // &what_arg);
-  exception(std::error_code Ec, std::shared_ptr<context> SharedPtrCtx,
-            const std::string &what_arg)
-      : exception(Ec, SharedPtrCtx, what_arg.c_str()) {}
+#ifdef __INTEL_PREVIEW_BREAKING_CHANGES
+      : MMsg(std::make_shared<detail::string>(Msg)), MContext(nullptr){}
+#else
+      : MMsg(std::make_shared<std::string>(Msg)), MContext(nullptr) {
+  }
+#endif
+
+        // base constructor for all SYCL 2020 constructors
+        // exception(context *ctxPtr, std::error_code Ec, const std::string
+        // &what_arg);
+        exception(std::error_code Ec, std::shared_ptr<context> SharedPtrCtx,
+                  const std::string &what_arg)
+      : exception(Ec, SharedPtrCtx, what_arg.c_str()) {
+  }
   exception(std::error_code Ec, std::shared_ptr<context> SharedPtrCtx,
             const char *WhatArg);
 };

sycl/source/exception.cpp

@@ -53,7 +53,11 @@ exception::exception(context Ctx, int EV, const std::error_category &ECat)
 // protected base constructor for all SYCL 2020 constructors
 exception::exception(std::error_code EC, std::shared_ptr<context> SharedPtrCtx,
                      const char *WhatArg)
+#ifdef __INTEL_PREVIEW_BREAKING_CHANGES
+    : MMsg(std::make_shared<detail::string>(WhatArg)),
+#else
     : MMsg(std::make_shared<std::string>(WhatArg)),
+#endif
       MPIErr(PI_ERROR_INVALID_VALUE), MContext(SharedPtrCtx), MErrC(EC) {
   detail::GlobalHandler::instance().TraceEventXPTI(MMsg->c_str());
 }