Skip to content

Commit 496722a

Browse files
Artem Gindinsonvmaksimo
authored andcommitted
Migrate arithmetic fence tokens to spirv_internal.hpp
Signed-off-by: Artem Gindinson <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@fe35522
1 parent 790c64b commit 496722a

File tree

7 files changed

+9
-7
lines changed

7 files changed

+9
-7
lines changed

llvm-spirv/lib/SPIRV/SPIRVReader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2806,7 +2806,7 @@ Value *SPIRVToLLVM::transValueWithoutDecoration(SPIRVValue *BV, Function *F,
28062806
return mapValue(
28072807
BV, transArbFloatInst(static_cast<SPIRVInstruction *>(BV), BB, true));
28082808

2809-
case OpArithmeticFenceINTEL: {
2809+
case internal::OpArithmeticFenceINTEL: {
28102810
IRBuilder<> Builder(BB);
28112811
auto *BC = static_cast<SPIRVUnary *>(BV);
28122812
Type *RetTy = transType(BC->getType());

llvm-spirv/lib/SPIRV/SPIRVWriter.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3051,9 +3051,9 @@ SPIRVValue *LLVMToSPIRVBase::transIntrinsicInst(IntrinsicInst *II,
30513051
SPIRVType *Ty = transType(II->getType());
30523052
SPIRVValue *Op = transValue(II->getArgOperand(0), BB);
30533053
if (BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_arithmetic_fence)) {
3054-
BM->addCapability(CapabilityFPArithmeticFenceINTEL);
3054+
BM->addCapability(internal::CapabilityFPArithmeticFenceINTEL);
30553055
BM->addExtension(ExtensionID::SPV_INTEL_arithmetic_fence);
3056-
return BM->addUnaryInst(OpArithmeticFenceINTEL, Ty, Op, BB);
3056+
return BM->addUnaryInst(internal::OpArithmeticFenceINTEL, Ty, Op, BB);
30573057
}
30583058
return Op;
30593059
}

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVInstruction.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1556,8 +1556,10 @@ _SPIRV_OP(Any)
15561556
_SPIRV_OP(All)
15571557
_SPIRV_OP(BitCount)
15581558
_SPIRV_OP(BitReverse)
1559-
_SPIRV_OP(ArithmeticFenceINTEL)
15601559
#undef _SPIRV_OP
1560+
#define _SPIRV_OP_INTERNAL(x) typedef SPIRVUnaryInst<internal::Op##x> SPIRV##x;
1561+
_SPIRV_OP_INTERNAL(ArithmeticFenceINTEL)
1562+
#undef _SPIRV_OP_INTERNAL
15611563

15621564
class SPIRVAccessChainBase : public SPIRVInstTemplateBase {
15631565
public:

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVOpCodeEnum.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,4 +534,3 @@ _SPIRV_OP(TypeBufferSurfaceINTEL, 6086)
534534
_SPIRV_OP(TypeStructContinuedINTEL, 6090)
535535
_SPIRV_OP(ConstantCompositeContinuedINTEL, 6091)
536536
_SPIRV_OP(SpecConstantCompositeContinuedINTEL, 6092)
537-
_SPIRV_OP(ArithmeticFenceINTEL, 6144)

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVOpCodeEnumInternal.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,4 @@ _SPIRV_OP_INTERNAL(AliasDomainDeclINTEL, internal::OpAliasDomainDeclINTEL)
77
_SPIRV_OP_INTERNAL(AliasScopeDeclINTEL, internal::OpAliasScopeDeclINTEL)
88
_SPIRV_OP_INTERNAL(AliasScopeListDeclINTEL, internal::OpAliasScopeListDeclINTEL)
99
_SPIRV_OP_INTERNAL(TypeTokenINTEL, internal::OpTypeTokenINTEL)
10+
_SPIRV_OP_INTERNAL(ArithmeticFenceINTEL, internal::OpArithmeticFenceINTEL)

llvm-spirv/lib/SPIRV/libSPIRV/spirv.hpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1052,7 +1052,6 @@ enum Capability {
10521052
CapabilityLongConstantCompositeINTEL = 6089,
10531053
CapabilityAtomicFloat16AddEXT = 6095,
10541054
CapabilityDebugInfoModuleINTEL = 6114,
1055-
CapabilityFPArithmeticFenceINTEL = 6144,
10561055
CapabilityMax = 0x7fffffff,
10571056
};
10581057

@@ -1793,7 +1792,6 @@ enum Op {
17931792
OpTypeStructContinuedINTEL = 6090,
17941793
OpConstantCompositeContinuedINTEL = 6091,
17951794
OpSpecConstantCompositeContinuedINTEL = 6092,
1796-
OpArithmeticFenceINTEL = 6145,
17971795
OpMax = 0x7fffffff,
17981796
};
17991797

llvm-spirv/lib/SPIRV/libSPIRV/spirv_internal.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ enum InternalOp {
4141
IOpAliasScopeDeclINTEL = 5912,
4242
IOpAliasScopeListDeclINTEL = 5913,
4343
IOpTypeTokenINTEL = 6113,
44+
IOpArithmeticFenceINTEL = 6145,
4445
IOpPrev = OpMax - 2,
4546
IOpForward
4647
};
@@ -90,6 +91,7 @@ constexpr Op OpAliasScopeDeclINTEL = static_cast<Op>(IOpAliasScopeDeclINTEL);
9091
constexpr Op OpAliasScopeListDeclINTEL =
9192
static_cast<Op>(IOpAliasScopeListDeclINTEL);
9293
constexpr Op OpTypeTokenINTEL = static_cast<Op>(IOpTypeTokenINTEL);
94+
constexpr Op OpArithmeticFenceINTEL = static_cast<Op>(IOpArithmeticFenceINTEL);
9395

9496
constexpr Decoration DecorationAliasScopeINTEL =
9597
static_cast<Decoration>(IDecAliasScopeINTEL );

0 commit comments

Comments
 (0)