Skip to content

Commit 4a7a5d4

Browse files
callumfarecallumfare
authored
[SYCL][UR][CUDA] Remove unnecessary UR entry point validation (#9969)
These checks are already performed by the UR validation layer
1 parent aac3cd1 commit 4a7a5d4

File tree

11 files changed

+17
-219
lines changed

11 files changed

+17
-219
lines changed

‎sycl/plugins/unified_runtime/ur/adapters/cuda/context.cpp

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ urContextCreate(uint32_t DeviceCount, const ur_device_handle_t *phDevices,
2424
ur_context_handle_t *phContext) {
2525
std::ignore = DeviceCount;
2626
std::ignore = pProperties;
27-
UR_ASSERT(phDevices, UR_RESULT_ERROR_INVALID_NULL_POINTER);
28-
UR_ASSERT(phContext, UR_RESULT_ERROR_INVALID_NULL_POINTER);
2927

3028
assert(DeviceCount == 1);
3129
ur_result_t RetErr = UR_RESULT_SUCCESS;
@@ -46,8 +44,6 @@ urContextCreate(uint32_t DeviceCount, const ur_device_handle_t *phDevices,
4644
UR_APIEXPORT ur_result_t UR_APICALL urContextGetInfo(
4745
ur_context_handle_t hContext, ur_context_info_t ContextInfoType,
4846
size_t propSize, void *pContextInfo, size_t *pPropSizeRet) {
49-
UR_ASSERT(hContext, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
50-
5147
UrReturnHelper ReturnValue(propSize, pContextInfo, pPropSizeRet);
5248

5349
switch (uint32_t{ContextInfoType}) {
@@ -98,8 +94,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urContextGetInfo(
9894

9995
UR_APIEXPORT ur_result_t UR_APICALL
10096
urContextRelease(ur_context_handle_t hContext) {
101-
UR_ASSERT(hContext, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
102-
10397
if (hContext->decrementReferenceCount() > 0) {
10498
return UR_RESULT_SUCCESS;
10599
}
@@ -112,8 +106,6 @@ urContextRelease(ur_context_handle_t hContext) {
112106

113107
UR_APIEXPORT ur_result_t UR_APICALL
114108
urContextRetain(ur_context_handle_t hContext) {
115-
UR_ASSERT(hContext, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
116-
117109
assert(hContext->getReferenceCount() > 0);
118110

119111
hContext->incrementReferenceCount();
@@ -122,9 +114,6 @@ urContextRetain(ur_context_handle_t hContext) {
122114

123115
UR_APIEXPORT ur_result_t UR_APICALL urContextGetNativeHandle(
124116
ur_context_handle_t hContext, ur_native_handle_t *phNativeContext) {
125-
UR_ASSERT(hContext, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
126-
UR_ASSERT(phNativeContext, UR_RESULT_ERROR_INVALID_NULL_POINTER);
127-
128117
*phNativeContext = reinterpret_cast<ur_native_handle_t>(hContext->get());
129118
return UR_RESULT_SUCCESS;
130119
}
@@ -146,9 +135,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urContextCreateWithNativeHandle(
146135
UR_APIEXPORT ur_result_t UR_APICALL urContextSetExtendedDeleter(
147136
ur_context_handle_t hContext, ur_context_extended_deleter_t pfnDeleter,
148137
void *pUserData) {
149-
UR_ASSERT(hContext, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
150-
UR_ASSERT(pfnDeleter, UR_RESULT_ERROR_INVALID_NULL_POINTER);
151-
152138
hContext->setExtendedDeleter(pfnDeleter, pUserData);
153139
return UR_RESULT_SUCCESS;
154140
}

‎sycl/plugins/unified_runtime/ur/adapters/cuda/device.cpp

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
3737
size_t propSize,
3838
void *pPropValue,
3939
size_t *pPropSizeRet) {
40-
UR_ASSERT(hDevice, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
4140
UrReturnHelper ReturnValue(propSize, pPropValue, pPropSizeRet);
4241

4342
static constexpr uint32_t MaxWorkItemDimensions = 3u;
@@ -1013,8 +1012,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
10131012
/// \return PI_SUCCESS if the function is executed successfully
10141013
/// CUDA devices are always root devices so retain always returns success.
10151014
UR_APIEXPORT ur_result_t UR_APICALL urDeviceRetain(ur_device_handle_t hDevice) {
1016-
UR_ASSERT(hDevice, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1017-
1015+
std::ignore = hDevice;
10181016
return UR_RESULT_SUCCESS;
10191017
}
10201018

@@ -1028,8 +1026,7 @@ urDevicePartition(ur_device_handle_t, const ur_device_partition_properties_t *,
10281026
/// devices.
10291027
UR_APIEXPORT ur_result_t UR_APICALL
10301028
urDeviceRelease(ur_device_handle_t hDevice) {
1031-
UR_ASSERT(hDevice, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1032-
1029+
std::ignore = hDevice;
10331030
return UR_RESULT_SUCCESS;
10341031
}
10351032

@@ -1044,13 +1041,9 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGet(ur_platform_handle_t hPlatform,
10441041
const bool AskingForGPU = DeviceType == UR_DEVICE_TYPE_GPU;
10451042
const bool ReturnDevices = AskingForDefault || AskingForAll || AskingForGPU;
10461043

1047-
UR_ASSERT(hPlatform, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1048-
10491044
size_t NumDevices = ReturnDevices ? hPlatform->Devices.size() : 0;
10501045

10511046
try {
1052-
UR_ASSERT(pNumDevices || phDevices, UR_RESULT_ERROR_INVALID_VALUE);
1053-
10541047
if (pNumDevices) {
10551048
*pNumDevices = NumDevices;
10561049
}
@@ -1078,9 +1071,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGet(ur_platform_handle_t hPlatform,
10781071

10791072
UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetNativeHandle(
10801073
ur_device_handle_t hDevice, ur_native_handle_t *phNativeHandle) {
1081-
UR_ASSERT(hDevice, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1082-
UR_ASSERT(phNativeHandle, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1083-
10841074
*phNativeHandle = reinterpret_cast<ur_native_handle_t>(hDevice->get());
10851075
return UR_RESULT_SUCCESS;
10861076
}
@@ -1099,7 +1089,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceCreateWithNativeHandle(
10991089
const ur_device_native_properties_t *pProperties,
11001090
ur_device_handle_t *phDevice) {
11011091
std::ignore = pProperties;
1102-
UR_ASSERT(phDevice, UR_RESULT_ERROR_INVALID_NULL_POINTER);
11031092

11041093
// We can't cast between ur_native_handle_t and CUdevice, so memcpy the bits
11051094
// instead
@@ -1150,8 +1139,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceCreateWithNativeHandle(
11501139
ur_result_t UR_APICALL urDeviceGetGlobalTimestamps(ur_device_handle_t hDevice,
11511140
uint64_t *pDeviceTimestamp,
11521141
uint64_t *pHostTimestamp) {
1153-
UR_ASSERT(hDevice, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1154-
11551142
CUevent Event;
11561143
ScopedContext Active(hDevice->getContext());
11571144

@@ -1180,11 +1167,7 @@ ur_result_t UR_APICALL urDeviceGetGlobalTimestamps(ur_device_handle_t hDevice,
11801167
UR_APIEXPORT ur_result_t UR_APICALL urDeviceSelectBinary(
11811168
ur_device_handle_t hDevice, const ur_device_binary_t *pBinaries,
11821169
uint32_t NumBinaries, uint32_t *pSelectedBinary) {
1183-
// Ignore unused parameter
1184-
(void)hDevice;
1185-
1186-
UR_ASSERT(pBinaries, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1187-
UR_ASSERT(NumBinaries > 0, UR_RESULT_ERROR_INVALID_ARGUMENT);
1170+
std::ignore = hDevice;
11881171

11891172
// Look for an image for the NVPTX64 target, and return the first one that is
11901173
// found

‎sycl/plugins/unified_runtime/ur/adapters/cuda/enqueue.cpp

Lines changed: 1 addition & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueEventsWaitWithBarrier(
192192
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
193193
// This function makes one stream work on the previous work (or work
194194
// represented by input events) and then all future work waits on that stream.
195-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
196-
197195
ur_result_t Result;
198196

199197
try {
@@ -280,11 +278,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueKernelLaunch(
280278
const size_t *pLocalWorkSize, uint32_t numEventsInWaitList,
281279
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
282280
// Preconditions
283-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
284281
UR_ASSERT(hQueue->getContext() == hKernel->getContext(),
285282
UR_RESULT_ERROR_INVALID_KERNEL);
286-
UR_ASSERT(hKernel, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
287-
UR_ASSERT(pGlobalWorkOffset, UR_RESULT_ERROR_INVALID_NULL_POINTER);
288283
UR_ASSERT(workDim > 0, UR_RESULT_ERROR_INVALID_WORK_DIMENSION);
289284
UR_ASSERT(workDim < 4, UR_RESULT_ERROR_INVALID_WORK_DIMENSION);
290285

@@ -501,9 +496,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferReadRect(
501496
size_t hostRowPitch, size_t hostSlicePitch, void *pDst,
502497
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
503498
ur_event_handle_t *phEvent) {
504-
UR_ASSERT(hBuffer, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
505-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
506-
507499
ur_result_t Result = UR_RESULT_SUCCESS;
508500
CUdeviceptr DevPtr = hBuffer->Mem.BufferMem.get();
509501
std::unique_ptr<ur_event_handle_t_> RetImplEvent{nullptr};
@@ -552,9 +544,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferWriteRect(
552544
size_t hostRowPitch, size_t hostSlicePitch, void *pSrc,
553545
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
554546
ur_event_handle_t *phEvent) {
555-
UR_ASSERT(hBuffer, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
556-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
557-
558547
ur_result_t Result = UR_RESULT_SUCCESS;
559548
CUdeviceptr DevPtr = hBuffer->Mem.BufferMem.get();
560549
std::unique_ptr<ur_event_handle_t_> RetImplEvent{nullptr};
@@ -600,8 +589,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferCopy(
600589
ur_mem_handle_t hBufferDst, size_t srcOffset, size_t dstOffset, size_t size,
601590
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
602591
ur_event_handle_t *phEvent) {
603-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
604-
605592
std::unique_ptr<ur_event_handle_t_> RetImplEvent{nullptr};
606593

607594
try {
@@ -644,10 +631,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferCopyRect(
644631
size_t srcSlicePitch, size_t dstRowPitch, size_t dstSlicePitch,
645632
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
646633
ur_event_handle_t *phEvent) {
647-
UR_ASSERT(hBufferSrc, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
648-
UR_ASSERT(hBufferDst, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
649-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
650-
651634
ur_result_t Result = UR_RESULT_SUCCESS;
652635
CUdeviceptr SrcPtr = hBufferSrc->Mem.BufferMem.get();
653636
CUdeviceptr DstPtr = hBufferDst->Mem.BufferMem.get();
@@ -687,8 +670,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferFill(
687670
size_t patternSize, size_t offset, size_t size,
688671
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
689672
ur_event_handle_t *phEvent) {
690-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
691-
692673
auto ArgsAreMultiplesOfPatternSize =
693674
(offset % patternSize == 0) || (size % patternSize == 0);
694675

@@ -874,8 +855,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemImageRead(
874855
std::ignore = rowPitch;
875856
std::ignore = slicePitch;
876857

877-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
878-
UR_ASSERT(hImage, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
879858
UR_ASSERT(hImage->MemType == ur_mem_handle_t_::Type::Surface,
880859
UR_RESULT_ERROR_INVALID_MEM_OBJECT);
881860

@@ -943,8 +922,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemImageWrite(
943922
std::ignore = rowPitch;
944923
std::ignore = slicePitch;
945924

946-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
947-
UR_ASSERT(hImage, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
948925
UR_ASSERT(hImage->MemType == ur_mem_handle_t_::Type::Surface,
949926
UR_RESULT_ERROR_INVALID_MEM_OBJECT);
950927

@@ -1087,9 +1064,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferMap(
10871064
ur_map_flags_t mapFlags, size_t offset, size_t size,
10881065
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
10891066
ur_event_handle_t *phEvent, void **ppRetMap) {
1090-
UR_ASSERT(ppRetMap != nullptr, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1091-
UR_ASSERT(hQueue != nullptr, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1092-
UR_ASSERT(hBuffer != nullptr, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
10931067
UR_ASSERT(hBuffer->MemType == ur_mem_handle_t_::Type::Buffer,
10941068
UR_RESULT_ERROR_INVALID_MEM_OBJECT);
10951069

@@ -1148,10 +1122,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemUnmap(
11481122
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
11491123
ur_event_handle_t *phEvent) {
11501124
ur_result_t Result = UR_RESULT_SUCCESS;
1151-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1152-
UR_ASSERT(hMem, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1153-
UR_ASSERT(pMappedPtr, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1154-
11551125
UR_ASSERT(hMem->MemType == ur_mem_handle_t_::Type::Buffer,
11561126
UR_RESULT_ERROR_INVALID_MEM_OBJECT);
11571127
UR_ASSERT(hMem->Mem.BufferMem.getMapPtr() != nullptr,
@@ -1197,10 +1167,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMFill(
11971167
ur_queue_handle_t hQueue, void *ptr, size_t patternSize,
11981168
const void *pPattern, size_t size, uint32_t numEventsInWaitList,
11991169
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
1200-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
1201-
UR_ASSERT(ptr, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1202-
UR_ASSERT(size % patternSize == 0, UR_RESULT_ERROR_INVALID_SIZE);
1203-
12041170
ur_result_t Result = UR_RESULT_SUCCESS;
12051171
std::unique_ptr<ur_event_handle_t_> EventPtr{nullptr};
12061172

@@ -1251,9 +1217,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMMemcpy(
12511217
ur_queue_handle_t hQueue, bool blocking, void *pDst, const void *pSrc,
12521218
size_t size, uint32_t numEventsInWaitList,
12531219
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
1254-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
1255-
UR_ASSERT(pDst, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1256-
UR_ASSERT(pSrc, UR_RESULT_ERROR_INVALID_NULL_POINTER);
12571220
ur_result_t Result = UR_RESULT_SUCCESS;
12581221

12591222
std::unique_ptr<ur_event_handle_t_> EventPtr{nullptr};
@@ -1290,7 +1253,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMPrefetch(
12901253
ur_queue_handle_t hQueue, const void *pMem, size_t size,
12911254
ur_usm_migration_flags_t flags, uint32_t numEventsInWaitList,
12921255
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
1293-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
12941256
ur_device_handle_t Device = hQueue->getContext()->getDevice();
12951257

12961258
// Certain cuda devices and Windows do not have support for some Unified
@@ -1316,8 +1278,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMPrefetch(
13161278
// flags is currently unused so fail if set
13171279
if (flags != 0)
13181280
return UR_RESULT_ERROR_INVALID_VALUE;
1319-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1320-
UR_ASSERT(pMem, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1281+
13211282
ur_result_t Result = UR_RESULT_SUCCESS;
13221283
std::unique_ptr<ur_event_handle_t_> EventPtr{nullptr};
13231284

@@ -1348,9 +1309,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMPrefetch(
13481309
UR_APIEXPORT ur_result_t UR_APICALL
13491310
urEnqueueUSMAdvise(ur_queue_handle_t hQueue, const void *pMem, size_t size,
13501311
ur_usm_advice_flags_t advice, ur_event_handle_t *phEvent) {
1351-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
1352-
UR_ASSERT(pMem, UR_RESULT_ERROR_INVALID_MEM_OBJECT);
1353-
13541312
// Certain cuda devices and Windows do not have support for some Unified
13551313
// Memory features. Passing CU_MEM_ADVISE_SET/CLEAR_PREFERRED_LOCATION and
13561314
// to cuMemAdvise on a GPU device requires the GPU device to report a non-zero
@@ -1437,7 +1395,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMMemcpy2D(
14371395
const void *pSrc, size_t srcPitch, size_t width, size_t height,
14381396
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
14391397
ur_event_handle_t *phEvent) {
1440-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_QUEUE);
14411398
ur_result_t result = UR_RESULT_SUCCESS;
14421399

14431400
try {
@@ -1484,17 +1441,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferRead(
14841441
ur_queue_handle_t hQueue, ur_mem_handle_t hBuffer, bool blockingRead,
14851442
size_t offset, size_t size, void *pDst, uint32_t numEventsInWaitList,
14861443
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
1487-
1488-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1489-
UR_ASSERT(hBuffer, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
14901444
UR_ASSERT(!hBuffer->isImage(), UR_RESULT_ERROR_INVALID_MEM_OBJECT);
1491-
UR_ASSERT(pDst, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1492-
if (phEventWaitList) {
1493-
UR_ASSERT(numEventsInWaitList > 0, UR_RESULT_ERROR_INVALID_EVENT_WAIT_LIST);
1494-
} else {
1495-
UR_ASSERT(numEventsInWaitList == 0,
1496-
UR_RESULT_ERROR_INVALID_EVENT_WAIT_LIST);
1497-
}
14981445
UR_ASSERT(offset + size <= hBuffer->Mem.BufferMem.Size,
14991446
UR_RESULT_ERROR_INVALID_SIZE);
15001447

@@ -1541,17 +1488,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueMemBufferWrite(
15411488
ur_queue_handle_t hQueue, ur_mem_handle_t hBuffer, bool blockingWrite,
15421489
size_t offset, size_t size, const void *pSrc, uint32_t numEventsInWaitList,
15431490
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
1544-
1545-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1546-
UR_ASSERT(hBuffer, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
15471491
UR_ASSERT(!hBuffer->isImage(), UR_RESULT_ERROR_INVALID_MEM_OBJECT);
1548-
UR_ASSERT(pSrc, UR_RESULT_ERROR_INVALID_NULL_POINTER);
1549-
if (phEventWaitList) {
1550-
UR_ASSERT(numEventsInWaitList > 0, UR_RESULT_ERROR_INVALID_EVENT_WAIT_LIST);
1551-
} else {
1552-
UR_ASSERT(numEventsInWaitList == 0,
1553-
UR_RESULT_ERROR_INVALID_EVENT_WAIT_LIST);
1554-
}
15551492
UR_ASSERT(offset + size <= hBuffer->Mem.BufferMem.Size,
15561493
UR_RESULT_ERROR_INVALID_SIZE);
15571494

@@ -1597,10 +1534,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueDeviceGlobalVariableWrite(
15971534
bool blockingWrite, size_t count, size_t offset, const void *pSrc,
15981535
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
15991536
ur_event_handle_t *phEvent) {
1600-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1601-
UR_ASSERT(hProgram, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1602-
UR_ASSERT(name && pSrc, UR_RESULT_ERROR_INVALID_VALUE);
1603-
16041537
// Since CUDA requires a the global variable to be referenced by name, we use
16051538
// metadata to find the correct name to access it by.
16061539
auto DeviceGlobalNameIt = hProgram->GlobalIDMD.find(name);
@@ -1633,10 +1566,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueDeviceGlobalVariableRead(
16331566
bool blockingRead, size_t count, size_t offset, void *pDst,
16341567
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
16351568
ur_event_handle_t *phEvent) {
1636-
UR_ASSERT(hQueue, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1637-
UR_ASSERT(hProgram, UR_RESULT_ERROR_INVALID_NULL_HANDLE);
1638-
UR_ASSERT(name && pDst, UR_RESULT_ERROR_INVALID_VALUE);
1639-
16401569
// Since CUDA requires a the global variable to be referenced by name, we use
16411570
// metadata to find the correct name to access it by.
16421571
auto DeviceGlobalNameIt = hProgram->GlobalIDMD.find(name);

0 commit comments

Comments
 (0)