Skip to content

Commit 4b71b32

Browse files
committed
Apply several comments
Signed-off-by: Dmitry Sidorov <[email protected]>
1 parent 8f78d1f commit 4b71b32

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

sycl/include/CL/sycl/properties/buffer_properties.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ class context_bound
4343
class mem_channel : public detail::PropertyWithData<
4444
detail::PropWithDataKind::BufferMemChannel> {
4545
public:
46-
mem_channel(uint32_t Channel) : m_Channel(Channel) {}
47-
uint32_t get_channel() const { return m_Channel; }
46+
mem_channel(uint32_t Channel) : MChannel(Channel) {}
47+
uint32_t get_channel() const { return MChannel; }
4848

4949
private:
50-
uint32_t m_Channel;
50+
uint32_t MChannel;
5151
};
5252

5353
} // namespace buffer

sycl/plugins/opencl/pi_opencl.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -572,19 +572,18 @@ pi_result piMemBufferCreate(pi_context context, pi_mem_flags flags, size_t size,
572572
properties + propSize);
573573
// Go through buffer properties. If there is one, that shall be propagated
574574
// to an OpenCL runtime - check if this property is being supported.
575-
for (const auto &prop = supported.begin(); prop != supported.end();
576-
++(*prop)) {
575+
for (auto prop = supported.begin(); prop != supported.end(); ++prop) {
577576
if (SupportedExtensions.find(context) == SupportedExtensions.end())
578577
ret_err = getSupportedExtensionsWithinContext(context);
579578
// Check if PI_MEM_PROPERTIES_CHANNEL property is supported. If it's
580579
// not - just ignore it, as it's an optimization hint.
581580
if (*prop == PI_MEM_PROPERTIES_CHANNEL) {
582581
if (SupportedExtensions[context].find(
583-
"cl_intel_mem_channel_property") !=
582+
"cl_intel_mem_channel_property") ==
584583
SupportedExtensions[context].end())
585-
supported.erase(prop);
584+
prop = supported.erase(prop);
586585
} else
587-
assert("Unsupported property found");
586+
assert(!"Unsupported property found");
588587
}
589588
if (!supported.empty()) {
590589
*ret_mem =

0 commit comments

Comments
 (0)