Skip to content

Commit 4d16a65

Browse files
authored
Merge pull request #1655 from npmiller/hip-skip-spec-cst
[CTS] Skip spec constants tests for HIP
2 parents d5166d5 + d46c214 commit 4d16a65

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

test/conformance/program/program_adapter_hip.match

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,6 @@ urProgramBuildTest.BuildFailure/AMD_HIP_BACKEND___{{.*}}_
2525
{{OPT}}urProgramGetInfoTest.InvalidNullHandleProgram/AMD_HIP_BACKEND___{{.*}}___UR_PROGRAM_INFO_KERNEL_NAMES
2626
{{OPT}}urProgramLinkTest.Success/AMD_HIP_BACKEND___{{.*}}_
2727
{{OPT}}urProgramSetSpecializationConstantsTest.Success/AMD_HIP_BACKEND___{{.*}}_
28-
{{OPT}}{{Segmentation fault|Aborted}}
28+
{{OPT}}urProgramSetSpecializationConstantsTest.UseDefaultValue/AMD_HIP_BACKEND___{{.*}}_
29+
{{OPT}}urProgramSetMultipleSpecializationConstantsTest.MultipleCalls/AMD_HIP_BACKEND___{{.*}}_
30+
{{OPT}}urProgramSetMultipleSpecializationConstantsTest.SingleCall/AMD_HIP_BACKEND___{{.*}}_

test/conformance/program/urProgramSetSpecializationConstants.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,10 @@ TEST_P(urProgramSetSpecializationConstantsTest, UseDefaultValue) {
4848
ASSERT_SUCCESS(urPlatformGetInfo(platform, UR_PLATFORM_INFO_BACKEND,
4949
sizeof(ur_platform_backend_t), &backend,
5050
nullptr));
51-
if (backend == UR_PLATFORM_BACKEND_CUDA) {
52-
GTEST_FAIL()
53-
<< "This test is known to cause crashes on Nvidia; not running.";
51+
if (backend == UR_PLATFORM_BACKEND_CUDA ||
52+
backend == UR_PLATFORM_BACKEND_HIP) {
53+
GTEST_FAIL() << "This test is known to cause crashes on Nvidia and "
54+
"AMD; not running.";
5455
}
5556

5657
ASSERT_SUCCESS(urProgramBuild(context, program, nullptr));

0 commit comments

Comments
 (0)