Skip to content

Commit 4e93de3

Browse files
committed
Move E2E test folder
1 parent ebab034 commit 4e93de3

18 files changed

+14
-6
lines changed

sycl/doc/extensions/experimental/sycl_ext_codeplay_enqueue_native_command.asciidoc

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,16 @@ specification.*
5353

5454
== Backend support status
5555

56-
This extension is currently implemented in {dpcpp} only for GPU devices and
56+
The base extension is currently implemented in {dpcpp} only for GPU devices and
5757
only when using the CUDA or HIP backends. Attempting to use this extension in
5858
kernels that run on other devices or backends may result in undefined
5959
behavior. Be aware that the compiler is not able to issue a diagnostic to
6060
warn you if this happens.
6161

62+
The semantics in the <<sycl-graph-interaction, SYCL-Graph Interaction>> section
63+
however are implemented for all of Level-Zero, OpenCL, CUDA and HIP devices.
64+
Where support is conditional on the device reporting the
65+
`aspect::ext_oneapi_limited_graph` aspect.
6266

6367
== Overview
6468

@@ -245,6 +249,10 @@ bool interop_handle::ext_codeplay_has_graph() const;
245249
----
246250

247251
| Query if the `interop_handle` object has a native graph object available.
252+
Note that host-task nodes in a `command_graph` will return `false` for this,
253+
as host-task commands are executed by the SYCL runtime rather than the
254+
backend device, so there is no native graph object associated with the
255+
command.
248256

249257
|
250258
[source,c++]

unified-runtime/source/adapters/cuda/command_buffer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1486,7 +1486,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendNativeCommandExp(
14861486
const ur_exp_command_buffer_sync_point_t *pSyncPointWaitList,
14871487
ur_exp_command_buffer_sync_point_t *pSyncPoint) {
14881488
try {
1489-
// Call user-define function immediately
1489+
// Call user-defined function immediately
14901490
pfnNativeCommand(pData);
14911491

14921492
// Cuda graph node returned by interop_handle::getNativeGraph() in callback

unified-runtime/source/adapters/hip/command_buffer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1118,7 +1118,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendNativeCommandExp(
11181118
const ur_exp_command_buffer_sync_point_t *pSyncPointWaitList,
11191119
ur_exp_command_buffer_sync_point_t *pSyncPoint) {
11201120
try {
1121-
// Call user-define function immediately
1121+
// Call user-defined function immediately
11221122
pfnNativeCommand(pData);
11231123

11241124
// HIP graph node returned by interop_handle::getNativeGraph() in callback

unified-runtime/source/adapters/level_zero/command_buffer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2368,7 +2368,7 @@ ur_result_t urCommandBufferAppendNativeCommandExp(
23682368
(ZeCommandList, nullptr, ZeEventList.size(),
23692369
getPointerFromVector(ZeEventList)));
23702370

2371-
// Call user-define function immediately
2371+
// Call user-defined function immediately
23722372
pfnNativeCommand(pData);
23732373

23742374
// Barrier on all commands after user defined commands.

unified-runtime/source/adapters/level_zero/v2/command_buffer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,7 @@ ur_result_t urCommandBufferAppendNativeCommandExp(
510510
UR_CALL(
511511
hCommandBuffer->commandListManager.appendBarrier(0, nullptr, nullptr));
512512

513-
// Call user-define function immediately
513+
// Call user-defined function immediately
514514
pfnNativeCommand(pData);
515515

516516
// Barrier on all commands after user defined commands.

unified-runtime/source/adapters/opencl/command_buffer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -756,7 +756,7 @@ ur_result_t UR_APICALL urCommandBufferAppendNativeCommandExp(
756756
hCommandBuffer->CLCommandBuffer, nullptr, nullptr, WaitListSize,
757757
SyncPointWaitList, nullptr, nullptr));
758758

759-
// Call user-define function immediately
759+
// Call user-defined function immediately
760760
pfnNativeCommand(pData);
761761

762762
// Barrier on all commands after user defined commands.

0 commit comments

Comments
 (0)