[SYCL][Driver] Remove temporary string usage in HandleXarchArgs (#13248)

jinge90 · web-flow · commit 4f6ccb2fd820 · 2024-04-05T09:34:01.000+02:00
We should use string which is valid during the whole compilation phase
instead of a temporary string.

Signed-off-by: jinge90 &lt;ge.jin@intel.com&gt;
diff --git a/clang/lib/Driver/Compilation.cpp b/clang/lib/Driver/Compilation.cpp
@@ -99,7 +99,7 @@ static void HandleXarchArgs(DerivedArgList *OffloadArgList, const Driver &D,
               OffloadArgList->MakeArgStringRef(XarchVecs[Index]));
       }
     } else
-      XarchValueRefs.push_back(StringRef(XarchV));
+      XarchValueRefs.push_back(OffloadArgList->MakeArgString(XarchV));
   }
 
   if (NeedHandle) {

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ static void HandleXarchArgs(DerivedArgList *OffloadArgList, const Driver &D,`
`99`	`99`	`OffloadArgList->MakeArgStringRef(XarchVecs[Index]));`
`100`	`100`	`}`
`101`	`101`	`} else`
`102`		`- XarchValueRefs.push_back(StringRef(XarchV));`
	`102`	`+ XarchValueRefs.push_back(OffloadArgList->MakeArgString(XarchV));`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`if (NeedHandle) {`