Skip to content

Commit 4f86ed2

Browse files
committed
[SPIR-V] Remove FuncParamKindINTEL and FuncParamDescINTEL
These decorations doesn't present in https://github.com/KhronosGroup/SPIRV-LLVM-Translator Signed-off-by: Dmitry Sidorov <[email protected]>
1 parent 90c79c7 commit 4f86ed2

File tree

10 files changed

+0
-118
lines changed

10 files changed

+0
-118
lines changed

llvm-spirv/lib/SPIRV/SPIRVReader.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4124,20 +4124,8 @@ bool SPIRVToLLVM::transVectorComputeMetadata(SPIRVFunction *BF) {
41244124
std::to_string(Kind));
41254125
F->addAttribute(ArgNo + 1, Attr);
41264126
}
4127-
if (BA->hasDecorate(DecorationFuncParamKindINTEL, 0, &Kind)) {
4128-
Attribute Attr = Attribute::get(*Context, kVCMetadata::VCArgumentKind,
4129-
std::to_string(Kind));
4130-
F->addAttribute(ArgNo + 1, Attr);
4131-
}
41324127
if (BA->hasDecorate(DecorationSingleElementVectorINTEL))
41334128
F->addAttribute(ArgNo + 1, SEVAttr);
4134-
if (BA->hasDecorate(DecorationFuncParamDescINTEL)) {
4135-
auto Desc =
4136-
BA->getDecorationStringLiteral(DecorationFuncParamDescINTEL).front();
4137-
Attribute Attr =
4138-
Attribute::get(*Context, kVCMetadata::VCArgumentDesc, Desc);
4139-
F->addAttribute(ArgNo + 1, Attr);
4140-
}
41414129
}
41424130

41434131
// Do not add float control if there is no any

llvm-spirv/lib/SPIRV/SPIRVWriter.cpp

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -687,19 +687,6 @@ void LLVMToSPIRV::transVectorComputeMetadata(Function *F) {
687687
"This decoration is valid only for Scalar or Pointer types");
688688
BA->addDecorate(DecorationSingleElementVectorINTEL);
689689
}
690-
if (Attrs.hasAttribute(ArgNo + 1, kVCMetadata::VCArgumentKind)) {
691-
SPIRVWord Kind;
692-
Attrs.getAttribute(ArgNo + 1, kVCMetadata::VCArgumentKind)
693-
.getValueAsString()
694-
.getAsInteger(0, Kind);
695-
BA->addDecorate(DecorationFuncParamKindINTEL, Kind);
696-
}
697-
if (Attrs.hasAttribute(ArgNo + 1, kVCMetadata::VCArgumentDesc)) {
698-
StringRef Desc =
699-
Attrs.getAttribute(ArgNo + 1, kVCMetadata::VCArgumentDesc)
700-
.getValueAsString();
701-
BA->addDecorate(new SPIRVDecorateFuncParamDescAttr(BA, Desc.str()));
702-
}
703690
}
704691
if (!isKernel(F) &&
705692
BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_float_controls2) &&

llvm-spirv/lib/SPIRV/VectorComputeUtil.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,6 @@ const static char VCGlobalVariable[] = "VCGlobalVariable";
108108
const static char VCVolatile[] = "VCVolatile";
109109
const static char VCByteOffset[] = "VCByteOffset";
110110
const static char VCSIMTCall[] = "VCSIMTCall";
111-
const static char VCArgumentKind[] = "VCArgumentKind";
112-
const static char VCArgumentDesc[] = "VCArgumentDesc";
113111
const static char VCCallable[] = "VCCallable";
114112
const static char VCSingleElementVector[] = "VCSingleElementVector";
115113
const static char VCFCEntry[] = "VCFCEntry";

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVDecorate.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,6 @@ void SPIRVDecorate::encode(spv_ostream &O) const {
113113
case DecorationUserSemantic:
114114
SPIRVDecorateUserSemanticAttr::encodeLiterals(Encoder, Literals);
115115
break;
116-
case DecorationFuncParamDescINTEL:
117-
SPIRVDecorateFuncParamDescAttr::encodeLiterals(Encoder, Literals);
118-
break;
119116
default:
120117
Encoder << Literals;
121118
}
@@ -142,9 +139,6 @@ void SPIRVDecorate::decode(std::istream &I) {
142139
case DecorationUserSemantic:
143140
SPIRVDecorateUserSemanticAttr::decodeLiterals(Decoder, Literals);
144141
break;
145-
case DecorationFuncParamDescINTEL:
146-
SPIRVDecorateFuncParamDescAttr::decodeLiterals(Decoder, Literals);
147-
break;
148142
default:
149143
Decoder >> Literals;
150144
}
@@ -164,9 +158,6 @@ void SPIRVMemberDecorate::encode(spv_ostream &O) const {
164158
case DecorationUserSemantic:
165159
SPIRVDecorateUserSemanticAttr::encodeLiterals(Encoder, Literals);
166160
break;
167-
case DecorationFuncParamDescINTEL:
168-
SPIRVDecorateFuncParamDescAttr::encodeLiterals(Encoder, Literals);
169-
break;
170161
default:
171162
Encoder << Literals;
172163
}
@@ -190,9 +181,6 @@ void SPIRVMemberDecorate::decode(std::istream &I) {
190181
case DecorationUserSemantic:
191182
SPIRVDecorateUserSemanticAttr::decodeLiterals(Decoder, Literals);
192183
break;
193-
case DecorationFuncParamDescINTEL:
194-
SPIRVDecorateFuncParamDescAttr::decodeLiterals(Decoder, Literals);
195-
break;
196184
default:
197185
Decoder >> Literals;
198186
}

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVDecorate.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -453,15 +453,6 @@ class SPIRVDecorateUserSemanticAttr
453453
: SPIRVDecorateStrAttrBase(TheTarget, AnnotateString) {}
454454
};
455455

456-
class SPIRVDecorateFuncParamDescAttr
457-
: public SPIRVDecorateStrAttrBase<DecorationFuncParamDescINTEL> {
458-
public:
459-
// Complete constructor for UserSemantic decoration
460-
SPIRVDecorateFuncParamDescAttr(SPIRVEntry *TheTarget,
461-
const std::string &AnnotateString)
462-
: SPIRVDecorateStrAttrBase(TheTarget, AnnotateString) {}
463-
};
464-
465456
class SPIRVDecorateMergeINTELAttr : public SPIRVDecorate {
466457
public:
467458
// Complete constructor for MergeINTEL decoration

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVEnum.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,8 +398,6 @@ template <> inline void SPIRVMap<Decoration, SPIRVCapVec>::init() {
398398
ADD_VEC_INIT(DecorationFuncParamIOKindINTEL, {CapabilityVectorComputeINTEL});
399399
ADD_VEC_INIT(DecorationStackCallINTEL, {CapabilityVectorComputeINTEL});
400400
ADD_VEC_INIT(DecorationSIMTCallINTEL, {CapabilityVectorComputeINTEL});
401-
ADD_VEC_INIT(DecorationFuncParamKindINTEL, {CapabilityVectorComputeINTEL});
402-
ADD_VEC_INIT(DecorationFuncParamDescINTEL, {CapabilityVectorComputeINTEL});
403401
ADD_VEC_INIT(DecorationBurstCoalesceINTEL,
404402
{CapabilityFPGAMemoryAccessesINTEL});
405403
ADD_VEC_INIT(DecorationCacheSizeINTEL, {CapabilityFPGAMemoryAccessesINTEL});

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,6 @@ template <> inline void SPIRVMap<Decoration, std::string>::init() {
158158
add(DecorationCacheSizeINTEL, "CacheSizeINTEL");
159159
add(DecorationDontStaticallyCoalesceINTEL, "DontStaticallyCoalesceINTEL");
160160
add(DecorationPrefetchINTEL, "PrefetchINTEL");
161-
add(DecorationFuncParamKindINTEL, "FuncParamKindINTEL");
162-
add(DecorationFuncParamDescINTEL, "FuncParamDescINTEL");
163161
add(DecorationBufferLocationINTEL, "BufferLocationINTEL");
164162
add(DecorationIOPipeStorageINTEL, "IOPipeStorageINTEL");
165163
add(DecorationFunctionFloatingPointModeINTEL,

llvm-spirv/lib/SPIRV/libSPIRV/spirv.hpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -509,8 +509,6 @@ enum Decoration {
509509
DecorationRestrictPointerEXT = 5355,
510510
DecorationAliasedPointer = 5356,
511511
DecorationAliasedPointerEXT = 5356,
512-
DecorationFuncParamKindINTEL = 9624,
513-
DecorationFuncParamDescINTEL = 9625,
514512
DecorationSIMTCallINTEL = 5599,
515513
DecorationReferencedIndirectlyINTEL = 5602,
516514
DecorationClobberINTEL = 5607,

llvm-spirv/test/transcoding/decoration_func_param_desc.ll

Lines changed: 0 additions & 32 deletions
This file was deleted.

llvm-spirv/test/transcoding/decoration_func_param_kind.ll

Lines changed: 0 additions & 32 deletions
This file was deleted.

0 commit comments

Comments
 (0)