Skip to content

Commit 5096c20

Browse files
authored
[SYCL] BE is expecting FP accuracy values without the suffix "f". (#10525)
Currently we are passing values of the FP accuracy with an "f" suffix. The backend is expecting those values without the suffix. This patch removes them.
1 parent f40132b commit 5096c20

File tree

4 files changed

+86
-86
lines changed

4 files changed

+86
-86
lines changed

clang/test/CodeGen/fp-accuracy.c

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,9 @@ double rsqrt(double);
188188
// CHECK-F3: call double @llvm.fpbuiltin.tan.f64(double %conv72) #[[ATTR_F3_LOW:[0-9]+]]
189189
// CHECK-F3: call double @llvm.fpbuiltin.tanh.f64(double %conv74) #[[ATTR_F3_HIGH]]
190190

191-
// CHECK-F3: attributes #[[ATTR_F3_HIGH]] = {{.*}}"fpbuiltin-max-error"="1.0f"
192-
// CHECK-F3: attributes #[[ATTR_F3_MEDIUM]] = {{.*}}"fpbuiltin-max-error"="4.0f"
193-
// CHECK-F3: attributes #[[ATTR_F3_LOW]] = {{.*}}"fpbuiltin-max-error"="67108864.0f"
191+
// CHECK-F3: attributes #[[ATTR_F3_HIGH]] = {{.*}}"fpbuiltin-max-error"="1.0"
192+
// CHECK-F3: attributes #[[ATTR_F3_MEDIUM]] = {{.*}}"fpbuiltin-max-error"="4.0"
193+
// CHECK-F3: attributes #[[ATTR_F3_LOW]] = {{.*}}"fpbuiltin-max-error"="67108864.0"
194194
//
195195
// CHECK-SPIR-LABEL: define dso_local spir_func void @f1
196196
// CHECK-SPIR: call double @llvm.fpbuiltin.acos.f64(double {{.*}}) #[[ATTR_SYCL1:[0-9]+]]
@@ -305,24 +305,24 @@ void f1(float a, float b) {
305305
// CHECK-SPIR-LABEL: define dso_local spir_func void @f3
306306
// CHECK-SPIR: call spir_func float @fake_exp10(float {{.*}})
307307

308-
// CHECK: attributes #[[ATTR_HIGH]] = {{.*}}"fpbuiltin-max-error"="1.0f"
308+
// CHECK: attributes #[[ATTR_HIGH]] = {{.*}}"fpbuiltin-max-error"="1.0"
309309

310-
// CHECK-F1: attributes #[[ATTR_F1_HIGH]] = {{.*}}"fpbuiltin-max-error"="1.0f"
311-
// CHECK-F1: attributes #[[ATTR_F1_MEDIUM]] = {{.*}}"fpbuiltin-max-error"="4.0f"
312-
// CHECK-F1: attributes #[[ATTR_F1_LOW]] = {{.*}}"fpbuiltin-max-error"="67108864.0f"
310+
// CHECK-F1: attributes #[[ATTR_F1_HIGH]] = {{.*}}"fpbuiltin-max-error"="1.0"
311+
// CHECK-F1: attributes #[[ATTR_F1_MEDIUM]] = {{.*}}"fpbuiltin-max-error"="4.0"
312+
// CHECK-F1: attributes #[[ATTR_F1_LOW]] = {{.*}}"fpbuiltin-max-error"="67108864.0"
313313

314-
// CHECK-F2: attributes #[[ATTR_F2_MEDIUM]] = {{.*}}"fpbuiltin-max-error"="4.0f"
315-
// CHECK-F2: attributes #[[ATTR_F2_CUDA]] = {{.*}}"fpbuiltin-max-error"="2.0f"
316-
// CHECK-F2: attributes #[[ATTR_F2_HIGH]] = {{.*}}"fpbuiltin-max-error"="1.0f"
314+
// CHECK-F2: attributes #[[ATTR_F2_MEDIUM]] = {{.*}}"fpbuiltin-max-error"="4.0"
315+
// CHECK-F2: attributes #[[ATTR_F2_CUDA]] = {{.*}}"fpbuiltin-max-error"="2.0"
316+
// CHECK-F2: attributes #[[ATTR_F2_HIGH]] = {{.*}}"fpbuiltin-max-error"="1.0"
317317

318-
// CHECK-SPIR: attributes #[[ATTR_SYCL1]] = {{.*}}"fpbuiltin-max-error"="4.0f"
319-
// CHECK-SPIR: attributes #[[ATTR_SYCL2]] = {{.*}}"fpbuiltin-max-error"="5.0f"
320-
// CHECK-SPIR: attributes #[[ATTR_SYCL3]] = {{.*}}"fpbuiltin-max-error"="6.0f"
321-
// CHECK-SPIR: attributes #[[ATTR_SYCL4]] = {{.*}}"fpbuiltin-max-error"="16.0f"
322-
// CHECK-SPIR: attributes #[[ATTR_SYCL5]] = {{.*}}"fpbuiltin-max-error"="3.0f"
323-
// CHECK-SPIR: attributes #[[ATTR_SYCL6]] = {{.*}}"fpbuiltin-max-error"="0.0f"
324-
// CHECK-SPIR: attributes #[[ATTR_SYCL7]] = {{.*}}"fpbuiltin-max-error"="2.5f"
325-
// CHECK-SPIR: attributes #[[ATTR_SYCL8]] = {{.*}}"fpbuiltin-max-error"="2.0f"
318+
// CHECK-SPIR: attributes #[[ATTR_SYCL1]] = {{.*}}"fpbuiltin-max-error"="4.0"
319+
// CHECK-SPIR: attributes #[[ATTR_SYCL2]] = {{.*}}"fpbuiltin-max-error"="5.0"
320+
// CHECK-SPIR: attributes #[[ATTR_SYCL3]] = {{.*}}"fpbuiltin-max-error"="6.0"
321+
// CHECK-SPIR: attributes #[[ATTR_SYCL4]] = {{.*}}"fpbuiltin-max-error"="16.0"
322+
// CHECK-SPIR: attributes #[[ATTR_SYCL5]] = {{.*}}"fpbuiltin-max-error"="3.0"
323+
// CHECK-SPIR: attributes #[[ATTR_SYCL6]] = {{.*}}"fpbuiltin-max-error"="0.0"
324+
// CHECK-SPIR: attributes #[[ATTR_SYCL7]] = {{.*}}"fpbuiltin-max-error"="2.5"
325+
// CHECK-SPIR: attributes #[[ATTR_SYCL8]] = {{.*}}"fpbuiltin-max-error"="2.0"
326326

327327
// CHECK-DEFAULT-LABEL: define dso_local void @f1
328328
// CHECK-DEFAULT: call double @acos(double noundef {{.*}})

llvm/include/llvm/IR/FPAccuracy.def

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -27,39 +27,39 @@
2727
//
2828
// FP_ACCURACY(<IID>, <SYCL_FLOAT>, <SYCL_DOUBLE>, <CUDA_FLOAT>, <CUDA_DOUBLE>)
2929
//
30-
FP_ACCURACY(fpbuiltin_fadd, "0.0f", "0.0f", "0.0f", "0.0f")
31-
FP_ACCURACY(fpbuiltin_fsub, "0.0f", "0.0f", "0.0f", "0.0f")
32-
FP_ACCURACY(fpbuiltin_fmul, "0.0f", "0.0f", "0.0f", "0.0f")
33-
FP_ACCURACY(fpbuiltin_fdiv, "2.5f", "0.0f", "2.0f", "0.0f")
34-
FP_ACCURACY(fpbuiltin_frem, "0.0f", "0.0f", "0.0f", "0.0f")
35-
FP_ACCURACY(fpbuiltin_sin, "4.0f", "4.0f", "2.0f", "2.0f")
36-
FP_ACCURACY(fpbuiltin_cos, "4.0f", "4.0f", "2.0f", "2.0f")
37-
FP_ACCURACY(fpbuiltin_tan, "5.0f", "5.0f", "4.0f", "2.0f")
38-
FP_ACCURACY(fpbuiltin_sinh, "4.0f", "4.0f", "3.0f", "2.0f")
39-
FP_ACCURACY(fpbuiltin_cosh, "4.0f", "4.0f", "3.0f", "2.0f")
40-
FP_ACCURACY(fpbuiltin_tanh, "5.0f", "5.0f", "2.0f", "2.0f")
41-
FP_ACCURACY(fpbuiltin_asin, "4.0f", "4.0f", "4.0f", "2.0f")
42-
FP_ACCURACY(fpbuiltin_acos, "4.0f", "4.0f", "3.0f", "2.0f")
43-
FP_ACCURACY(fpbuiltin_atan, "5.0f", "5.0f", "2.0f", "2.0f")
44-
FP_ACCURACY(fpbuiltin_atan2, "6.0f", "6.0f", "3.0f", "2.0f")
45-
FP_ACCURACY(fpbuiltin_asinh, "4.0f", "4.0f", "3.0f", "2.0f")
46-
FP_ACCURACY(fpbuiltin_acosh, "4.0f", "4.0f", "4.0f", "2.0f")
47-
FP_ACCURACY(fpbuiltin_atanh, "5.0f", "5.0f", "3.0f", "2.0f")
48-
FP_ACCURACY(fpbuiltin_exp, "3.0f", "3.0f", "2.0f", "1.0f")
49-
FP_ACCURACY(fpbuiltin_exp2, "3.0f", "3.0f", "2.0f", "1.0f")
50-
FP_ACCURACY(fpbuiltin_exp10, "3.0f", "3.0f", "2.0f", "1.0f")
51-
FP_ACCURACY(fpbuiltin_expm1, "3.0f", "3.0f", "1.0f", "1.0f")
52-
FP_ACCURACY(fpbuiltin_log, "3.0f", "3.0f", "1.0f", "1.0f")
53-
FP_ACCURACY(fpbuiltin_log2, "3.0f", "3.0f", "1.0f", "1.0f")
54-
FP_ACCURACY(fpbuiltin_log10, "3.0f", "3.0f", "2.0f", "1.0f")
55-
FP_ACCURACY(fpbuiltin_log1p, "2.0f", "2.0f", "1.0f", "1.0f")
56-
FP_ACCURACY(fpbuiltin_hypot, "4.0f", "4.0f", "3.0f", "2.0f")
57-
FP_ACCURACY(fpbuiltin_pow, "16.0f", "16.0f", "8.0f", "2.0f")
58-
FP_ACCURACY(fpbuiltin_ldexp, "0.0f", "0.0f", "0.0f", "0.0f")
59-
FP_ACCURACY(fpbuiltin_sqrt, "2.5f", "0.0f", "2.0f", "0.0f")
60-
FP_ACCURACY(fpbuiltin_rsqrt, "2.0f", "2.0f", "2.0f", "1.0f")
61-
FP_ACCURACY(fpbuiltin_erf, "16.0f", "16.0f", "2.0f", "2.0f")
62-
FP_ACCURACY(fpbuiltin_erfc, "16.0f", "16.0f", "4.0f", "5.0f")
63-
FP_ACCURACY(fpbuiltin_sincos, "4.0f", "4.0f", "2.0f", "2.0f")
30+
FP_ACCURACY(fpbuiltin_fadd, "0.0", "0.0", "0.0", "0.0")
31+
FP_ACCURACY(fpbuiltin_fsub, "0.0", "0.0", "0.0", "0.0")
32+
FP_ACCURACY(fpbuiltin_fmul, "0.0", "0.0", "0.0", "0.0")
33+
FP_ACCURACY(fpbuiltin_fdiv, "2.5", "0.0", "2.0", "0.0")
34+
FP_ACCURACY(fpbuiltin_frem, "0.0", "0.0", "0.0", "0.0")
35+
FP_ACCURACY(fpbuiltin_sin, "4.0", "4.0", "2.0", "2.0")
36+
FP_ACCURACY(fpbuiltin_cos, "4.0", "4.0", "2.0", "2.0")
37+
FP_ACCURACY(fpbuiltin_tan, "5.0", "5.0", "4.0", "2.0")
38+
FP_ACCURACY(fpbuiltin_sinh, "4.0", "4.0", "3.0", "2.0")
39+
FP_ACCURACY(fpbuiltin_cosh, "4.0", "4.0", "3.0", "2.0")
40+
FP_ACCURACY(fpbuiltin_tanh, "5.0", "5.0", "2.0", "2.0")
41+
FP_ACCURACY(fpbuiltin_asin, "4.0", "4.0", "4.0", "2.0")
42+
FP_ACCURACY(fpbuiltin_acos, "4.0", "4.0", "3.0", "2.0")
43+
FP_ACCURACY(fpbuiltin_atan, "5.0", "5.0", "2.0", "2.0")
44+
FP_ACCURACY(fpbuiltin_atan2, "6.0", "6.0", "3.0", "2.0")
45+
FP_ACCURACY(fpbuiltin_asinh, "4.0", "4.0", "3.0", "2.0")
46+
FP_ACCURACY(fpbuiltin_acosh, "4.0", "4.0", "4.0", "2.0")
47+
FP_ACCURACY(fpbuiltin_atanh, "5.0", "5.0", "3.0", "2.0")
48+
FP_ACCURACY(fpbuiltin_exp, "3.0", "3.0", "2.0", "1.0")
49+
FP_ACCURACY(fpbuiltin_exp2, "3.0", "3.0", "2.0", "1.0")
50+
FP_ACCURACY(fpbuiltin_exp10, "3.0", "3.0", "2.0", "1.0")
51+
FP_ACCURACY(fpbuiltin_expm1, "3.0", "3.0", "1.0", "1.0")
52+
FP_ACCURACY(fpbuiltin_log, "3.0", "3.0", "1.0", "1.0")
53+
FP_ACCURACY(fpbuiltin_log2, "3.0", "3.0", "1.0", "1.0")
54+
FP_ACCURACY(fpbuiltin_log10, "3.0", "3.0", "2.0", "1.0")
55+
FP_ACCURACY(fpbuiltin_log1p, "2.0", "2.0", "1.0", "1.0")
56+
FP_ACCURACY(fpbuiltin_hypot, "4.0", "4.0", "3.0", "2.0")
57+
FP_ACCURACY(fpbuiltin_pow, "16.0", "16.0", "8.0", "2.0")
58+
FP_ACCURACY(fpbuiltin_ldexp, "0.0", "0.0", "0.0", "0.0")
59+
FP_ACCURACY(fpbuiltin_sqrt, "2.5", "0.0", "2.0", "0.0")
60+
FP_ACCURACY(fpbuiltin_rsqrt, "2.0", "2.0", "2.0", "1.0")
61+
FP_ACCURACY(fpbuiltin_erf, "16.0", "16.0", "2.0", "2.0")
62+
FP_ACCURACY(fpbuiltin_erfc, "16.0", "16.0", "4.0", "5.0")
63+
FP_ACCURACY(fpbuiltin_sincos, "4.0", "4.0", "2.0", "2.0")
6464

6565
#undef FP_ACCURACY

llvm/lib/IR/FPAccuracy.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,17 +90,17 @@ StringRef fp::getAccuracyForFPBuiltin(Intrinsic::ID IID, const Type *Ty,
9090

9191
// High and medium accuracy have the same requirement for all functions
9292
if (AccuracyLevel == fp::FPAccuracy::High)
93-
return "1.0f";
93+
return "1.0";
9494
if (AccuracyLevel == fp::FPAccuracy::Medium)
95-
return "4.0f";
95+
return "4.0";
9696

9797
// Low accuracy is computed in terms of accurate bits, so it depends on the
9898
// type
9999
if (AccuracyLevel == fp::FPAccuracy::Low) {
100100
if (Ty->isFloatTy())
101-
return "8192.0f";
101+
return "8192.0";
102102
if (Ty->isDoubleTy())
103-
return "67108864.0f"; // 2^(53-26-1) == 26-bits of accuracy
103+
return "67108864.0"; // 2^(53-26-1) == 26-bits of accuracy
104104

105105
// Other types are not supported
106106
llvm_unreachable("Unexpected type for FPAccuracy");

llvm/unittests/IR/FPAccuracyTest.cpp

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,23 @@ TEST(AccuracyLookupTest, TestScalarFloatAccuracy) {
1717

1818
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, FloatTy,
1919
fp::FPAccuracy::High);
20-
EXPECT_EQ("1.0f", Accuracy);
20+
EXPECT_EQ("1.0", Accuracy);
2121

2222
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, FloatTy,
2323
fp::FPAccuracy::Medium);
24-
EXPECT_EQ("4.0f", Accuracy);
24+
EXPECT_EQ("4.0", Accuracy);
2525

2626
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, FloatTy,
2727
fp::FPAccuracy::Low);
28-
EXPECT_EQ("8192.0f", Accuracy);
28+
EXPECT_EQ("8192.0", Accuracy);
2929

3030
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, FloatTy,
3131
fp::FPAccuracy::SYCL);
32-
EXPECT_EQ("5.0f", Accuracy);
32+
EXPECT_EQ("5.0", Accuracy);
3333

3434
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, FloatTy,
3535
fp::FPAccuracy::CUDA);
36-
EXPECT_EQ("4.0f", Accuracy);
36+
EXPECT_EQ("4.0", Accuracy);
3737
}
3838

3939
TEST(AccuracyLookupTest, TestScalarDoubleAccuracy) {
@@ -44,24 +44,24 @@ TEST(AccuracyLookupTest, TestScalarDoubleAccuracy) {
4444

4545
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, DoubleTy,
4646
fp::FPAccuracy::High);
47-
EXPECT_EQ("1.0f", Accuracy);
47+
EXPECT_EQ("1.0", Accuracy);
4848

4949
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, DoubleTy,
5050
fp::FPAccuracy::Medium);
51-
EXPECT_EQ("4.0f", Accuracy);
51+
EXPECT_EQ("4.0", Accuracy);
5252

5353
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, DoubleTy,
5454
fp::FPAccuracy::Low);
5555
// 67108864.0f == 2^(53-26-1) == 26-bits of accuracy
56-
EXPECT_EQ("67108864.0f", Accuracy);
56+
EXPECT_EQ("67108864.0", Accuracy);
5757

5858
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, DoubleTy,
5959
fp::FPAccuracy::SYCL);
60-
EXPECT_EQ("5.0f", Accuracy);
60+
EXPECT_EQ("5.0", Accuracy);
6161

6262
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, DoubleTy,
6363
fp::FPAccuracy::CUDA);
64-
EXPECT_EQ("2.0f", Accuracy);
64+
EXPECT_EQ("2.0", Accuracy);
6565
}
6666

6767
TEST(AccuracyLookupTest, TestFixedVectorFloatAccuracy) {
@@ -72,23 +72,23 @@ TEST(AccuracyLookupTest, TestFixedVectorFloatAccuracy) {
7272

7373
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecFloatTy,
7474
fp::FPAccuracy::High);
75-
EXPECT_EQ("1.0f", Accuracy);
75+
EXPECT_EQ("1.0", Accuracy);
7676

7777
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecFloatTy,
7878
fp::FPAccuracy::Medium);
79-
EXPECT_EQ("4.0f", Accuracy);
79+
EXPECT_EQ("4.0", Accuracy);
8080

8181
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecFloatTy,
8282
fp::FPAccuracy::Low);
83-
EXPECT_EQ("8192.0f", Accuracy);
83+
EXPECT_EQ("8192.0", Accuracy);
8484

8585
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, VecFloatTy,
8686
fp::FPAccuracy::SYCL);
87-
EXPECT_EQ("5.0f", Accuracy);
87+
EXPECT_EQ("5.0", Accuracy);
8888

8989
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, VecFloatTy,
9090
fp::FPAccuracy::CUDA);
91-
EXPECT_EQ("4.0f", Accuracy);
91+
EXPECT_EQ("4.0", Accuracy);
9292
}
9393

9494
TEST(AccuracyLookupTest, TestFixedVectorDoubleAccuracy) {
@@ -99,24 +99,24 @@ TEST(AccuracyLookupTest, TestFixedVectorDoubleAccuracy) {
9999

100100
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecDoubleTy,
101101
fp::FPAccuracy::High);
102-
EXPECT_EQ("1.0f", Accuracy);
102+
EXPECT_EQ("1.0", Accuracy);
103103

104104
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecDoubleTy,
105105
fp::FPAccuracy::Medium);
106-
EXPECT_EQ("4.0f", Accuracy);
106+
EXPECT_EQ("4.0", Accuracy);
107107

108108
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecDoubleTy,
109109
fp::FPAccuracy::Low);
110110
// 67108864.0f == 2^(53-26-1) == 26-bits of accuracy
111-
EXPECT_EQ("67108864.0f", Accuracy);
111+
EXPECT_EQ("67108864.0", Accuracy);
112112

113113
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, VecDoubleTy,
114114
fp::FPAccuracy::SYCL);
115-
EXPECT_EQ("5.0f", Accuracy);
115+
EXPECT_EQ("5.0", Accuracy);
116116

117117
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, VecDoubleTy,
118118
fp::FPAccuracy::CUDA);
119-
EXPECT_EQ("2.0f", Accuracy);
119+
EXPECT_EQ("2.0", Accuracy);
120120
}
121121

122122
TEST(AccuracyLookupTest, TestScalableVectorFloatAccuracy) {
@@ -127,23 +127,23 @@ TEST(AccuracyLookupTest, TestScalableVectorFloatAccuracy) {
127127

128128
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecFloatTy,
129129
fp::FPAccuracy::High);
130-
EXPECT_EQ("1.0f", Accuracy);
130+
EXPECT_EQ("1.0", Accuracy);
131131

132132
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecFloatTy,
133133
fp::FPAccuracy::Medium);
134-
EXPECT_EQ("4.0f", Accuracy);
134+
EXPECT_EQ("4.0", Accuracy);
135135

136136
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecFloatTy,
137137
fp::FPAccuracy::Low);
138-
EXPECT_EQ("8192.0f", Accuracy);
138+
EXPECT_EQ("8192.0", Accuracy);
139139

140140
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, VecFloatTy,
141141
fp::FPAccuracy::SYCL);
142-
EXPECT_EQ("5.0f", Accuracy);
142+
EXPECT_EQ("5.0", Accuracy);
143143

144144
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, VecFloatTy,
145145
fp::FPAccuracy::CUDA);
146-
EXPECT_EQ("4.0f", Accuracy);
146+
EXPECT_EQ("4.0", Accuracy);
147147
}
148148

149149
TEST(AccuracyLookupTest, TestScalableVectorDoubleAccuracy) {
@@ -154,24 +154,24 @@ TEST(AccuracyLookupTest, TestScalableVectorDoubleAccuracy) {
154154

155155
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecDoubleTy,
156156
fp::FPAccuracy::High);
157-
EXPECT_EQ("1.0f", Accuracy);
157+
EXPECT_EQ("1.0", Accuracy);
158158

159159
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecDoubleTy,
160160
fp::FPAccuracy::Medium);
161-
EXPECT_EQ("4.0f", Accuracy);
161+
EXPECT_EQ("4.0", Accuracy);
162162

163163
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_cos, VecDoubleTy,
164164
fp::FPAccuracy::Low);
165165
// 67108864.0f == 2^(53-26-1) == 26-bits of accuracy
166-
EXPECT_EQ("67108864.0f", Accuracy);
166+
EXPECT_EQ("67108864.0", Accuracy);
167167

168168
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, VecDoubleTy,
169169
fp::FPAccuracy::SYCL);
170-
EXPECT_EQ("5.0f", Accuracy);
170+
EXPECT_EQ("5.0", Accuracy);
171171

172172
Accuracy = fp::getAccuracyForFPBuiltin(Intrinsic::fpbuiltin_tan, VecDoubleTy,
173173
fp::FPAccuracy::CUDA);
174-
EXPECT_EQ("2.0f", Accuracy);
174+
EXPECT_EQ("2.0", Accuracy);
175175
}
176176

177177
} // end namespace

0 commit comments

Comments
 (0)