Skip to content

Commit 50d283b

Browse files
committed
changed the enum variable per Alexey's request
Signed-off-by: Byoungro So <[email protected]>
1 parent 85d75cf commit 50d283b

File tree

5 files changed

+13
-15
lines changed

5 files changed

+13
-15
lines changed

sycl/source/detail/scheduler/commands.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ bool Command::enqueue(EnqueueResultT &EnqueueResult, BlockingT Blocking) {
172172
if (MIsBlockable && !MCanEnqueue) {
173173
// Exit if enqueue type is not blocking
174174
if (!Blocking) {
175-
EnqueueResult = EnqueueResultT(EnqueueResultT::SYCL_BLOCKED, this);
175+
EnqueueResult = EnqueueResultT(EnqueueResultT::SYCL_ENQUEUE_BLOCKED, this);
176176
return false;
177177
}
178178
static bool ThrowOnBlock = getenv("SYCL_THROW_ON_BLOCK") != nullptr;
@@ -196,7 +196,7 @@ bool Command::enqueue(EnqueueResultT &EnqueueResult, BlockingT Blocking) {
196196
cl_int Res = enqueueImp();
197197

198198
if (CL_SUCCESS != Res)
199-
EnqueueResult = EnqueueResultT(EnqueueResultT::SYCL_FAILED, this, Res);
199+
EnqueueResult = EnqueueResultT(EnqueueResultT::SYCL_ENQUEUE_FAILED, this, Res);
200200
else
201201
// Consider the command is successfully enqueued if return code is
202202
// CL_SUCCESS

sycl/source/detail/scheduler/commands.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ enum BlockingT { NON_BLOCKING = 0, BLOCKING };
3939
// The struct represents the result of command enqueueing
4040
struct EnqueueResultT {
4141
enum ResultT { SYCL_ENQUEUE_SUCCESS, SYCL_ENQUEUE_BLOCKED, SYCL_ENQUEUE_FAILED };
42-
EnqueueResultT(ResultT Result = SYCL_SUCCESS, Command *Cmd = nullptr,
42+
EnqueueResultT(ResultT Result = SYCL_ENQUEUE_SUCCESS, Command *Cmd = nullptr,
4343
cl_int ErrCode = CL_SUCCESS)
4444
: MResult(Result), MCmd(Cmd), MErrCode(ErrCode) {}
4545
// Indicates result of enqueueing

sycl/source/detail/scheduler/graph_processor.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ void Scheduler::GraphProcessor::waitForEvent(EventImplPtr Event) {
4141
assert(Cmd && "Event has no associated command?");
4242
EnqueueResultT Res;
4343
bool Enqueued = enqueueCommand(Cmd, Res, BLOCKING);
44-
if (!Enqueued && EnqueueResultT::SYCL_FAILED == Res.MResult)
44+
if (!Enqueued && EnqueueResultT::SYCL_ENQUEUE_FAILED == Res.MResult)
4545
// TODO: Reschedule commands.
4646
throw runtime_error("Enqueue process failed.");
4747

@@ -66,12 +66,12 @@ bool Scheduler::GraphProcessor::enqueueCommand(Command *Cmd,
6666
enqueueCommand(Dep.MDepCommand, EnqueueResult, Blocking);
6767
if (!Enqueued)
6868
switch (EnqueueResult.MResult) {
69-
case EnqueueResultT::SYCL_FAILED:
69+
case EnqueueResultT::SYCL_ENQUEUE_FAILED:
7070
default:
7171
// Exit immediately if a command fails to avoid enqueueing commands
7272
// result of which will be discarded.
7373
return false;
74-
case EnqueueResultT::SYCL_BLOCKED:
74+
case EnqueueResultT::SYCL_ENQUEUE_BLOCKED:
7575
// If some dependency is blocked from enqueueing remember that, but
7676
// try to enqueue other dependencies(that can be ready for
7777
// enqueueing).

sycl/source/detail/scheduler/scheduler.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,22 +30,22 @@ void Scheduler::waitForRecordToFinish(MemObjRecord *Record) {
3030
for (Command *Cmd : Record->MReadLeaves) {
3131
EnqueueResultT Res;
3232
bool Enqueued = GraphProcessor::enqueueCommand(Cmd, Res);
33-
if (!Enqueued && EnqueueResultT::SYCL_FAILED == Res.MResult)
33+
if (!Enqueued && EnqueueResultT::SYCL_ENQUEUE_FAILED == Res.MResult)
3434
throw runtime_error("Enqueue process failed.");
3535
GraphProcessor::waitForEvent(Cmd->getEvent());
3636
}
3737
for (Command *Cmd : Record->MWriteLeaves) {
3838
EnqueueResultT Res;
3939
bool Enqueued = GraphProcessor::enqueueCommand(Cmd, Res);
40-
if (!Enqueued && EnqueueResultT::SYCL_FAILED == Res.MResult)
40+
if (!Enqueued && EnqueueResultT::SYCL_ENQUEUE_FAILED == Res.MResult)
4141
throw runtime_error("Enqueue process failed.");
4242
GraphProcessor::waitForEvent(Cmd->getEvent());
4343
}
4444
for (AllocaCommandBase *AllocaCmd : Record->MAllocaCommands) {
4545
Command *ReleaseCmd = AllocaCmd->getReleaseCmd();
4646
EnqueueResultT Res;
4747
bool Enqueued = GraphProcessor::enqueueCommand(ReleaseCmd, Res);
48-
if (!Enqueued && EnqueueResultT::SYCL_FAILED == Res.MResult)
48+
if (!Enqueued && EnqueueResultT::SYCL_ENQUEUE_FAILED == Res.MResult)
4949
throw runtime_error("Enqueue process failed.");
5050
GraphProcessor::waitForEvent(ReleaseCmd->getEvent());
5151
}
@@ -70,7 +70,7 @@ EventImplPtr Scheduler::addCG(std::unique_ptr<detail::CG> CommandGroup,
7070
// TODO: Check if lazy mode.
7171
EnqueueResultT Res;
7272
bool Enqueued = GraphProcessor::enqueueCommand(NewCmd, Res);
73-
if (!Enqueued && EnqueueResultT::SYCL_FAILED == Res.MResult)
73+
if (!Enqueued && EnqueueResultT::SYCL_ENQUEUE_FAILED == Res.MResult)
7474
throw runtime_error("Enqueue process failed.");
7575
}
7676

@@ -91,7 +91,7 @@ EventImplPtr Scheduler::addCopyBack(Requirement *Req) {
9191
try {
9292
EnqueueResultT Res;
9393
bool Enqueued = GraphProcessor::enqueueCommand(NewCmd, Res);
94-
if (!Enqueued && EnqueueResultT::SYCL_FAILED == Res.MResult)
94+
if (!Enqueued && EnqueueResultT::SYCL_ENQUEUE_FAILED == Res.MResult)
9595
throw runtime_error("Enqueue process failed.");
9696
} catch (...) {
9797
NewCmd->getQueue()->reportAsyncException(std::current_exception());
@@ -151,7 +151,7 @@ EventImplPtr Scheduler::addHostAccessor(Requirement *Req,
151151
return nullptr;
152152
EnqueueResultT Res;
153153
bool Enqueued = GraphProcessor::enqueueCommand(NewCmd, Res);
154-
if (!Enqueued && EnqueueResultT::SYCL_FAILED == Res.MResult)
154+
if (!Enqueued && EnqueueResultT::SYCL_ENQUEUE_FAILED == Res.MResult)
155155
throw runtime_error("Enqueue process failed.");
156156
return NewCmd->getEvent();
157157
}
@@ -163,7 +163,7 @@ void Scheduler::releaseHostAccessor(Requirement *Req) {
163163
for (Command *Cmd : Leaves) {
164164
EnqueueResultT Res;
165165
bool Enqueued = GraphProcessor::enqueueCommand(Cmd, Res);
166-
if (!Enqueued && EnqueueResultT::SYCL_FAILED == Res.MResult)
166+
if (!Enqueued && EnqueueResultT::SYCL_ENQUEUE_FAILED == Res.MResult)
167167
throw runtime_error("Enqueue process failed.");
168168
}
169169
};

sycl/test/regression/macro_conflict.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
//===----------------------------------------------------------------------===//
88

99
#define SUCCESS 0
10-
#define FAIL 1
11-
#define BLOCKED 2
1210

1311
#include <CL/sycl.hpp>
1412

0 commit comments

Comments
 (0)