Skip to content

Commit 52e540e

Browse files
committed
addressed review comments
1 parent 6092e61 commit 52e540e

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

sycl/doc/extensions/experimental/sycl_ext_oneapi_cuda_async_barrier.asciidoc

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,18 @@ value to determine which of the extension's APIs the implementation supports.
7373

7474
[%header,cols="1,5"]
7575
|===
76-
|Value |Description
77-
|1 |Initial extension version. Base features are supported.
76+
|Value
77+
|Description
78+
79+
|1
80+
|The APIs of this experimental extension are not versioned, so the
81+
feature-test macro always has this value.
7882
|===
7983

8084
=== Overview
8185

8286
This extension introduces asynchronous barrier for CUDA devices. This extends
83-
`group_barrier` by splitting it into into two calls - arrive and wait. The
87+
`group_barrier` by splitting it into two calls - arrive and wait. The
8488
wait call blocks until the predetermined number of work items in the same work
8589
group call arrive. This is also very similar to
8690
https://en.cppreference.com/w/cpp/thread/barrier[`std::barrier`] introduced

sycl/include/CL/sycl.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
#if SYCL_EXT_ONEAPI_BACKEND_LEVEL_ZERO
6161
#include <sycl/ext/oneapi/backend/level_zero.hpp>
6262
#endif
63-
#include <sycl/ext/oneapi/barrier.hpp>
63+
#include <sycl/ext/oneapi/experimental/cuda/barrier.hpp>
6464
#include <sycl/ext/oneapi/bf16_storage_builtins.hpp>
6565
#include <sycl/ext/oneapi/device_global/properties.hpp>
6666
#include <sycl/ext/oneapi/experimental/builtins.hpp>

sycl/include/CL/sycl/detail/pi.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ typedef enum {
316316
PI_EXT_ONEAPI_DEVICE_INFO_MAX_WORK_GROUPS_1D = 0x20001,
317317
PI_EXT_ONEAPI_DEVICE_INFO_MAX_WORK_GROUPS_2D = 0x20002,
318318
PI_EXT_ONEAPI_DEVICE_INFO_MAX_WORK_GROUPS_3D = 0x20003,
319-
PI_EXT_ONEAPI_DEVICE_INFO_CUDA_ASYNC_BARRIER = 0x30000,
319+
PI_EXT_ONEAPI_DEVICE_INFO_CUDA_ASYNC_BARRIER = 0x20004,
320320
} _pi_device_info;
321321

322322
typedef enum {

0 commit comments

Comments
 (0)