Skip to content

Commit 53020cb

Browse files
authored
[libclc] Reinstate target-level deps for prepare-builtins & libclc-remangler (#5398)
PR #5019 added file-level dependency tracking to libclc's CMake, but inadvertently broke Unix Makefile compatibility by removing target-level dependencies. This PR reinstates the target-level deps, *in addition* to the file-level deps. With thanks to @henrichhegedus for bug report.
1 parent 3742b93 commit 53020cb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

libclc/cmake/modules/AddLibclc.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ macro(add_libclc_builtin_set arch_suffix)
9191
COMMAND prepare_builtins -o
9292
"${builtins_obj_path}"
9393
"$<TARGET_PROPERTY:opt.${obj_suffix},TARGET_FILE>"
94-
DEPENDS "${builtins_opt_path}"
94+
DEPENDS "${builtins_opt_path}" "opt.${obj_suffix}"
9595
prepare_builtins )
9696
add_custom_target( "prepare-${obj_suffix}" ALL
9797
DEPENDS "${builtins_obj_path}" )
@@ -122,7 +122,7 @@ macro(add_libclc_builtin_set arch_suffix)
122122
--long-width=${long_width}
123123
--char-signedness=${signedness}
124124
"$<TARGET_PROPERTY:prepare-${obj_suffix},TARGET_FILE>"
125-
DEPENDS "${builtins_obj_path}" libclc-remangler )
125+
DEPENDS "${builtins_obj_path}" "prepare-${obj_suffix}" libclc-remangler )
126126
add_custom_target( "remangled-${long_width}-${signedness}_char.${obj_suffix}" ALL
127127
DEPENDS "${builtins_remangle_path}" )
128128
set_target_properties("remangled-${long_width}-${signedness}_char.${obj_suffix}"

0 commit comments

Comments
 (0)