Skip to content

Commit 575e93e

Browse files
[SYCL][Graph] Fix OpenCL backend test fails with CPU device (#12227)
Adds missing variable initializations. Temporary disable `work_group_size_prop.cpp` because the failure results from a bug in the emulation layer.
1 parent b59a8c3 commit 575e93e

File tree

5 files changed

+15
-4
lines changed

5 files changed

+15
-4
lines changed

sycl/test-e2e/Graph/Explicit/work_group_size_prop.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,12 @@
55
//
66
// CHECK-NOT: LEAK
77

8-
// Temporarily disabled for CUDA.
9-
// XFAIL: cuda
8+
// Temporarily disabled for CUDA and OpenCL
9+
// The OpenCL emulation layer does not return `CL_INVALID_WORK_GROUP_SIZE` as it
10+
// should. So the Sycl graph support cannot correctly catch the error and throw
11+
// the approriate exception for negative test. An issue has been reported
12+
// https://github.com/bashbaug/SimpleOpenCLSamples/issues/95
13+
// XFAIL: cuda, opencl
1014
// Note: failing negative test with HIP in the original test
1115
// TODO: disable hip when HIP backend will be supported by Graph
1216

sycl/test-e2e/Graph/RecordReplay/dotp_in_order.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ int main() {
2222
exp_ext::command_graph Graph{Queue.get_context(), Queue.get_device()};
2323

2424
int *Dotp = malloc_device<int>(1, Queue);
25+
Queue.memset(Dotp, 0, sizeof(int)).wait();
2526

2627
const size_t N = 10;
2728
int *X = malloc_device<int>(N, Queue);

sycl/test-e2e/Graph/RecordReplay/dotp_in_order_with_empty_nodes.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ int main() {
2424
exp_ext::command_graph Graph{Queue.get_context(), Queue.get_device()};
2525

2626
int *Dotp = malloc_device<int>(1, Queue);
27+
Queue.memset(Dotp, 0, sizeof(int)).wait();
2728

2829
const size_t N = 10;
2930
int *X = malloc_device<int>(N, Queue);

sycl/test-e2e/Graph/RecordReplay/dotp_multiple_queues.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ int main() {
2424
exp_ext::command_graph Graph{QueueA.get_context(), QueueA.get_device()};
2525

2626
int *Dotp = malloc_device<int>(1, QueueA);
27+
QueueA.memset(Dotp, 0, sizeof(int)).wait();
2728

2829
const size_t N = 10;
2930
int *X = malloc_device<int>(N, QueueA);

sycl/test-e2e/Graph/RecordReplay/work_group_size_prop.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,12 @@
55
//
66
// CHECK-NOT: LEAK
77

8-
// Temporarily disabled for CUDA.
9-
// XFAIL: cuda
8+
// Temporarily disabled for CUDA and OpenCL
9+
// The OpenCL emulation layer does not return `CL_INVALID_WORK_GROUP_SIZE` as it
10+
// should. So the Sycl graph support cannot correctly catch the error and throw
11+
// the approriate exception for negative test. An issue has been reported
12+
// https://github.com/bashbaug/SimpleOpenCLSamples/issues/95
13+
// XFAIL: cuda, opencl
1014
// Note: failing negative test with HIP in the original test
1115
// TODO: disable hip when HIP backend will be supported by Graph
1216

0 commit comments

Comments
 (0)