[SYCL] Fix warnings in configuration and compilation (#5034)

Make SYCL headers warning free

Author: denis-kabanov

opencl/CMakeLists.txt

@@ -2,6 +2,15 @@ cmake_minimum_required(VERSION 3.14)
 
 include(FetchContent)
 
+# Suppress warnings related to dependencies
+if (MSVC)
+add_definitions(
+      -wd4133 # Suppress ''function': incompatible types - from 'char [9]' to 'LPCWSTR''
+      -wd4152 # Suppress 'nonstandard extension, function/data pointer conversion in expression'
+      -wd4201 # Suppress 'nonstandard extension used: nameless struct/union'
+)
+endif()
+
 # Repo URLs
 
 set(OCL_HEADERS_REPO

sycl/CMakeLists.txt

@@ -48,6 +48,7 @@ if(MSVC)
   set_property(GLOBAL PROPERTY USE_FOLDERS ON)
   # Skip asynchronous C++ exceptions catching and assume "extern C" functions
   # never throw C++ exceptions.
+  set(LLVM_REQUIRES_EH ON)
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHsc")
 
   # Add PDB debug information

sycl/cmake/modules/AddSYCLUnitTest.cmake

@@ -4,7 +4,8 @@
 # Produces a binary names `basename(test_dirname)`.
 macro(add_sycl_unittest test_dirname link_variant)
   # Enable exception handling for these unit tests
-  set(LLVM_REQUIRES_EH 1)
+  set(LLVM_REQUIRES_EH ON)
+  set(LLVM_REQUIRES_RTTI ON)
 
   string(TOLOWER "${CMAKE_BUILD_TYPE}" build_type_lower)
   if (MSVC AND build_type_lower MATCHES "debug")

sycl/unittests/Extensions/CMakeLists.txt

@@ -1,7 +1,5 @@
 set(CMAKE_CXX_EXTENSIONS OFF)
 
-# Enable exception handling for these unit tests
-set(LLVM_REQUIRES_EH 1)
 add_sycl_unittest(ExtensionsTests OBJECT
   DefaultContext.cpp
 )

sycl/unittests/SYCL2020/CMakeLists.txt

@@ -1,7 +1,5 @@
 set(CMAKE_CXX_EXTENSIONS OFF)
 
-# Enable exception handling for these unit tests
-set(LLVM_REQUIRES_EH 1)
 add_sycl_unittest(SYCL2020Tests OBJECT
   GetNativeOpenCL.cpp
   SpecializationConstant.cpp

sycl/unittests/allowlist/CMakeLists.txt

@@ -1,7 +1,5 @@
 set(CMAKE_CXX_EXTENSIONS OFF)
 
-# Enable exception handling for these unit tests
-set(LLVM_REQUIRES_EH 1)
 add_sycl_unittest(AllowListTests OBJECT 
     ParseAllowList.cpp
     DeviceIsAllowed.cpp

sycl/unittests/config/CMakeLists.txt

@@ -1,7 +1,5 @@
 set(CMAKE_CXX_EXTENSIONS OFF)
 
-# Enable exception handling for these unit tests
-set(LLVM_REQUIRES_EH 1)
 add_sycl_unittest(ConfigTests OBJECT 
     ConfigTests.cpp
 )

sycl/unittests/pi/CMakeLists.txt

@@ -1,7 +1,5 @@
 set(CMAKE_CXX_EXTENSIONS OFF)
 
-# Enable exception handling for these unit tests
-set(LLVM_REQUIRES_EH 1)
 add_sycl_unittest(PiTests OBJECT
   EnqueueMemTest.cpp
   PiMock.cpp

sycl/unittests/pi/cuda/CMakeLists.txt

@@ -1,4 +1,3 @@
-set(LLVM_REQUIRES_EH 1)
 add_sycl_unittest(PiCudaTests OBJECT
   test_base_objects.cpp
   test_commands.cpp

sycl/unittests/program_manager/CMakeLists.txt

@@ -1,7 +1,5 @@
 set(CMAKE_CXX_EXTENSIONS OFF)
 
-# Enable exception handling for these unit tests
-set(LLVM_REQUIRES_EH 1)
 add_sycl_unittest(ProgramManagerTests OBJECT
   EliminatedArgMask.cpp
   itt_annotations.cpp