Skip to content

Commit 5b40ef9

Browse files
Alexander Batashevbader
authored andcommitted
[SYCL][NFC] Use SYCL aliases for STL types in cg.hpp (#1046)
Since handler.hpp uses a lot of templates by design, it is very hard to eliminate usage of cg.hpp there. This patch makes header file public-friendly by using SYCL '_class' containers instead of std ones. Signed-off-by: Alexander Batashev <[email protected]>
1 parent a7bd063 commit 5b40ef9

File tree

1 file changed

+62
-62
lines changed
  • sycl/include/CL/sycl/detail

1 file changed

+62
-62
lines changed

sycl/include/CL/sycl/detail/cg.hpp

Lines changed: 62 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -320,11 +320,11 @@ class CG {
320320
PREFETCH_USM
321321
};
322322

323-
CG(CGTYPE Type, std::vector<std::vector<char>> ArgsStorage,
324-
std::vector<detail::AccessorImplPtr> AccStorage,
325-
std::vector<std::shared_ptr<const void>> SharedPtrStorage,
326-
std::vector<Requirement *> Requirements,
327-
std::vector<detail::EventImplPtr> Events)
323+
CG(CGTYPE Type, vector_class<vector_class<char>> ArgsStorage,
324+
vector_class<detail::AccessorImplPtr> AccStorage,
325+
vector_class<shared_ptr_class<const void>> SharedPtrStorage,
326+
vector_class<Requirement *> Requirements,
327+
vector_class<detail::EventImplPtr> Events)
328328
: MType(Type), MArgsStorage(std::move(ArgsStorage)),
329329
MAccStorage(std::move(AccStorage)),
330330
MSharedPtrStorage(std::move(SharedPtrStorage)),
@@ -341,41 +341,41 @@ class CG {
341341
// The following storages needed to ensure that arguments won't die while
342342
// we are using them.
343343
// Storage for standard layout arguments.
344-
std::vector<std::vector<char>> MArgsStorage;
344+
vector_class<vector_class<char>> MArgsStorage;
345345
// Storage for accessors.
346-
std::vector<detail::AccessorImplPtr> MAccStorage;
346+
vector_class<detail::AccessorImplPtr> MAccStorage;
347347
// Storage for shared_ptrs.
348-
std::vector<std::shared_ptr<const void>> MSharedPtrStorage;
348+
vector_class<shared_ptr_class<const void>> MSharedPtrStorage;
349349

350350
public:
351351
// List of requirements that specify which memory is needed for the command
352352
// group to be executed.
353-
std::vector<Requirement *> MRequirements;
353+
vector_class<Requirement *> MRequirements;
354354
// List of events that order the execution of this CG
355-
std::vector<detail::EventImplPtr> MEvents;
355+
vector_class<detail::EventImplPtr> MEvents;
356356
};
357357

358358
// The class which represents "execute kernel" command group.
359359
class CGExecKernel : public CG {
360360
public:
361361
NDRDescT MNDRDesc;
362-
std::unique_ptr<HostKernelBase> MHostKernel;
363-
std::shared_ptr<detail::kernel_impl> MSyclKernel;
364-
std::vector<ArgDesc> MArgs;
365-
std::string MKernelName;
362+
unique_ptr_class<HostKernelBase> MHostKernel;
363+
shared_ptr_class<detail::kernel_impl> MSyclKernel;
364+
vector_class<ArgDesc> MArgs;
365+
string_class MKernelName;
366366
detail::OSModuleHandle MOSModuleHandle;
367-
std::vector<std::shared_ptr<detail::stream_impl>> MStreams;
368-
369-
CGExecKernel(NDRDescT NDRDesc, std::unique_ptr<HostKernelBase> HKernel,
370-
std::shared_ptr<detail::kernel_impl> SyclKernel,
371-
std::vector<std::vector<char>> ArgsStorage,
372-
std::vector<detail::AccessorImplPtr> AccStorage,
373-
std::vector<std::shared_ptr<const void>> SharedPtrStorage,
374-
std::vector<Requirement *> Requirements,
375-
std::vector<detail::EventImplPtr> Events,
376-
std::vector<ArgDesc> Args, std::string KernelName,
367+
vector_class<shared_ptr_class<detail::stream_impl>> MStreams;
368+
369+
CGExecKernel(NDRDescT NDRDesc, unique_ptr_class<HostKernelBase> HKernel,
370+
shared_ptr_class<detail::kernel_impl> SyclKernel,
371+
vector_class<vector_class<char>> ArgsStorage,
372+
vector_class<detail::AccessorImplPtr> AccStorage,
373+
vector_class<shared_ptr_class<const void>> SharedPtrStorage,
374+
vector_class<Requirement *> Requirements,
375+
vector_class<detail::EventImplPtr> Events,
376+
vector_class<ArgDesc> Args, string_class KernelName,
377377
detail::OSModuleHandle OSModuleHandle,
378-
std::vector<std::shared_ptr<detail::stream_impl>> Streams,
378+
vector_class<shared_ptr_class<detail::stream_impl>> Streams,
379379
CGTYPE Type)
380380
: CG(Type, std::move(ArgsStorage), std::move(AccStorage),
381381
std::move(SharedPtrStorage), std::move(Requirements),
@@ -388,9 +388,9 @@ class CGExecKernel : public CG {
388388
"Wrong type of exec kernel CG.");
389389
}
390390

391-
std::vector<ArgDesc> getArguments() const { return MArgs; }
392-
std::string getKernelName() const { return MKernelName; }
393-
std::vector<std::shared_ptr<detail::stream_impl>> getStreams() const {
391+
vector_class<ArgDesc> getArguments() const { return MArgs; }
392+
string_class getKernelName() const { return MKernelName; }
393+
vector_class<shared_ptr_class<detail::stream_impl>> getStreams() const {
394394
return MStreams;
395395
}
396396
};
@@ -402,11 +402,11 @@ class CGCopy : public CG {
402402

403403
public:
404404
CGCopy(CGTYPE CopyType, void *Src, void *Dst,
405-
std::vector<std::vector<char>> ArgsStorage,
406-
std::vector<detail::AccessorImplPtr> AccStorage,
407-
std::vector<std::shared_ptr<const void>> SharedPtrStorage,
408-
std::vector<Requirement *> Requirements,
409-
std::vector<detail::EventImplPtr> Events)
405+
vector_class<vector_class<char>> ArgsStorage,
406+
vector_class<detail::AccessorImplPtr> AccStorage,
407+
vector_class<shared_ptr_class<const void>> SharedPtrStorage,
408+
vector_class<Requirement *> Requirements,
409+
vector_class<detail::EventImplPtr> Events)
410410
: CG(CopyType, std::move(ArgsStorage), std::move(AccStorage),
411411
std::move(SharedPtrStorage), std::move(Requirements),
412412
std::move(Events)),
@@ -418,15 +418,15 @@ class CGCopy : public CG {
418418
// The class which represents "fill" command group.
419419
class CGFill : public CG {
420420
public:
421-
std::vector<char> MPattern;
421+
vector_class<char> MPattern;
422422
Requirement *MPtr;
423423

424-
CGFill(std::vector<char> Pattern, void *Ptr,
425-
std::vector<std::vector<char>> ArgsStorage,
426-
std::vector<detail::AccessorImplPtr> AccStorage,
427-
std::vector<std::shared_ptr<const void>> SharedPtrStorage,
428-
std::vector<Requirement *> Requirements,
429-
std::vector<detail::EventImplPtr> Events)
424+
CGFill(vector_class<char> Pattern, void *Ptr,
425+
vector_class<vector_class<char>> ArgsStorage,
426+
vector_class<detail::AccessorImplPtr> AccStorage,
427+
vector_class<shared_ptr_class<const void>> SharedPtrStorage,
428+
vector_class<Requirement *> Requirements,
429+
vector_class<detail::EventImplPtr> Events)
430430
: CG(FILL, std::move(ArgsStorage), std::move(AccStorage),
431431
std::move(SharedPtrStorage), std::move(Requirements),
432432
std::move(Events)),
@@ -439,11 +439,11 @@ class CGUpdateHost : public CG {
439439
Requirement *MPtr;
440440

441441
public:
442-
CGUpdateHost(void *Ptr, std::vector<std::vector<char>> ArgsStorage,
443-
std::vector<detail::AccessorImplPtr> AccStorage,
444-
std::vector<std::shared_ptr<const void>> SharedPtrStorage,
445-
std::vector<Requirement *> Requirements,
446-
std::vector<detail::EventImplPtr> Events)
442+
CGUpdateHost(void *Ptr, vector_class<vector_class<char>> ArgsStorage,
443+
vector_class<detail::AccessorImplPtr> AccStorage,
444+
vector_class<shared_ptr_class<const void>> SharedPtrStorage,
445+
vector_class<Requirement *> Requirements,
446+
vector_class<detail::EventImplPtr> Events)
447447
: CG(UPDATE_HOST, std::move(ArgsStorage), std::move(AccStorage),
448448
std::move(SharedPtrStorage), std::move(Requirements),
449449
std::move(Events)),
@@ -460,11 +460,11 @@ class CGCopyUSM : public CG {
460460

461461
public:
462462
CGCopyUSM(void *Src, void *Dst, size_t Length,
463-
std::vector<std::vector<char>> ArgsStorage,
464-
std::vector<detail::AccessorImplPtr> AccStorage,
465-
std::vector<std::shared_ptr<const void>> SharedPtrStorage,
466-
std::vector<Requirement *> Requirements,
467-
std::vector<detail::EventImplPtr> Events)
463+
vector_class<vector_class<char>> ArgsStorage,
464+
vector_class<detail::AccessorImplPtr> AccStorage,
465+
vector_class<shared_ptr_class<const void>> SharedPtrStorage,
466+
vector_class<Requirement *> Requirements,
467+
vector_class<detail::EventImplPtr> Events)
468468
: CG(COPY_USM, std::move(ArgsStorage), std::move(AccStorage),
469469
std::move(SharedPtrStorage), std::move(Requirements),
470470
std::move(Events)),
@@ -477,17 +477,17 @@ class CGCopyUSM : public CG {
477477

478478
// The class which represents "fill" command group for USM pointers.
479479
class CGFillUSM : public CG {
480-
std::vector<char> MPattern;
480+
vector_class<char> MPattern;
481481
void *MDst;
482482
size_t MLength;
483483

484484
public:
485-
CGFillUSM(std::vector<char> Pattern, void *DstPtr, size_t Length,
486-
std::vector<std::vector<char>> ArgsStorage,
487-
std::vector<detail::AccessorImplPtr> AccStorage,
488-
std::vector<std::shared_ptr<const void>> SharedPtrStorage,
489-
std::vector<Requirement *> Requirements,
490-
std::vector<detail::EventImplPtr> Events)
485+
CGFillUSM(vector_class<char> Pattern, void *DstPtr, size_t Length,
486+
vector_class<vector_class<char>> ArgsStorage,
487+
vector_class<detail::AccessorImplPtr> AccStorage,
488+
vector_class<shared_ptr_class<const void>> SharedPtrStorage,
489+
vector_class<Requirement *> Requirements,
490+
vector_class<detail::EventImplPtr> Events)
491491
: CG(FILL_USM, std::move(ArgsStorage), std::move(AccStorage),
492492
std::move(SharedPtrStorage), std::move(Requirements),
493493
std::move(Events)),
@@ -504,11 +504,11 @@ class CGPrefetchUSM : public CG {
504504

505505
public:
506506
CGPrefetchUSM(void *DstPtr, size_t Length,
507-
std::vector<std::vector<char>> ArgsStorage,
508-
std::vector<detail::AccessorImplPtr> AccStorage,
509-
std::vector<std::shared_ptr<const void>> SharedPtrStorage,
510-
std::vector<Requirement *> Requirements,
511-
std::vector<detail::EventImplPtr> Events)
507+
vector_class<vector_class<char>> ArgsStorage,
508+
vector_class<detail::AccessorImplPtr> AccStorage,
509+
vector_class<shared_ptr_class<const void>> SharedPtrStorage,
510+
vector_class<Requirement *> Requirements,
511+
vector_class<detail::EventImplPtr> Events)
512512
: CG(PREFETCH_USM, std::move(ArgsStorage), std::move(AccStorage),
513513
std::move(SharedPtrStorage), std::move(Requirements),
514514
std::move(Events)),

0 commit comments

Comments
 (0)