Skip to content

Commit 5d5a570

Browse files
authored
[SYCL][E2E] Update some XFAIL tests (#15908)
Update the tests that already contain a link. Also update lit config and tests to not include `.c` files, we don't have such tests in SYCL.
1 parent 036fff0 commit 5d5a570

File tree

16 files changed

+17
-31
lines changed

16 files changed

+17
-31
lines changed

sycl/test-e2e/Basic/accessor/accessor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
// RUN: %{build} -DSYCL2020_DISABLE_DEPRECATION_WARNINGS -o %t.out
22
// RUN: %{run} %t.out
33

4-
// https://github.com/intel/llvm/issues/14826
54
// XFAIL: arch-intel_gpu_pvc
5+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14826
66

77
//==----------------accessor.cpp - SYCL accessor basic test ----------------==//
88
//

sycl/test-e2e/Basic/fpga_tests/fpga_pipes_mixed_usage.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
// RUN: %{build} -o %t.out
1010
// RUN: %{run} %t.out
1111

12-
// https://github.com/intel/llvm/issues/13887
1312
// XFAIL: *
13+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/13887
1414
// If users need to use host pipe feature provided by experimental::pipe, all
1515
// pipes in their design should use the experimental::pipe (as a workround).
1616

sycl/test-e2e/Basic/image/srgba-read.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// REQUIRES: aspect-ext_oneapi_srgb, aspect-ext_intel_legacy_image
2-
// https://github.com/intel/llvm/issues/14387
32
// XFAIL: gpu-intel-dg2
3+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14387
44
// RUN: %{build} -o %t.out
55
// RUN: %{run} %t.out | FileCheck %s
66

sycl/test-e2e/DeprecatedFeatures/set_arg_interop.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// REQUIRES: opencl, opencl_icd
22

3-
// https://github.com/intel/llvm/issues/14826
43
// XFAIL: arch-intel_gpu_pvc
4+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14826
55

66
// RUN: %{build} -D__SYCL_INTERNAL_API -o %t.out %opencl_lib -O3
77
// RUN: %{run} %t.out

sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// REQUIRES: arch-intel_gpu_pvc, ocloc
22

3-
// https://github.com/intel/llvm/issues/14826
43
// XFAIL: arch-intel_gpu_pvc
4+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14826
55

66
// RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_pvc %s -o %t.out
77
// RUN: %{run} %t.out

sycl/test-e2e/ESIMD/assert.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
//
77
// The test still fails after GPU driver update on Linux. Temporary marking it
88
// as expected to fail, whilst it is being investigated, see intel/llvm#11359
9-
// FIXME: remove that XFAIL
109
// XFAIL: linux
10+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11359
1111
//
1212
// Hanging on gen12, remove when internal tracker fixed
1313
// UNSUPPORTED: gpu-intel-gen12

sycl/test-e2e/LLVMIntrinsicLowering/sub_byte_bitreverse.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33

44
// UNSUPPORTED: hip || cuda
55

6-
// TODO: Remove XFAIL after fixing
7-
// https://github.com/intel/intel-graphics-compiler/issues/330
86
// XFAIL: gpu
7+
// XFAIL-TRACKER: https://github.com/intel/intel-graphics-compiler/issues/330
98

109
// Make dump directory.
1110
// RUN: rm -rf %t.spvdir && mkdir %t.spvdir

sycl/test-e2e/Plugin/interop-cuda-experimental.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
// RUN: %{build} %cuda_options -o %t.out
44
// RUN: %{run} %t.out
55

6-
// An issue has been reported in https://github.com/intel/llvm/issues/14116
76
// XFAIL: *
7+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14116
88

99
#define SYCL_EXT_ONEAPI_BACKEND_CUDA_EXPERIMENTAL 1
1010
#include <sycl/backend.hpp>

sycl/test-e2e/Plugin/interop-experimental-single-TU-SYCL-CUDA-compilation.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
// RUN: %{build} %cuda_options -lcudart -lcuda -x cuda -o %t.out
33
// RUN: %{run} %t.out
44

5-
// An issue has been reported in https://github.com/intel/llvm/issues/14115
65
// XFAIL: *
6+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14116
77

88
#include <cuda.h>
99
#include <sycl/detail/core.hpp>

sycl/test-e2e/VirtualFunctions/multiple-translation-units/separate-call.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
// VTables are global variables with possibly external linkage and that causes
44
// them to be copied into every module we produce during device code split
55
// which in turn leads to multiple definitions error at runtime.
6-
// https://github.com/intel/llvm/issues/15069
76
// XFAIL: *
7+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15069
88
//
99
// This test covers a scenario where virtual functions defintion and their uses
1010
// are split into different translation units. In particular:

sycl/test-e2e/VirtualFunctions/multiple-translation-units/separate-vf-defs-and-call.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
// function definitions and therefore we won't mark construct kernel as using
66
// virtual functions and link operation at runtime will fail due to undefined
77
// references to virtual functions from vtable.
8-
// https://github.com/intel/llvm/issues/15071
98
// XFAIL: *
9+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15071
1010
//
1111
// This test covers a scenario where virtual functions defintion and their uses
1212
// are all split into different translation units.

sycl/test-e2e/VirtualFunctions/multiple-translation-units/separate-vf-defs.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
// function definitions and therefore we won't mark construct kernel as using
66
// virtual functions and link operation at runtime will fail due to undefined
77
// references to virtual functions from vtable.
8-
// https://github.com/intel/llvm/issues/15071
98
// XFAIL: *
9+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15071
1010
//
1111
// This test covers a scenario where virtual functions defintion and their uses
1212
// are split into different translation units. In particular:

sycl/test-e2e/lit.cfg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
config.name = "SYCL"
2121

2222
# suffixes: A list of file extensions to treat as test files.
23-
config.suffixes = [".c", ".cpp"]
23+
config.suffixes = [".cpp"]
2424

2525
config.excludes = ["Inputs"]
2626

sycl/test-e2e/syclcompat/launch/launch_policy_lmem.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
* launch<F> with policy & use local memory tests
2121
**************************************************************************/
2222

23-
// https://github.com/intel/llvm/issues/14826
2423
// XFAIL: arch-intel_gpu_pvc
24+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14826
2525

2626
// RUN: %{build} -fsycl-device-code-split=per_kernel -o %t.out
2727
// RUN: %{run} %t.out

sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
// - ...and check if the list of improperly UNSUPPORTED tests needs to be updated.
3131
//
3232
// RUN: grep -rI "UNSUPPORTED:" %S/../../test-e2e \
33-
// RUN: -A 1 --include=*.c --include=*.cpp --no-group-separator | \
33+
// RUN: -A 1 --include=*.cpp --no-group-separator | \
3434
// RUN: grep -v "UNSUPPORTED:" | \
3535
// RUN: grep -Pv "UNSUPPORTED-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)|(?:UNSUPPORTED-INTENDED:\s*.+)" > %t
3636
// RUN: cat %t | wc -l | FileCheck %s --check-prefix NUMBER-OF-UNSUPPORTED-WITHOUT-INFO

sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
// - ...and check if the list of improperly XFAIL-ed tests needs to be updated.
2828
//
2929
// RUN: grep -rI "XFAIL:" %S/../../test-e2e \
30-
// RUN: -A 1 --include=*.c --include=*.cpp --no-group-separator | \
30+
// RUN: -A 1 --include=*.cpp --no-group-separator | \
3131
// RUN: grep -v "XFAIL:" | \
3232
// RUN: grep -Pv "XFAIL-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)" > %t
3333
// RUN: cat %t | wc -l | FileCheck %s --check-prefix NUMBER-OF-XFAIL-WITHOUT-TRACKER
@@ -51,20 +51,17 @@
5151
// tests to match the required format and in that case you should just update
5252
// (i.e. reduce) the number and the list below.
5353
//
54-
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 156
54+
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 143
5555
//
5656
// List of improperly XFAIL-ed tests.
5757
// Remove the CHECK once the test has been propely XFAIL-ed.
5858
//
5959
// CHECK: AddressSanitizer/nullpointer/private_nullptr.cpp
60-
// CHECK-NEXT: Basic/accessor/accessor.cpp
6160
// CHECK-NEXT: Basic/aspects.cpp
6261
// CHECK-NEXT: Basic/buffer/reinterpret.cpp
6362
// CHECK-NEXT: Basic/built-ins.cpp
6463
// CHECK-NEXT: Basic/device_event.cpp
6564
// CHECK-NEXT: Basic/diagnostics/handler.cpp
66-
// CHECK-NEXT: Basic/fpga_tests/fpga_pipes_mixed_usage.cpp
67-
// CHECK-NEXT: Basic/image/srgba-read.cpp
6865
// CHECK-NEXT: Basic/max_linear_work_group_size_props.cpp
6966
// CHECK-NEXT: Basic/max_work_group_size_props.cpp
7067
// CHECK-NEXT: Basic/partition_supported.cpp
@@ -73,12 +70,9 @@
7370
// CHECK-NEXT: Basic/span.cpp
7471
// CHECK-NEXT: Basic/stream/auto_flush.cpp
7572
// CHECK-NEXT: DeprecatedFeatures/queue_old_interop.cpp
76-
// CHECK-NEXT: DeprecatedFeatures/set_arg_interop.cpp
77-
// CHECK-NEXT: DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp
7873
// CHECK-NEXT: DeviceCodeSplit/split-per-kernel.cpp
7974
// CHECK-NEXT: DeviceCodeSplit/split-per-source-main.cpp
8075
// CHECK-NEXT: DeviceLib/assert-windows.cpp
81-
// CHECK-NEXT: ESIMD/assert.cpp
8276
// CHECK-NEXT: ESIMD/hardware_dispatch.cpp
8377
// CHECK-NEXT: GroupAlgorithm/root_group.cpp
8478
// CHECK-NEXT: GroupLocalMemory/group_local_memory.cpp
@@ -93,7 +87,6 @@
9387
// CHECK-NEXT: InvokeSimd/Spec/tuple_return.cpp
9488
// CHECK-NEXT: InvokeSimd/Spec/tuple_vadd.cpp
9589
// CHECK-NEXT: KernelAndProgram/kernel-bundle-merge-options.cpp
96-
// CHECK-NEXT: LLVMIntrinsicLowering/sub_byte_bitreverse.cpp
9790
// CHECK-NEXT: Matrix/SG32/joint_matrix_annotated_ptr.cpp
9891
// CHECK-NEXT: Matrix/SG32/joint_matrix_bfloat16_colmajorA_colmajorB.cpp
9992
// CHECK-NEXT: Matrix/SG32/joint_matrix_bfloat16_packedB.cpp
@@ -177,8 +170,6 @@
177170
// CHECK-NEXT: NewOffloadDriver/sycl-external-with-optional-features.cpp
178171
// CHECK-NEXT: OptionalKernelFeatures/throw-exception-for-out-of-registers-on-kernel-launch.cpp
179172
// CHECK-NEXT: PerformanceTests/Reduction/reduce_over_sub_group.cpp
180-
// CHECK-NEXT: Plugin/interop-cuda-experimental.cpp
181-
// CHECK-NEXT: Plugin/interop-experimental-single-TU-SYCL-CUDA-compilation.cpp
182173
// CHECK-NEXT: Printf/int.cpp
183174
// CHECK-NEXT: Printf/mixed-address-space.cpp
184175
// CHECK-NEXT: Printf/percent-symbol.cpp
@@ -208,7 +199,3 @@
208199
// CHECK-NEXT: Scheduler/MultipleDevices.cpp
209200
// CHECK-NEXT: Scheduler/ReleaseResourcesTest.cpp
210201
// CHECK-NEXT: Tracing/buffer_printers.cpp
211-
// CHECK-NEXT: VirtualFunctions/multiple-translation-units/separate-call.cpp
212-
// CHECK-NEXT: VirtualFunctions/multiple-translation-units/separate-vf-defs-and-call.cpp
213-
// CHECK-NEXT: VirtualFunctions/multiple-translation-units/separate-vf-defs.cpp
214-
// CHECK-NEXT: syclcompat/launch/launch_policy_lmem.cpp

0 commit comments

Comments
 (0)