Skip to content

Commit 5f1d98a

Browse files
authored
[ESIMD][E2E] Enable few cases in atomic_update after gpu driver update (#12639)
Signed-off-by: Klochkov, Vyacheslav N <[email protected]>
1 parent 7bacc52 commit 5f1d98a

File tree

2 files changed

+7
-31
lines changed

2 files changed

+7
-31
lines changed

sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update.hpp

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -715,13 +715,10 @@ bool test_int_types_and_sizes(queue q, const Config &cfg) {
715715
q, cfg);
716716
passed &= test_int_types<64, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(
717717
q, cfg);
718-
// non power of two values are supported only in newer driver.
719-
// TODO: Enable this when the new driver reaches test infrastructure
720-
// (v27556).
721-
#if 0
722-
passed &= test_int_types<12, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(q, cfg);
723-
passed &= test_int_types<33, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(q, cfg);
724-
#endif
718+
passed &= test_int_types<12, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(
719+
q, cfg);
720+
passed &= test_int_types<33, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(
721+
q, cfg);
725722
}
726723

727724
return passed;
@@ -742,13 +739,8 @@ bool test_fp_types_and_sizes(queue q, const Config &cfg) {
742739
passed &= test_fp_types<32, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg);
743740
passed &= test_fp_types<64, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg);
744741

745-
// non power of two values are supported only in newer driver.
746-
// TODO: Enable this when the new driver reaches test infrastructure
747-
// (v27556).
748-
#if 0
749742
passed &= test_fp_types<12, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg);
750743
passed &= test_fp_types<35, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg);
751-
#endif
752744
}
753745
return passed;
754746
}

sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update_slm.hpp

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -612,14 +612,9 @@ bool test_fp_types(queue q) {
612612

613613
if constexpr (Features == TestFeatures::DG2 ||
614614
Features == TestFeatures::PVC) {
615-
// TODO: fmin/fmax/fcmpxchg for double requires a newer GPU driver.
616-
if constexpr (!std::is_same_v<Op<double, N>, ImplLSCFmax<double, N>> &&
617-
!std::is_same_v<Op<double, N>, ImplLSCFmin<double, N>> &&
618-
!std::is_same_v<Op<double, N>, ImplLSCFcmpwr<double, N>>) {
619-
if (q.get_device().has(sycl::aspect::atomic64) &&
620-
q.get_device().has(sycl::aspect::fp64)) {
621-
passed &= run_test<UseAcc, double, N, Op, UseMask>(q);
622-
}
615+
if (q.get_device().has(sycl::aspect::atomic64) &&
616+
q.get_device().has(sycl::aspect::fp64)) {
617+
passed &= run_test<UseAcc, double, N, Op, UseMask>(q);
623618
}
624619
}
625620
return passed;
@@ -633,7 +628,6 @@ bool test_int_types_and_sizes(queue q) {
633628
passed &= test_int_types<2, Op, UseMask, Features, UseAcc, SignMask>(q);
634629
passed &= test_int_types<4, Op, UseMask, Features, UseAcc, SignMask>(q);
635630
passed &= test_int_types<8, Op, UseMask, Features, UseAcc, SignMask>(q);
636-
// TODO: N=16 and N=32 does not pass on Gen12 with mask due to older driver.
637631
if (UseMask && Features == TestFeatures::Generic &&
638632
esimd_test::isGPUDriverGE(q, esimd_test::GPUDriverOS::LinuxAndWindows,
639633
"26918", "101.4953", false)) {
@@ -645,13 +639,8 @@ bool test_int_types_and_sizes(queue q) {
645639
if constexpr (Features == TestFeatures::DG2 ||
646640
Features == TestFeatures::PVC) {
647641
passed &= test_int_types<64, Op, UseMask, Features, UseAcc, SignMask>(q);
648-
// non power of two values are supported only in newer driver.
649-
// TODO: Enable this when the new driver reaches test infrastructure
650-
// (v27556).
651-
#if 0
652642
passed &= test_int_types<12, Op, UseMask, Features, UseAcc, SignMask>(q);
653643
passed &= test_int_types<33, Op, UseMask, Features, UseAcc, SignMask>(q);
654-
#endif
655644
}
656645

657646
return passed;
@@ -672,13 +661,8 @@ bool test_fp_types_and_sizes(queue q) {
672661
if constexpr (Features == TestFeatures::DG2 ||
673662
Features == TestFeatures::PVC) {
674663
passed &= test_fp_types<64, Op, UseMask, Features, UseAcc>(q);
675-
// non power of two values are supported only in newer driver.
676-
// TODO: Enable this when the new driver reaches test infrastructure
677-
// (v27556).
678-
#if 0
679664
passed &= test_fp_types<33, Op, UseMask, Features, UseAcc>(q);
680665
passed &= test_fp_types<65, Op, UseMask, Features, UseAcc>(q);
681-
#endif
682666
}
683667
return passed;
684668
}

0 commit comments

Comments
 (0)