Apply code review comments.

Author: bader

clang/include/clang/Sema/ParsedAttr.h

@@ -659,6 +659,8 @@ class ParsedAttr final
   /// representation in LangAS, otherwise returns default address space.
   LangAS asSYCLLangAS() const {
     switch (getKind()) {
+    // FIXME: there are uses of `opencl_constant` attribute in SYCL mode.
+    // See https://github.com/intel/llvm/issues/3062 for more details.
     case ParsedAttr::AT_OpenCLConstantAddressSpace:
       return LangAS::opencl_constant;
     case ParsedAttr::AT_OpenCLGlobalAddressSpace:

clang/test/CodeGenSYCL/address-space-conversions.cpp

@@ -1,4 +1,9 @@
 // RUN: %clang_cc1 -triple spir64 -fsycl-is-device -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s
+
+// Validates address space conversions for SYCL mode.
+// See clang/docs/SYCLSupport.rst#address-space-handling for allowed
+// conversions.
+
 void bar(int &Data) {}
 // CHECK-DAG: define{{.*}} spir_func void @[[RAW_REF:[a-zA-Z0-9_]+]](i32 addrspace(4)* align 4 dereferenceable(4) %
 void bar2(int &Data) {}

clang/test/CodeGenSYCL/address-space-deduction.cpp

@@ -1,5 +1,8 @@
 // RUN: %clang_cc1 -triple spir64 -fsycl-is-device -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s
 
+// Validates SYCL deduction rules compliance.
+// See clang/docs/SYCLSupport.rst#address-space-handling for the details.
+
 // CHECK:    @_ZZ4testvE3foo = internal addrspace(1) constant i32 66, align 4
 // CHECK: @[[STR:[.a-zA-Z0-9_]+]] = private unnamed_addr addrspace(1) constant [14 x i8] c"Hello, world!\00", align 1
 

clang/test/SemaSYCL/address-space-conversions.cpp

@@ -1,5 +1,9 @@
 // RUN: %clang_cc1 -fsycl-is-device -verify -fsyntax-only %s
 
+// Validates address space conversions for SYCL mode.
+// See clang/docs/SYCLSupport.rst#address-space-handling for allowed
+// conversions.
+
 void bar(int &Data) {}
 void bar2(int &Data) {}
 void bar(__attribute__((opencl_private)) int &Data) {}