Skip to content

Commit 6687c57

Browse files
committed
[NFC][Clang] Make GetSDLFromOffloadArchive return void
1 parent 7c94603 commit 6687c57

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

clang/lib/Driver/ToolChains/CommonArgs.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2129,7 +2129,7 @@ static bool SDLSearch(const Driver &D, const llvm::opt::ArgList &DriverArgs,
21292129
/// the library paths. If so, add a new command to clang-offload-bundler to
21302130
/// unbundle this archive and create a temporary device specific archive. Name
21312131
/// of this SDL is passed to the llvm-link tool.
2132-
static bool GetSDLFromOffloadArchive(
2132+
static void GetSDLFromOffloadArchive(
21332133
Compilation &C, const Driver &D, const Tool &T, const JobAction &JA,
21342134
const InputInfoList &Inputs, const llvm::opt::ArgList &DriverArgs,
21352135
llvm::opt::ArgStringList &CC1Args,
@@ -2138,7 +2138,7 @@ static bool GetSDLFromOffloadArchive(
21382138

21392139
// We don't support bitcode archive bundles for nvptx
21402140
if (isBitCodeSDL && Arch.contains("nvptx"))
2141-
return false;
2141+
return;
21422142

21432143
bool FoundAOB = false;
21442144
std::string ArchiveOfBundles;
@@ -2174,12 +2174,12 @@ static bool GetSDLFromOffloadArchive(
21742174
}
21752175

21762176
if (!FoundAOB)
2177-
return false;
2177+
return;
21782178

21792179
llvm::file_magic Magic;
21802180
auto EC = llvm::identify_magic(ArchiveOfBundles, Magic);
21812181
if (EC || Magic != llvm::file_magic::archive)
2182-
return false;
2182+
return;
21832183

21842184
StringRef Prefix = isBitCodeSDL ? "libbc-" : "lib";
21852185
std::string OutputLib =
@@ -2234,7 +2234,7 @@ static bool GetSDLFromOffloadArchive(
22342234

22352235
CC1Args.push_back(DriverArgs.MakeArgString(OutputLib));
22362236

2237-
return true;
2237+
return;
22382238
}
22392239

22402240
// Wrapper function used by driver for adding SDLs during link phase.

0 commit comments

Comments
 (0)