Skip to content

Commit 6a9de65

Browse files
authored
[SYCL] Add XFAIL trackers for E2E tests and remove hip_nvidia XFAILs entirely (#16307)
This is a cleanup of several tests marked as XFAIL on certain platforms. It is a follow up of #16287 and it follows the same principles in handling of XFAILs.
1 parent f2c7869 commit 6a9de65

File tree

11 files changed

+7
-33
lines changed

11 files changed

+7
-33
lines changed

sycl/test-e2e/Basic/aspects.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
// RUN: %{build} -o %t.out -DSYCL_DISABLE_IMAGE_ASPECT_WARNING
22
// RUN: %{run-unfiltered-devices} %t.out
3-
//
4-
// Hip is missing some of the parameters tested here so it fails with NVIDIA
5-
// XFAIL: hip_nvidia
63

74
//==--------------- aspects.cpp - SYCL device test ------------------------==//
85
//

sycl/test-e2e/Basic/device_event.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
// RUN: %{build} -o %t.run
22
// RUN: %{run} %t.run
3-
//
4-
// Returns error "Barrier is not supported on the host device
5-
// yet." with Nvidia.
6-
// XFAIL: hip_nvidia
73

84
//==--------device_event.cpp - SYCL class device_event test ----------------==//
95
//

sycl/test-e2e/Basic/diagnostics/handler.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
// RUN: %{build} -o %t.out
22
// RUN: %{run} %t.out | FileCheck %s
3-
//
4-
// Appears to fail on HIP Nvidia because 'no device of requested type available'
5-
// when constructing a queue with an exception_list.
6-
// XFAIL: hip_nvidia
3+
74
//==------------------- handler.cpp ----------------------------------------==//
85
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
96
// See https://llvm.org/LICENSE.txt for license information.

sycl/test-e2e/Basic/partition_supported.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
// RUN: %{build} -o %t.out
22
// RUN: %{run} %t.out
3-
//
4-
// Nvidia should not allow sub_devices but does not throw corresponding error.
5-
// XFAIL: hip_nvidia
63
/* Check that:
74
1) if partition_equally is supported, then we check that the correct
85
invalid errc is returned if more than max_compute_units are requested

sycl/test-e2e/KernelAndProgram/kernel-bundle-merge-options.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
// Debug option -g is not passed to device code compiler when CL-style driver
77
// is used and /DEBUG options is passed.
88
// XFAIL: cl_options
9+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16309
910

1011
#include "kernel-bundle-merge-options.hpp"
1112

sycl/test-e2e/Printf/int.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
// UNSUPPORTED: hip_amd
88
// FIXME: The 'short' type gets overflown with sporadic values on CUDA.
99
// XFAIL: cuda
10-
//
10+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14734
11+
1112
// RUN: %{build} -o %t.out
1213
// RUN: %{run} %t.out | FileCheck %s
1314
// FIXME: Remove dedicated constant address space testing once generic AS

sycl/test-e2e/Printf/mixed-address-space.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
//
44
// UNSUPPORTED: hip_amd
55
// XFAIL: cuda && windows
6-
//
6+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14733
77
// FIXME: Drop the test once generic AS support is considered stable and the
88
// dedicated constant AS overload of printf is removed from the library.
99
//

sycl/test-e2e/Printf/percent-symbol.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
// UNSUPPORTED: hip_amd
88
// XFAIL: cuda && windows
9-
//
9+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14733
1010
// RUN: %{build} -o %t.out
1111
// RUN: %{run} %t.out | FileCheck %s
1212
// FIXME: Remove dedicated constant address space testing once generic AS

sycl/test-e2e/Regression/context_is_destroyed_after_exception.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
// RUN: %{build} -o %t.out
44
// RUN: env SYCL_UR_TRACE=2 %{run} %t.out %if !windows %{2>&1 | FileCheck %s %}
5-
//
6-
// XFAIL: hip_nvidia
75

86
#include <sycl/detail/core.hpp>
97

sycl/test-e2e/Regression/multiple-targets.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515
//
1616
// RUN: %clangxx -fsycl -fsycl-targets=spir64,%{sycl_triple} -fsycl-device-code-split=per_kernel -o %t4.out %s
1717
// RUN: %{run} %t4.out
18-
//
19-
// XFAIL: hip_nvidia
20-
//
2118

2219
#include <sycl/detail/core.hpp>
2320

sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,22 +51,17 @@
5151
// tests to match the required format and in that case you should just update
5252
// (i.e. reduce) the number and the list below.
5353
//
54-
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 41
54+
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 31
5555
//
5656
// List of improperly XFAIL-ed tests.
5757
// Remove the CHECK once the test has been properly XFAIL-ed.
5858
//
5959
// CHECK: AddressSanitizer/nullpointer/private_nullptr.cpp
60-
// CHECK-NEXT: Basic/aspects.cpp
61-
// CHECK-NEXT: Basic/device_event.cpp
62-
// CHECK-NEXT: Basic/diagnostics/handler.cpp
6360
// CHECK-NEXT: Basic/max_linear_work_group_size_props.cpp
6461
// CHECK-NEXT: Basic/max_work_group_size_props.cpp
65-
// CHECK-NEXT: Basic/partition_supported.cpp
6662
// CHECK-NEXT: DeviceLib/assert-windows.cpp
6763
// CHECK-NEXT: ESIMD/hardware_dispatch.cpp
6864
// CHECK-NEXT: InlineAsm/asm_multiple_instructions.cpp
69-
// CHECK-NEXT: KernelAndProgram/kernel-bundle-merge-options.cpp
7065
// CHECK-NEXT: Matrix/SG32/joint_matrix_annotated_ptr.cpp
7166
// CHECK-NEXT: Matrix/SG32/joint_matrix_bfloat16_colmajorA_colmajorB.cpp
7267
// CHECK-NEXT: Matrix/SG32/joint_matrix_bfloat16_packedB.cpp
@@ -85,15 +80,10 @@
8580
// CHECK-NEXT: NewOffloadDriver/sycl-external-with-optional-features.cpp
8681
// CHECK-NEXT: OptionalKernelFeatures/throw-exception-for-out-of-registers-on-kernel-launch.cpp
8782
// CHECK-NEXT: PerformanceTests/Reduction/reduce_over_sub_group.cpp
88-
// CHECK-NEXT: Printf/int.cpp
89-
// CHECK-NEXT: Printf/mixed-address-space.cpp
90-
// CHECK-NEXT: Printf/percent-symbol.cpp
9183
// CHECK-NEXT: Reduction/reduction_big_data.cpp
9284
// CHECK-NEXT: Reduction/reduction_nd_reducer_skip.cpp
9385
// CHECK-NEXT: Reduction/reduction_reducer_op_eq.cpp
9486
// CHECK-NEXT: Regression/build_log.cpp
9587
// CHECK-NEXT: Regression/complex_global_object.cpp
96-
// CHECK-NEXT: Regression/context_is_destroyed_after_exception.cpp
9788
// CHECK-NEXT: Regression/kernel_bundle_ignore_sycl_external.cpp
98-
// CHECK-NEXT: Regression/multiple-targets.cpp
9989
// CHECK-NEXT: Regression/reduction_resource_leak_dw.cpp

0 commit comments

Comments
 (0)