Skip to content

Commit 7669de4

Browse files
committed
Add "-fsycl-device-only" to ESIMD diagnostics tests
The reason for the change is that "-verify" mode does not work correctly with new integration footer approach, because it seems to ignore line markers in the input file. Since ESIMD tests for diagnostic messages only check device APIs and device compilation is the first step in our compilation flow, added "-fsycl-device-only" to avoid launching the host compilation. The positive side of this change is that now those tests should be a bit quicker as they do less work. The downside would be that we don't check for diagnostics coming out of host compilation.
1 parent 30ce3d0 commit 7669de4

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

sycl/test/esimd/enums.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %clangxx -fsycl -fsyntax-only -Xclang -verify %s
1+
// RUN: %clangxx -fsycl -fsycl-device-only -fsyntax-only -Xclang -verify %s
22

33
// This test checks compilation of various ESIMD enum types. Those which are
44
// deprecated must produce deprecation messages.

sycl/test/esimd/flat_atomic.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %clangxx -fsycl -fsyntax-only -Xclang -verify %s
1+
// RUN: %clangxx -fsycl -fsycl-device-only -fsyntax-only -Xclang -verify %s
22

33
// This test checks compilation of ESIMD atomic APIs. Those which are deprecated
44
// must produce deprecation messages.

sycl/test/esimd/gather4_scatter4.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %clangxx -fsycl -fsyntax-only -Xclang -verify %s
1+
// RUN: %clangxx -fsycl -fsycl-device-only -fsyntax-only -Xclang -verify %s
22

33
// This test checks compilation of ESIMD slm gather4/scatter4 APIs. Those which
44
// are deprecated must produce deprecation messages.

sycl/test/esimd/simd_copy_to_copy_from.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
// RUN: %clangxx -fsycl -fsyntax-only -Xclang -verify %s
1+
// RUN: %clangxx -fsycl -fsycl-device-only -fsyntax-only -Xclang -verify %s
22

3-
// This test checks that both host and device compilers can:
3+
// This test checks that device compiler can:
44
// - successfully compile simd::copy_to and simd::copy_from APIs
55
// - emit an error if argument of an incompatible type is used
66
// in place of the accessor argument

sycl/test/esimd/slm_atomic.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %clangxx -fsycl -fsyntax-only -Xclang -verify %s
1+
// RUN: %clangxx -fsycl -fsycl-device-only -fsyntax-only -Xclang -verify %s
22

33
// This test checks compilation of ESIMD slm atomic APIs. Those which are
44
// deprecated must produce deprecation messages.

sycl/test/esimd/slm_load4.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %clangxx -fsycl -fsyntax-only -Xclang -verify %s
1+
// RUN: %clangxx -fsycl -fsycl-device-only -fsyntax-only -Xclang -verify %s
22

33
// This test checks compilation of ESIMD slm load4/store4 APIs. Those which are
44
// deprecated must produce deprecation messages.

0 commit comments

Comments
 (0)