Skip to content

Commit 787670e

Browse files
[SYCL] Remove old ABI AccessorBaseHost ctors (#13386)
1 parent 4dca823 commit 787670e

File tree

4 files changed

+0
-45
lines changed

4 files changed

+0
-45
lines changed

sycl/include/sycl/accessor.hpp

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -518,19 +518,6 @@ class __SYCL_EXPORT AccessorBaseHost {
518518
AccessorBaseHost(const AccessorImplPtr &Impl) : impl{Impl} {}
519519

520520
public:
521-
// TODO: the following function to be removed during next ABI break window
522-
AccessorBaseHost(id<3> Offset, range<3> AccessRange, range<3> MemoryRange,
523-
access::mode AccessMode, void *SYCLMemObject, int Dims,
524-
int ElemSize, int OffsetInBytes = 0,
525-
bool IsSubBuffer = false,
526-
const property_list &PropertyList = {});
527-
// TODO: the following function to be removed during next ABI break window
528-
AccessorBaseHost(id<3> Offset, range<3> AccessRange, range<3> MemoryRange,
529-
access::mode AccessMode, void *SYCLMemObject, int Dims,
530-
int ElemSize, bool IsPlaceH, int OffsetInBytes = 0,
531-
bool IsSubBuffer = false,
532-
const property_list &PropertyList = {});
533-
534521
AccessorBaseHost(id<3> Offset, range<3> AccessRange, range<3> MemoryRange,
535522
access::mode AccessMode, void *SYCLMemObject, int Dims,
536523
int ElemSize, size_t OffsetInBytes = 0,

sycl/source/accessor.cpp

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -23,32 +23,6 @@ device getDeviceFromHandler(handler &cgh) {
2323
return cgh.MGraph->getDevice();
2424
}
2525

26-
// TODO: the following function to be removed during next ABI break window
27-
AccessorBaseHost::AccessorBaseHost(id<3> Offset, range<3> AccessRange,
28-
range<3> MemoryRange,
29-
access::mode AccessMode, void *SYCLMemObject,
30-
int Dims, int ElemSize, int OffsetInBytes,
31-
bool IsSubBuffer,
32-
const property_list &PropertyList) {
33-
impl = std::shared_ptr<AccessorImplHost>(
34-
new AccessorImplHost(Offset, AccessRange, MemoryRange, AccessMode,
35-
(detail::SYCLMemObjI *)SYCLMemObject, Dims, ElemSize,
36-
false, OffsetInBytes, IsSubBuffer, PropertyList));
37-
}
38-
39-
// TODO: the following function to be removed during next ABI break window
40-
AccessorBaseHost::AccessorBaseHost(id<3> Offset, range<3> AccessRange,
41-
range<3> MemoryRange,
42-
access::mode AccessMode, void *SYCLMemObject,
43-
int Dims, int ElemSize, bool IsPlaceH,
44-
int OffsetInBytes, bool IsSubBuffer,
45-
const property_list &PropertyList) {
46-
impl = std::shared_ptr<AccessorImplHost>(
47-
new AccessorImplHost(Offset, AccessRange, MemoryRange, AccessMode,
48-
(detail::SYCLMemObjI *)SYCLMemObject, Dims, ElemSize,
49-
IsPlaceH, OffsetInBytes, IsSubBuffer, PropertyList));
50-
}
51-
5226
AccessorBaseHost::AccessorBaseHost(id<3> Offset, range<3> AccessRange,
5327
range<3> MemoryRange,
5428
access::mode AccessMode, void *SYCLMemObject,

sycl/test/abi/sycl_symbols_linux.dump

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3334,13 +3334,9 @@ _ZN4sycl3_V16detail16AccessorBaseHost14getAccessRangeEv
33343334
_ZN4sycl3_V16detail16AccessorBaseHost14getMemoryRangeEv
33353335
_ZN4sycl3_V16detail16AccessorBaseHost6getPtrEv
33363336
_ZN4sycl3_V16detail16AccessorBaseHost9getOffsetEv
3337-
_ZN4sycl3_V16detail16AccessorBaseHostC1ENS0_2idILi3EEENS0_5rangeILi3EEES6_NS0_6access4modeEPviibibRKNS0_13property_listE
33383337
_ZN4sycl3_V16detail16AccessorBaseHostC1ENS0_2idILi3EEENS0_5rangeILi3EEES6_NS0_6access4modeEPviibmbRKNS0_13property_listE
3339-
_ZN4sycl3_V16detail16AccessorBaseHostC1ENS0_2idILi3EEENS0_5rangeILi3EEES6_NS0_6access4modeEPviiibRKNS0_13property_listE
33403338
_ZN4sycl3_V16detail16AccessorBaseHostC1ENS0_2idILi3EEENS0_5rangeILi3EEES6_NS0_6access4modeEPviimbRKNS0_13property_listE
3341-
_ZN4sycl3_V16detail16AccessorBaseHostC2ENS0_2idILi3EEENS0_5rangeILi3EEES6_NS0_6access4modeEPviibibRKNS0_13property_listE
33423339
_ZN4sycl3_V16detail16AccessorBaseHostC2ENS0_2idILi3EEENS0_5rangeILi3EEES6_NS0_6access4modeEPviibmbRKNS0_13property_listE
3343-
_ZN4sycl3_V16detail16AccessorBaseHostC2ENS0_2idILi3EEENS0_5rangeILi3EEES6_NS0_6access4modeEPviiibRKNS0_13property_listE
33443340
_ZN4sycl3_V16detail16AccessorBaseHostC2ENS0_2idILi3EEENS0_5rangeILi3EEES6_NS0_6access4modeEPviimbRKNS0_13property_listE
33453341
_ZN4sycl3_V16detail16AccessorImplHost6resizeEm
33463342
_ZN4sycl3_V16detail16AccessorImplHostD1Ev

sycl/test/abi/sycl_symbols_windows.dump

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -464,9 +464,7 @@
464464
??0AccessorBaseHost@detail@_V1@sycl@@IEAA@AEBV?$shared_ptr@VAccessorImplHost@detail@_V1@sycl@@@std@@@Z
465465
??0AccessorBaseHost@detail@_V1@sycl@@QEAA@$$QEAV0123@@Z
466466
??0AccessorBaseHost@detail@_V1@sycl@@QEAA@AEBV0123@@Z
467-
??0AccessorBaseHost@detail@_V1@sycl@@QEAA@V?$id@$02@23@V?$range@$02@23@1W4mode@access@23@PEAXHHH_NAEBVproperty_list@23@@Z
468467
??0AccessorBaseHost@detail@_V1@sycl@@QEAA@V?$id@$02@23@V?$range@$02@23@1W4mode@access@23@PEAXHH_K_NAEBVproperty_list@23@@Z
469-
??0AccessorBaseHost@detail@_V1@sycl@@QEAA@V?$id@$02@23@V?$range@$02@23@1W4mode@access@23@PEAXHH_NH4AEBVproperty_list@23@@Z
470468
??0AccessorBaseHost@detail@_V1@sycl@@QEAA@V?$id@$02@23@V?$range@$02@23@1W4mode@access@23@PEAXHH_N_K4AEBVproperty_list@23@@Z
471469
??0AccessorImplHost@detail@_V1@sycl@@QEAA@AEBV0123@@Z
472470
??0AccessorImplHost@detail@_V1@sycl@@QEAA@V?$id@$02@23@V?$range@$02@23@1W4mode@access@23@PEAXHHH_NAEBVproperty_list@23@@Z

0 commit comments

Comments
 (0)