Skip to content

Commit 79128dc

Browse files
author
sarathnandu
committed
Address review comments.
1 parent f5f8e5b commit 79128dc

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

sycl/source/detail/kernel_impl.hpp

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,14 @@ class kernel_impl {
6262
/// \param ProgramImpl is a valid instance of program_impl
6363
kernel_impl(ContextImplPtr Context, ProgramImplPtr ProgramImpl);
6464

65+
// This section means the object is non-movable and non-copyable
66+
// There is no need of move and copy constructors in kernel_impl.
67+
// If they need to be added, piKernelRetain method for MKernel should be present.
68+
kernel_impl(const kernel_impl &) = delete;
69+
kernel_impl(kernel_impl &&) = delete;
70+
kernel_impl &operator=(const kernel_impl &) = delete;
71+
kernel_impl &operator=(kernel_impl &&) = delete;
72+
6573
~kernel_impl();
6674

6775
/// Gets a valid OpenCL kernel handle
@@ -145,13 +153,6 @@ class kernel_impl {
145153
const ContextImplPtr MContext;
146154
const ProgramImplPtr MProgramImpl;
147155
bool MCreatedFromSource = true;
148-
149-
public:
150-
// This section means the object is non-movable and non-copyable
151-
kernel_impl(const kernel_impl &) = delete;
152-
kernel_impl(kernel_impl &&) = delete;
153-
kernel_impl &operator=(const kernel_impl &) = delete;
154-
kernel_impl &operator=(kernel_impl &&) = delete;
155156
};
156157

157158
} // namespace detail

0 commit comments

Comments
 (0)