Skip to content

Commit 791ac60

Browse files
[SYCL] More adjustments for SYCL 2020 vec aliases (#7896)
This is a follow-up from #7889. Adjusted LIT tests to account for the new definition of `long{n}` alias, which may not always be equal to `sycl::vec<long, n>` now. Removed some dead code (type traits) from the runtime.
1 parent 31608c2 commit 791ac60

File tree

3 files changed

+13
-58
lines changed

3 files changed

+13
-58
lines changed

sycl/include/sycl/detail/generic_type_traits.hpp

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -128,17 +128,6 @@ using is_intn = is_contained<T, gtl::vector_signed_int_list>;
128128

129129
template <typename T> using is_genint = is_contained<T, gtl::signed_int_list>;
130130

131-
template <typename T>
132-
using is_ulongn = is_contained<T, gtl::vector_unsigned_long_list>;
133-
134-
template <typename T>
135-
using is_ugenlong = is_contained<T, gtl::unsigned_long_list>;
136-
137-
template <typename T>
138-
using is_longn = is_contained<T, gtl::vector_signed_long_list>;
139-
140-
template <typename T> using is_genlong = is_contained<T, gtl::signed_long_list>;
141-
142131
template <typename T>
143132
using is_ulonglongn = is_contained<T, gtl::vector_unsigned_longlong_list>;
144133

sycl/test/basic_tests/generic_type_traits.cpp

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -99,42 +99,6 @@ int main() {
9999
is_genint
100100
*/
101101

102-
// is_ulongn
103-
static_assert(d::is_ulongn<s::uchar>::value == false, "");
104-
static_assert(d::is_ulongn<s::ulong>::value == false, "");
105-
static_assert(d::is_ulongn<s::ulong2>::value == true, "");
106-
static_assert(d::is_ulongn<s::ulong3>::value == true, "");
107-
static_assert(d::is_ulongn<s::ulong4>::value == true, "");
108-
static_assert(d::is_ulongn<s::ulong8>::value == true, "");
109-
static_assert(d::is_ulongn<s::ulong16>::value == true, "");
110-
111-
// is_ugenlong
112-
static_assert(d::is_ugenlong<s::uchar>::value == false, "");
113-
static_assert(d::is_ugenlong<s::ulong>::value == true, "");
114-
static_assert(d::is_ugenlong<s::ulong2>::value == true, "");
115-
static_assert(d::is_ugenlong<s::ulong3>::value == true, "");
116-
static_assert(d::is_ugenlong<s::ulong4>::value == true, "");
117-
static_assert(d::is_ugenlong<s::ulong8>::value == true, "");
118-
static_assert(d::is_ugenlong<s::ulong16>::value == true, "");
119-
120-
// is_longn
121-
static_assert(d::is_longn<char>::value == false, "");
122-
static_assert(d::is_longn<long>::value == false, "");
123-
static_assert(d::is_longn<s::long2>::value == true, "");
124-
static_assert(d::is_longn<s::long3>::value == true, "");
125-
static_assert(d::is_longn<s::long4>::value == true, "");
126-
static_assert(d::is_longn<s::long8>::value == true, "");
127-
static_assert(d::is_longn<s::long16>::value == true, "");
128-
129-
// is_genlong
130-
static_assert(d::is_genlong<char>::value == false, "");
131-
static_assert(d::is_genlong<long>::value == true, "");
132-
static_assert(d::is_genlong<s::long2>::value == true, "");
133-
static_assert(d::is_genlong<s::long3>::value == true, "");
134-
static_assert(d::is_genlong<s::long4>::value == true, "");
135-
static_assert(d::is_genlong<s::long8>::value == true, "");
136-
static_assert(d::is_genlong<s::long16>::value == true, "");
137-
138102
/*
139103
is_ulonglongn
140104
is_ugenlonglong

sycl/test/basic_tests/vectors/vectors.cpp

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
#define SYCL_SIMPLE_SWIZZLES
1212
#include <sycl/sycl.hpp>
1313

14+
#include <cstddef>
15+
1416
void check_vectors(sycl::int4 a, sycl::int4 b, sycl::int4 c, sycl::int4 gold) {
1517
sycl::int4 result = a * (sycl::int4)b.y() + c;
1618
assert((int)result.x() == (int)gold.x());
@@ -100,17 +102,17 @@ int main() {
100102
auto asVec = inputVec.template swizzle<sycl::elem::s0, sycl::elem::s1>()
101103
.template as<sycl::vec<int16_t, 1>>();
102104

103-
// Check that [u]long[n] type aliases match vec<[unsigned] long, n> types.
104-
assert((std::is_same<sycl::vec<long, 2>, sycl::long2>::value));
105-
assert((std::is_same<sycl::vec<long, 3>, sycl::long3>::value));
106-
assert((std::is_same<sycl::vec<long, 4>, sycl::long4>::value));
107-
assert((std::is_same<sycl::vec<long, 8>, sycl::long8>::value));
108-
assert((std::is_same<sycl::vec<long, 16>, sycl::long16>::value));
109-
assert((std::is_same<sycl::vec<unsigned long, 2>, sycl::ulong2>::value));
110-
assert((std::is_same<sycl::vec<unsigned long, 3>, sycl::ulong3>::value));
111-
assert((std::is_same<sycl::vec<unsigned long, 4>, sycl::ulong4>::value));
112-
assert((std::is_same<sycl::vec<unsigned long, 8>, sycl::ulong8>::value));
113-
assert((std::is_same<sycl::vec<unsigned long, 16>, sycl::ulong16>::value));
105+
// Check that [u]long[n] type aliases match vec<[u]int64_t, n> types.
106+
assert((std::is_same<sycl::vec<std::int64_t, 2>, sycl::long2>::value));
107+
assert((std::is_same<sycl::vec<std::int64_t, 3>, sycl::long3>::value));
108+
assert((std::is_same<sycl::vec<std::int64_t, 4>, sycl::long4>::value));
109+
assert((std::is_same<sycl::vec<std::int64_t, 8>, sycl::long8>::value));
110+
assert((std::is_same<sycl::vec<std::int64_t, 16>, sycl::long16>::value));
111+
assert((std::is_same<sycl::vec<std::uint64_t, 2>, sycl::ulong2>::value));
112+
assert((std::is_same<sycl::vec<std::uint64_t, 3>, sycl::ulong3>::value));
113+
assert((std::is_same<sycl::vec<std::uint64_t, 4>, sycl::ulong4>::value));
114+
assert((std::is_same<sycl::vec<std::uint64_t, 8>, sycl::ulong8>::value));
115+
assert((std::is_same<sycl::vec<std::uint64_t, 16>, sycl::ulong16>::value));
114116

115117
// Check convert() from and to various types.
116118
check_convert_from<int8_t>();

0 commit comments

Comments
 (0)