Skip to content

Commit 7a4bb2c

Browse files
[CI] Move more pre-commit E2E jobs to use pre-built binaries (#17011)
... and stop limiting number of tests running on Intel Arc GPUs. With the speedup of using pre-built binaries we can afford full coverage.
1 parent 0fb0d27 commit 7a4bb2c

File tree

1 file changed

+15
-58
lines changed

1 file changed

+15
-58
lines changed

.github/workflows/sycl-linux-precommit.yml

Lines changed: 15 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -51,30 +51,8 @@ jobs:
5151
changes: ${{ needs.detect_changes.outputs.filters }}
5252
e2e_binaries_artifact: sycl_e2e_bin_default
5353

54-
determine_arc_tests:
55-
name: Decide which Arc tests to run
56-
needs: [build, detect_changes]
57-
if: ${{ always() && !cancelled() && needs.build.outputs.build_conclusion == 'success' }}
58-
runs-on: [Linux, aux-tasks]
59-
timeout-minutes: 3
60-
outputs:
61-
arc_tests: ${{ steps.arc_tests.outputs.arc_tests }}
62-
steps:
63-
- name: Determine Arc tests
64-
id: arc_tests
65-
run: |
66-
if [ "${{ contains(needs.detect_changes.outputs.filters, 'devigccfg') }}" == "true" ]; then
67-
echo 'arc_tests="(ESIMD|InvokeSimd|Matrix)/"' >> "$GITHUB_OUTPUT"
68-
elif [ "${{ contains(needs.detect_changes.outputs.filters, 'drivers') }}" == "true" ]; then
69-
echo 'arc_tests=""' >> "$GITHUB_OUTPUT"
70-
elif [ "${{ contains(needs.detect_changes.outputs.filters, 'esimd') }}" == "true" ]; then
71-
echo 'arc_tests="(ESIMD|InvokeSimd|Matrix)/"' >> "$GITHUB_OUTPUT"
72-
else
73-
echo 'arc_tests="Matrix/"' >> "$GITHUB_OUTPUT"
74-
fi
75-
7654
run_prebuilt_e2e_tests:
77-
needs: [build, detect_changes, determine_arc_tests]
55+
needs: [build, detect_changes]
7856
if: ${{ always() && !cancelled() && needs.build.outputs.build_conclusion == 'success' }}
7957
strategy:
8058
fail-fast: false
@@ -96,7 +74,19 @@ jobs:
9674
target_devices: level_zero:gpu;opencl:gpu
9775
reset_intel_gpu: true
9876
extra_lit_opts: --param matrix-xmx8=True
99-
env: '{"LIT_FILTER":${{ needs.determine_arc_tests.outputs.arc_tests }} }'
77+
- name: E2E tests with dev igc on Intel Arc A-Series Graphics
78+
runner: '["Linux", "arc"]'
79+
image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:devigc
80+
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
81+
target_devices: level_zero:gpu;opencl:gpu
82+
reset_intel_gpu: true
83+
extra_lit_opts: --param matrix-xmx8=True
84+
use_igc_dev: true
85+
- name: E2E tests on Intel Ponte Vecchio GPU
86+
runner: '["Linux", "pvc"]'
87+
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
88+
target_devices: level_zero:gpu;opencl:gpu
89+
extra_lit_opts: -j 50
10090
- name: Dev IGC on Intel Ponte Vecchio GPU
10191
runner: '["Linux", "pvc"]'
10292
image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:devigc
@@ -141,7 +131,7 @@ jobs:
141131
skip_run: ${{matrix.use_igc_dev && contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') || 'false'}}
142132

143133
test:
144-
needs: [build, detect_changes, determine_arc_tests]
134+
needs: [build, detect_changes]
145135
if: ${{ always() && !cancelled() && needs.build.outputs.build_conclusion == 'success' }}
146136
strategy:
147137
fail-fast: false
@@ -151,46 +141,13 @@ jobs:
151141
runner: '["Linux", "amdgpu"]'
152142
image_options: -u 1001 --device=/dev/dri --device=/dev/kfd
153143
target_devices: hip:gpu
154-
reset_intel_gpu: false
155-
- name: E2E tests with dev igc on Intel Arc A-Series Graphics
156-
runner: '["Linux", "arc"]'
157-
image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:devigc
158-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
159-
target_devices: level_zero:gpu;opencl:gpu
160-
reset_intel_gpu: true
161-
extra_lit_opts: --param matrix-xmx8=True
162-
env: '{"LIT_FILTER":${{ needs.determine_arc_tests.outputs.arc_tests }} }'
163-
use_igc_dev: true
164-
- name: E2E tests on Intel Ponte Vecchio GPU
165-
runner: '["Linux", "pvc"]'
166-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
167-
target_devices: level_zero:gpu;opencl:gpu
168-
extra_lit_opts: -j 50
169144

170145
uses: ./.github/workflows/sycl-linux-run-tests.yml
171146
with:
172147
name: ${{ matrix.name }}
173148
runner: ${{ matrix. runner }}
174-
image: ${{ matrix.image }}
175149
image_options: ${{ matrix.image_options }}
176150
target_devices: ${{ matrix.target_devices }}
177-
reset_intel_gpu: ${{ matrix.reset_intel_gpu }}
178-
extra_lit_opts: ${{ matrix.extra_lit_opts }}
179-
env: ${{ matrix.env || '{}' }}
180-
181-
# Do not install drivers on AMD and CUDA runners.
182-
install_igc_driver: >-
183-
${{ !contains(matrix.target_devices, 'cuda') &&
184-
!contains(matrix.target_devices, 'hip') &&
185-
contains(needs.detect_changes.outputs.filters, 'drivers') }}
186-
install_dev_igc_driver: >-
187-
${{ !contains(matrix.target_devices, 'cuda') &&
188-
!contains(matrix.target_devices, 'hip') &&
189-
matrix.use_igc_dev &&
190-
(contains(needs.detect_changes.outputs.filters, 'devigccfg') || contains(needs.detect_changes.outputs.filters, 'drivers')) ||
191-
'false' }}
192-
# Run only if the PR does not have the 'ci-no-devigc' label.
193-
skip_run: ${{matrix.use_igc_dev && contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') || 'false'}}
194151

195152
ref: ${{ github.sha }}
196153

0 commit comments

Comments
 (0)