Skip to content

Commit 7edcd43

Browse files
authored
Revert "[SYCL] Add support for the in-tree end-to-end tests (#8081)"
This reverts commit 990a71f.
1 parent ec064e6 commit 7edcd43

File tree

8 files changed

+4
-623
lines changed

8 files changed

+4
-623
lines changed

.github/workflows/sycl_linux_build_and_test.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,6 @@ jobs:
160160
run: tar -cJf llvm_sycl.tar.xz -C $GITHUB_WORKSPACE/build/install .
161161
- name: Pack LIT
162162
run: tar -cJf lit.tar.xz -C $GITHUB_WORKSPACE/src/llvm/utils/lit .
163-
- name: Pack End-to-End LIT tests
164-
run: tar -cJf e2e_tests.tar.xz -C $GITHUB_WORKSPACE/src/sycl/test-e2e .
165163
- name: Upload toolchain
166164
uses: actions/upload-artifact@v3
167165
with:
@@ -172,11 +170,6 @@ jobs:
172170
with:
173171
name: sycl_lit_${{ inputs.build_artifact_suffix }}
174172
path: lit.tar.xz
175-
- name: Upload End-to-End LIT tests
176-
uses: actions/upload-artifact@v3
177-
with:
178-
name: sycl_e2e_tests_${{ inputs.build_artifact_suffix }}
179-
path: e2e_tests.tar.xz
180173

181174
aws-start:
182175
name: Start AWS
@@ -248,12 +241,9 @@ jobs:
248241
sycl_archive: llvm_sycl.tar.xz
249242
lit_artifact: sycl_lit_${{ inputs.build_artifact_suffix }}
250243
lit_archive: lit.tar.xz
251-
e2e_tests_artifact: sycl_e2e_tests_${{ inputs.build_artifact_suffix }}
252-
e2e_tests_archive: e2e_tests.tar.xz
253244
check_sycl_all: ${{ matrix.check_sycl_all }}
254245
results_name_suffix: ${{ matrix.config }}_${{ inputs.build_artifact_suffix }}
255246
cmake_args: '${{ matrix.cmake_args }} ${{ inputs.lts_cmake_extra_args }}'
256-
in_tree_e2e: ${{ matrix.in_tree_e2e }}
257247

258248
khronos_sycl_cts:
259249
needs: build

devops/actions/llvm_test_suite/action.yml

Lines changed: 4 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,6 @@ inputs:
1919
description: 'Name of LIT archive file'
2020
required: false
2121
default: 'lit.tar.xz'
22-
e2e_tests_artifact:
23-
description: 'Name of the artifact, that contains End-to-End LIT Tests'
24-
required: true
25-
e2e_tests_archive:
26-
description: 'Name of End-to-End LIT Tests archive file'
27-
required: false
28-
default: 'e2e_tests.tar.xz'
2922
results_name_suffix:
3023
description: 'Name suffix of the results artifact'
3124
required: true
@@ -35,10 +28,6 @@ inputs:
3528
cmake_args:
3629
description: 'Extra arguments to cmake command'
3730
required: false
38-
in_tree_e2e:
39-
description: "Flag directing to use in-tree End-to-End LIT tests"
40-
required: false
41-
default: false
4231

4332
post-if: false
4433
runs:
@@ -77,33 +66,13 @@ runs:
7766
ls -la
7867
tar -xf ${{ inputs.lit_archive }} -C lit
7968
rm -f ${{ inputs.lit_archive }}
80-
- name: Download End-to-End LIT Tests
81-
if: inputs.in_tree_e2e
82-
uses: actions/download-artifact@v3
83-
with:
84-
name: ${{ inputs.e2e_tests_artifact }}
85-
- name: Extract End-to-End LIT Tests
86-
if: inputs.in_tree_e2e
87-
shell: bash
88-
run: |
89-
mkdir test_e2e
90-
ls -la
91-
tar -xf ${{ inputs.e2e_tests_archive }} -C test_e2e
92-
ls -R test_e2e
93-
rm -f ${{ inputs.e2e_tests_archive }}
9469
- name: Configure
9570
shell: bash
9671
run: |
9772
echo "::group::CMake configuration"
9873
mkdir build
9974
export PATH=$PWD/toolchain/bin/:$PATH
100-
if ${{ inputs.in_tree_e2e }}
101-
then
102-
# TODO: Rename check_sycl_all input
103-
cmake -GNinja -B./build -S./test_e2e -DSYCL_TEST_E2E_TARGETS="${{ inputs.check_sycl_all }}" -DCMAKE_CXX_COMPILER="$PWD/toolchain/bin/clang++" -DLLVM_LIT="$PWD/lit/lit.py" ${{ inputs.cmake_args }}
104-
else
105-
cmake -GNinja -B./build -S./llvm_test_suite -DTEST_SUITE_SUBDIRS=SYCL -DCHECK_SYCL_ALL="${{ inputs.check_sycl_all }}" -DCMAKE_CXX_COMPILER="$PWD/toolchain/bin/clang++" -DTEST_SUITE_LIT="$PWD/lit/lit.py" ${{ inputs.cmake_args }}
106-
fi
75+
cmake -GNinja -B./build -S./llvm_test_suite -DTEST_SUITE_SUBDIRS=SYCL -DCHECK_SYCL_ALL="${{ inputs.check_sycl_all }}" -DCMAKE_CXX_COMPILER="$PWD/toolchain/bin/clang++" -DTEST_SUITE_LIT="$PWD/lit/lit.py" ${{ inputs.cmake_args }}
10776
echo "::endgroup::"
10877
- name: Run testing
10978
shell: bash
@@ -112,7 +81,7 @@ runs:
11281
export PATH=$PWD/toolchain/bin/:$PATH
11382
# TODO make this part of container build
11483
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/opt/rocm/hip/lib/:/opt/rocm/lib
115-
export LIT_OPTS="-v --no-progress-bar --show-unsupported --max-time 3600 --time-tests -o $PWD/build/results_${{ inputs.results_name_suffix }}_${{ inputs.in_tree_e2e }}.json"
84+
export LIT_OPTS="-v --no-progress-bar --show-unsupported --max-time 3600 --time-tests -o $PWD/build/results_${{ inputs.results_name_suffix }}.json"
11685
if [ -e /runtimes/oneapi-tbb/env/vars.sh ]; then
11786
source /runtimes/oneapi-tbb/env/vars.sh;
11887
elif [ -e /opt/runtimes/oneapi-tbb/env/vars.sh ]; then
@@ -134,18 +103,13 @@ runs:
134103
SYCL_PI_TRACE=-1 sycl-ls
135104
echo "::endgroup::"
136105
cd build
137-
if ${{ inputs.in_tree_e2e }}
138-
then
139-
ninja check-sycl-e2e
140-
else
141-
ninja check-sycl-all
142-
fi
106+
ninja check-sycl-all
143107
- name: Upload test results
144108
uses: actions/upload-artifact@v1
145109
if: always()
146110
with:
147111
name: lit_results
148-
path: build/results_${{ inputs.results_name_suffix }}_${{ inputs.in_tree_e2e}}.json
112+
path: build/results_${{ inputs.results_name_suffix }}.json
149113
- name: Cleanup
150114
shell: bash
151115
if: always()
@@ -154,4 +118,3 @@ runs:
154118
rm -rf lit
155119
rm -rf build
156120
rm -rf llvm_test_suite
157-
rm -rf test-e2e

devops/scripts/generate_test_matrix.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,8 @@ module.exports = ({core, process}) => {
4747
} else {
4848
v["env"] = {};
4949
}
50-
// Temporary support for both in-tree/out-of-tree (llvm-test-suite)
51-
// end-to-end tests.
52-
v["in_tree_e2e"] = false;
5350
enabledLTSConfigs.push(v);
5451
if (v["aws-type"]) enabledLTSAWSConfigs.push(v);
55-
56-
var inTreeV = Object.assign({}, v);
57-
inTreeV["in_tree_e2e"] = true;
58-
inTreeV["name"] = inTreeV["name"] + " In-Tree"
59-
enabledLTSConfigs.push(inTreeV);
6052
}
6153
});
6254

sycl/CMakeLists.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -486,6 +486,3 @@ add_custom_target(deploy-sycl-toolchain
486486

487487
# SYCL Runtime documentation
488488
add_subdirectory(doc)
489-
490-
# SYCL End-to-End tests (former intel/llvm-test-suite).
491-
add_subdirectory(test-e2e)

sycl/test-e2e/CMakeLists.txt

Lines changed: 0 additions & 72 deletions
This file was deleted.

sycl/test-e2e/TestSuiteMove/hello.cpp

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)