Skip to content

Commit 83f8779

Browse files
[SYCL] Revert recent copy requirements temporarily (#9970)
This commit reverts the recently introduced requirements on `is_device_copyable` in copy commands. This is a temporary revert until `sycl::vec` is made trivially copyable, to appropriately satisfy `is_device_copyable` implicitly. --------- Signed-off-by: Larsen, Steffen <[email protected]>
1 parent 1a6f7a5 commit 83f8779

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

sycl/include/sycl/handler.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2289,8 +2289,8 @@ class __SYCL_EXPORT handler {
22892289
"Invalid accessor target for the copy method.");
22902290
static_assert(isValidModeForDestinationAccessor(AccessMode),
22912291
"Invalid accessor mode for the copy method.");
2292-
static_assert(is_device_copyable<T_Src>::value,
2293-
"Pattern must be device copyable");
2292+
// TODO: Add static_assert with is_device_copyable when vec is
2293+
// device-copyable.
22942294
// Make sure data shared_ptr points to is not released until we finish
22952295
// work with it.
22962296
CGData.MSharedPtrStorage.push_back(Src);
@@ -2360,8 +2360,8 @@ class __SYCL_EXPORT handler {
23602360
"Invalid accessor target for the copy method.");
23612361
static_assert(isValidModeForDestinationAccessor(AccessMode),
23622362
"Invalid accessor mode for the copy method.");
2363-
static_assert(is_device_copyable<T_Src>::value,
2364-
"Pattern must be device copyable");
2363+
// TODO: Add static_assert with is_device_copyable when vec is
2364+
// device-copyable.
23652365
#ifndef __SYCL_DEVICE_ONLY__
23662366
if (MIsHost) {
23672367
// TODO: Temporary implementation for host. Should be handled by memory

0 commit comments

Comments
 (0)