Skip to content

Commit 857e0cb

Browse files
author
Pavel V Chupin
committed
Let non-AWS tasks continue, even if AWS start failed
1 parent 812df36 commit 857e0cb

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.github/workflows/sycl_linux_build_and_test.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,9 @@ jobs:
196196

197197
llvm_test_suite:
198198
needs: [build, aws-start]
199-
if: ${{ !failure() && inputs.lts_matrix != '[]' }}
199+
# Continue if build was successful. If aws-start is not successful all
200+
# AWS tasks will fail, but all non-AWS tasks should continue.
201+
if: ${{ always() && (needs.build.outputs.job_status=='success') && inputs.lts_matrix != '[]' }}
200202
strategy:
201203
fail-fast: false
202204
max-parallel: ${{ inputs.max_parallel }}
@@ -243,7 +245,7 @@ jobs:
243245
check_sycl_all: ${{ matrix.check_sycl_all }}
244246
results_name_suffix: ${{ matrix.config }}_${{ inputs.build_artifact_suffix }}
245247
cmake_args: '${{ matrix.cmake_args }} ${{ inputs.lts_cmake_extra_args }}'
246-
248+
247249
khronos_sycl_cts:
248250
needs: build
249251
if: ${{ inputs.cts_matrix != '' }}
@@ -294,6 +296,8 @@ jobs:
294296
aws-stop:
295297
name: Stop AWS
296298
needs: [ aws-start, llvm_test_suite ]
299+
# Always attempt to shutdown AWS instance, even if AWS start was not
300+
# successful.
297301
if: ${{ always() && inputs.lts_aws_matrix != '[]' }}
298302
runs-on: ubuntu-latest
299303
environment: aws

devops/test_configs.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
},
7575
{
7676
"config": "cuda_aws",
77-
"name": "CUDA LLVM Test Suite",
77+
"name": "[AWS] CUDA LLVM Test Suite",
7878
"runs-on": "aws-cuda_${{ inputs.uniq }}",
7979
"aws-ami": "ami-01cb0573cb039ab24",
8080
"aws-type": [ "g5.2xlarge", "g5.4xlarge" ],

0 commit comments

Comments
 (0)