Skip to content

Commit 873ad55

Browse files
alexeyvoronov-intelvladimirlaz
authored andcommitted
[SCYL] Revert SYCL __private address space value to 0.
Signed-off-by: Vladimir Lazarev <[email protected]> Signed-off-by: Alexey Voronov <[email protected]>
1 parent f0d1636 commit 873ad55

File tree

6 files changed

+16
-19
lines changed

6 files changed

+16
-19
lines changed

clang/lib/AST/ASTContext.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -750,7 +750,7 @@ static const LangASMap *getAddressSpaceMap(const TargetInfo &T,
750750
1, // sycl_global
751751
3, // sycl_local
752752
2, // sycl_constant
753-
5, // sycl_private
753+
0, // sycl_private
754754
4, // sycl_generic
755755
};
756756
return &FakeAddrSpaceMap;

clang/lib/Basic/Targets/NVPTX.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ static const unsigned NVPTXAddrSpaceMap[] = {
3636
1, // sycl_global
3737
3, // sycl_local
3838
4, // sycl_constant
39-
5, // sycl_private
39+
0, // sycl_private
4040
// FIXME: generic has to be added to the target
4141
0, // sycl_generic
4242
};

clang/lib/Basic/Targets/SPIR.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ static const unsigned SPIRAddrSpaceMap[] = {
3434
1, // sycl_global
3535
3, // sycl_local
3636
2, // sycl_constant
37-
5, // sycl_private
37+
0, // sycl_private
3838
4, // sycl_generic
3939
};
4040

clang/lib/Basic/Targets/TCE.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ static const unsigned TCEOpenCLAddrSpaceMap[] = {
4343
3, // sycl_global
4444
4, // sycl_local
4545
5, // sycl_constant
46-
5, // sycl_private
46+
0, // sycl_private
4747
// FIXME: generic has to be added to the target
4848
0, // sycl_generic
4949
};

clang/lib/Sema/SemaType.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5833,7 +5833,7 @@ static bool BuildAddressSpaceIndex(Sema &S, LangAS &ASIdx,
58335833
return false;
58345834
}
58355835

5836-
if (S.LangOpts.SYCLIsDevice && (addrSpace == 4 || addrSpace > 5)) {
5836+
if (S.LangOpts.SYCLIsDevice && (addrSpace >= 4)) {
58375837
S.Diag(AttrLoc, diag::err_sycl_attribute_address_space_invalid)
58385838
<< AddrSpace->getSourceRange();
58395839
return false;
@@ -5846,7 +5846,7 @@ static bool BuildAddressSpaceIndex(Sema &S, LangAS &ASIdx,
58465846
ASIdx =
58475847
[](unsigned AS) {
58485848
switch (AS) {
5849-
case 5: case 0: return LangAS::sycl_private;
5849+
case 0: return LangAS::sycl_private;
58505850
case 1: return LangAS::sycl_global;
58515851
case 2: return LangAS::sycl_constant;
58525852
case 3: return LangAS::sycl_local;

clang/test/CodeGenSYCL/address-space-parameter-conversions.cpp

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,11 @@ void usages() {
8888

8989
void usages2() {
9090
__attribute__((address_space(0))) int *PRIV_NUM;
91-
// CHECK-DAG: [[PRIV_NUM:%[a-zA-Z0-9_]+]] = alloca i32 addrspace(5)*
92-
__attribute__((address_space(5))) int *PRIV_NUM2;
93-
// CHECK-DAG: [[PRIV_NUM2:%[a-zA-Z0-9_]+]] = alloca i32 addrspace(5)*
91+
// CHECK-DAG: [[PRIV_NUM:%[a-zA-Z0-9_]+]] = alloca i32*
92+
__attribute__((address_space(0))) int *PRIV_NUM2;
93+
// CHECK-DAG: [[PRIV_NUM2:%[a-zA-Z0-9_]+]] = alloca i32*
9494
__private int *PRIV;
95-
// CHECK-DAG: [[PRIV:%[a-zA-Z0-9_]+]] = alloca i32 addrspace(5)*
95+
// CHECK-DAG: [[PRIV:%[a-zA-Z0-9_]+]] = alloca i32*
9696
__attribute__((address_space(1))) int *GLOB_NUM;
9797
// CHECK-DAG: [[GLOB_NUM:%[a-zA-Z0-9_]+]] = alloca i32 addrspace(1)*
9898
__global int *GLOB;
@@ -107,17 +107,14 @@ void usages2() {
107107
// CHECK-DAG: [[LOCAL:%[a-zA-Z0-9_]+]] = alloca i32 addrspace(3)*
108108

109109
bar(*PRIV_NUM);
110-
// CHECK-DAG: [[PRIV_NUM_LOAD:%[a-zA-Z0-9]+]] = load i32 addrspace(5)*, i32 addrspace(5)** [[PRIV_NUM]]
111-
// CHECK-DAG: [[PRIV_NUM_CAST:%[a-zA-Z0-9]+]] = addrspacecast i32 addrspace(5)* [[PRIV_NUM_LOAD]] to i32 addrspace(4)*
112-
// CHECK-DAG: call spir_func void @new.[[RAW_REF]](i32 addrspace(4)* [[PRIV_NUM_CAST]])
110+
// CHECK-DAG: [[PRIV_NUM_LOAD:%[a-zA-Z0-9]+]] = load i32*, i32** [[PRIV_NUM]]
111+
// CHECK-DAG: call spir_func void @[[RAW_REF]](i32* dereferenceable(4) [[PRIV_NUM_LOAD]])
113112
bar(*PRIV_NUM2);
114-
// CHECK-DAG: [[PRIV_NUM2_LOAD:%[a-zA-Z0-9]+]] = load i32 addrspace(5)*, i32 addrspace(5)** [[PRIV_NUM2]]
115-
// CHECK-DAG: [[PRIV_NUM2_CAST:%[a-zA-Z0-9]+]] = addrspacecast i32 addrspace(5)* [[PRIV_NUM2_LOAD]] to i32 addrspace(4)*
116-
// CHECK-DAG: call spir_func void @new.[[RAW_REF]](i32 addrspace(4)* [[PRIV_NUM2_CAST]])
113+
// CHECK-DAG: [[PRIV_NUM2_LOAD:%[a-zA-Z0-9]+]] = load i32*, i32** [[PRIV_NUM2]]
114+
// CHECK-DAG: call spir_func void @[[RAW_REF]](i32* dereferenceable(4) [[PRIV_NUM2_LOAD]])
117115
bar(*PRIV);
118-
// CHECK-DAG: [[PRIV_LOAD:%[a-zA-Z0-9]+]] = load i32 addrspace(5)*, i32 addrspace(5)** [[PRIV]]
119-
// CHECK-DAG: [[PRIV_CAST:%[a-zA-Z0-9]+]] = addrspacecast i32 addrspace(5)* [[PRIV_LOAD]] to i32 addrspace(4)*
120-
// CHECK-DAG: call spir_func void @new.[[RAW_REF]](i32 addrspace(4)* [[PRIV_CAST]])
116+
// CHECK-DAG: [[PRIV_LOAD:%[a-zA-Z0-9]+]] = load i32*, i32** [[PRIV]]
117+
// CHECK-DAG: call spir_func void @[[RAW_REF]](i32* dereferenceable(4) [[PRIV_LOAD]])
121118
bar(*GLOB_NUM);
122119
// CHECK-DAG: [[GLOB_NUM_LOAD:%[a-zA-Z0-9]+]] = load i32 addrspace(1)*, i32 addrspace(1)** [[GLOB_NUM]]
123120
// CHECK-DAG: [[GLOB_NUM_CAST:%[a-zA-Z0-9]+]] = addrspacecast i32 addrspace(1)* [[GLOB_NUM_LOAD]] to i32 addrspace(4)*

0 commit comments

Comments
 (0)