Skip to content

Commit 8a29c44

Browse files
committed
Renamed extension to cover all bfloat16 funct.
Removed aspect reference: can be added once the ext_oneapi_bfloat16 aspect is merged.
1 parent 2f9b7d7 commit 8a29c44

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

sycl/doc/extensions/experimental/SYCL_EXT_ONEAPI_BF16_CONVERSION.asciidoc renamed to sycl/doc/extensions/experimental/sycl_ext_oneapi_bfloat16.asciidoc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
= sycl_oneapi_bf16_conversion
1+
= sycl_ext_oneapi_bfloat16
22

33
:source-highlighter: coderay
44
:coderay-linenums-mode: table
@@ -73,7 +73,7 @@ command (e.g. from `parallel_for`).
7373
This extension provides a feature-test macro as described in the core SYCL
7474
specification section 6.3.3 "Feature test macros". Therefore, an implementation
7575
supporting this extension must predefine the macro
76-
`SYCL_EXT_ONEAPI_BF16_CONVERSION` to one of the values defined in the table
76+
`SYCL_EXT_ONEAPI_BFLOAT16` to one of the values defined in the table
7777
below. Applications can test for the existence of this macro to determine if
7878
the implementation supports this feature, or applications can test the macro’s
7979
value to determine which of the extension’s APIs the implementation supports.
@@ -91,18 +91,18 @@ the implementation supports this feature, or applications can test the macro’s
9191
namespace sycl {
9292
enum class aspect {
9393
...
94-
ext_oneapi_bf16_conversion
94+
ext_oneapi_bfloat16
9595
}
9696
}
9797
----
9898

99-
If a SYCL device has the `ext_oneapi_bf16_conversion` aspect, then it natively
99+
If a SYCL device has the `ext_oneapi_bfloat16` aspect, then it natively
100100
supports conversion of values of `float` type to `bfloat16` and back.
101101

102102
If the device doesn't have the aspect, objects of `bfloat16` class must not be
103103
used in the device code.
104104

105-
**NOTE**: The `ext_oneapi_bf16_conversion` aspect is not yet supported. The
105+
**NOTE**: The `ext_oneapi_bfloat16` aspect is not yet supported. The
106106
`bfloat16` class is currently supported only on Xe HP GPU and Nvidia A100 GPU.
107107

108108
== New `bfloat16` class
@@ -304,7 +304,7 @@ int main (int argc, char *argv[]) {
304304
sycl::queue deviceQueue{dev};
305305
sycl::buffer<float, 1> buf {data, sycl::range<1> {3}};
306306
307-
if (dev.has(sycl::aspect::ext_oneapi_bf16_conversion)) {
307+
if (dev.has(sycl::aspect::ext_oneapi_bfloat16)) {
308308
deviceQueue.submit ([&] (sycl::handler& cgh) {
309309
auto numbers = buf.get_access<sycl::access::mode::read_write> (cgh);
310310
cgh.single_task<class simple_kernel> ([=] () {
@@ -332,5 +332,5 @@ None.
332332
Add operator overloadings +
333333
Apply code review suggestions
334334
|3|2021-08-18|Alexey Sotkin |Remove `uint16_t` constructor
335-
|4|2022-03-07|Jack Kirk |Switch from Intel vendor specific to oneapi
335+
|4|2022-03-07|Aidan Belton and Jack Kirk |Switch from Intel vendor specific to oneapi
336336
|========================================

sycl/include/sycl/ext/oneapi/experimental/bfloat16.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace ext {
1717
namespace oneapi {
1818
namespace experimental {
1919

20-
class [[sycl_detail::uses_aspects(ext_intel_bf16_conversion)]] bfloat16 {
20+
class bfloat16 {
2121
using storage_t = uint16_t;
2222
storage_t value;
2323

0 commit comments

Comments
 (0)