Skip to content

Commit 8a54b66

Browse files
Renamed slm_[load|store]_rgba -> slm_[gather|scatter]_rgba
1 parent ca15170 commit 8a54b66

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

sycl/include/sycl/ext/intel/experimental/esimd/memory.hpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -681,22 +681,22 @@ template <typename T, int N, rgba_channel_mask Mask>
681681
ESIMD_INLINE ESIMD_NODEBUG typename sycl::detail::enable_if_t<
682682
(N == 8 || N == 16 || N == 32) && (sizeof(T) == 4),
683683
simd<T, N * get_num_channels_enabled(Mask)>>
684-
slm_load_rgba(simd<uint32_t, N> offsets, simd<uint16_t, N> pred = 1) {
684+
slm_gather_rgba(simd<uint32_t, N> offsets, simd<uint16_t, N> pred = 1) {
685685
return __esimd_slm_read4<T, N, Mask>(offsets.data(), pred.data());
686686
}
687687

688688
/// SLM gather4.
689689
///
690690
/// Only allow simd-8, simd-16 and simd-32.
691691
template <typename T, int n, rgba_channel_mask Mask>
692-
__SYCL_DEPRECATED("use slm_load_rgba.")
692+
__SYCL_DEPRECATED("use slm_gather_rgba.")
693693
ESIMD_INLINE ESIMD_NODEBUG typename sycl::detail::enable_if_t<
694694
(n == 8 || n == 16 || n == 32) && (sizeof(T) == 4),
695695
simd<T, n * get_num_channels_enabled(Mask)>> slm_load4(simd<uint32_t, n>
696696
offsets,
697697
simd<uint16_t, n>
698698
pred = 1) {
699-
return slm_load_rgba<T, n, Mask>(offsets, pred);
699+
return slm_gather_rgba<T, n, Mask>(offsets, pred);
700700
}
701701

702702
/// Scatter write to the SLM given specified \p offsets.
@@ -712,19 +712,19 @@ ESIMD_INLINE ESIMD_NODEBUG typename sycl::detail::enable_if_t<
712712
template <typename T, int N, rgba_channel_mask Mask>
713713
ESIMD_INLINE ESIMD_NODEBUG typename sycl::detail::enable_if_t<
714714
(N == 8 || N == 16 || N == 32) && (sizeof(T) == 4), void>
715-
slm_store_rgba(simd<T, N * get_num_channels_enabled(Mask)> vals,
716-
simd<uint32_t, N> offsets, simd<uint16_t, N> pred = 1) {
715+
slm_scatter_rgba(simd<T, N * get_num_channels_enabled(Mask)> vals,
716+
simd<uint32_t, N> offsets, simd<uint16_t, N> pred = 1) {
717717
__esimd_slm_write4<T, N, Mask>(offsets.data(), vals.data(), pred.data());
718718
}
719719

720720
/// SLM scatter4.
721721
template <typename T, int n, rgba_channel_mask Mask>
722-
__SYCL_DEPRECATED("use slm_store_rgba.")
722+
__SYCL_DEPRECATED("use slm_scatter_rgba.")
723723
ESIMD_INLINE ESIMD_NODEBUG typename sycl::detail::enable_if_t<
724724
(n == 8 || n == 16 || n == 32) && (sizeof(T) == 4),
725725
void> slm_store4(simd<T, n * get_num_channels_enabled(Mask)> vals,
726726
simd<uint32_t, n> offsets, simd<uint16_t, n> pred = 1) {
727-
slm_store_rgba<T, n, Mask>(vals, offsets, pred);
727+
slm_scatter_rgba<T, n, Mask>(vals, offsets, pred);
728728
}
729729

730730
/// SLM block-load.
Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// RUN: %clangxx -fsycl -fsyntax-only -Wno-unused-command-line-argument %s 2>&1 | FileCheck %s --implicit-check-not="warning:" --implicit-check-not="error:"
22

3-
// This test checks compilation of ESIMD slm_load_rgba/slm_store_rgba APIs.
3+
// This test checks compilation of ESIMD slm_gather_rgba/slm_scatter_rgba APIs.
44
// Those which are deprecated must produce deprecation messages.
55

66
#include <sycl/ext/intel/experimental/esimd.hpp>
@@ -14,22 +14,22 @@ void caller() SYCL_ESIMD_FUNCTION {
1414

1515
slm_init(1024);
1616

17-
// CHECK: slm_load_store_rgba.cpp:19{{.*}}warning: 'ESIMD_ABGR_ENABLE' is deprecated
17+
// CHECK: slm_gather_scatter_rgba.cpp:19{{.*}}warning: 'ESIMD_ABGR_ENABLE' is deprecated
1818
// CHECK: sycl/ext/intel/experimental/esimd/common.hpp:{{.*}}note:
19-
auto v0 = slm_load_rgba<int, 32, ESIMD_ABGR_ENABLE>(offsets);
20-
v0 = slm_load_rgba<int, 32, rgba_channel_mask::ABGR>(offsets);
19+
auto v0 = slm_gather_rgba<int, 32, ESIMD_ABGR_ENABLE>(offsets);
20+
v0 = slm_gather_rgba<int, 32, rgba_channel_mask::ABGR>(offsets);
2121

2222
v0 = v0 + v1;
2323

24-
// CHECK: slm_load_store_rgba.cpp:26{{.*}}warning: 'ESIMD_ABGR_ENABLE' is deprecated
24+
// CHECK: slm_gather_scatter_rgba.cpp:26{{.*}}warning: 'ESIMD_ABGR_ENABLE' is deprecated
2525
// CHECK: sycl/ext/intel/experimental/esimd/common.hpp:{{.*}}note:
26-
slm_store_rgba<int, 32, ESIMD_ABGR_ENABLE>(v0, offsets);
27-
slm_store_rgba<int, 32, rgba_channel_mask::ABGR>(v0, offsets);
26+
slm_scatter_rgba<int, 32, ESIMD_ABGR_ENABLE>(v0, offsets);
27+
slm_scatter_rgba<int, 32, rgba_channel_mask::ABGR>(v0, offsets);
2828
}
2929

3030
// A "border" between host and device compilations
3131
// CHECK-LABEL: 2 warnings generated
32-
// CHECK: slm_load_store_rgba.cpp:19{{.*}}warning: 'ESIMD_ABGR_ENABLE' is deprecated
32+
// CHECK: slm_gather_scatter_rgba.cpp:19{{.*}}warning: 'ESIMD_ABGR_ENABLE' is deprecated
3333
// CHECK: sycl/ext/intel/experimental/esimd/common.hpp:{{.*}}note:
34-
// CHECK: slm_load_store_rgba.cpp:26{{.*}}warning: 'ESIMD_ABGR_ENABLE' is deprecated
34+
// CHECK: slm_gather_scatter_rgba.cpp:26{{.*}}warning: 'ESIMD_ABGR_ENABLE' is deprecated
3535
// CHECK: sycl/ext/intel/experimental/esimd/common.hpp:{{.*}}note:

0 commit comments

Comments
 (0)