@@ -28,14 +28,14 @@ To contribute:
28
28
29
29
- Create a personal fork of the project on GitHub
30
30
- Prepare your patch
31
- - follow [ LLVM coding standards] ( https://llvm.org/docs/CodingStandards.html )
32
- - [ clang -format] ( https://clang.llvm.org/docs/ClangFormat.html ) and
31
+ - Follow [ LLVM coding standards] ( https://llvm.org/docs/CodingStandards.html )
32
+ - [ Clang -format] ( https://clang.llvm.org/docs/ClangFormat.html ) and
33
33
[ clang-tidy] ( https://clang.llvm.org/extra/clang-tidy/ ) tools can be
34
34
integrated into your workflow to ensure formatting and stylistic
35
35
compliance of your changes. To avoid code formatting misalignment with
36
36
GitHub Actions check we recommend using 10 version of clang-format tool
37
37
(default version on Ubuntu 22.04).
38
- - use
38
+ - Use
39
39
40
40
``` bash
41
41
./clang/tools/clang-format/git-clang-format ` git merge-base origin/sycl HEAD`
@@ -78,19 +78,25 @@ To contribute:
78
78
79
79
- CI will run several build and functional testing checks as soon as the PR is
80
80
approved by an Intel representative.
81
+ - By default, pre-commit activies (build/test) will not auto start when PR
82
+ is submitted for new contributors and non members of the project. If your
83
+ PR shows " workflow awaiting approval" then your assigned code reviewer or
84
+ another member of the project will need to approve the test run and start
85
+ it for you. If you are unable to reach someone to approve your run, please
86
+ contact the project gatekeepers (@intel/llvm-gatekeepers).
81
87
- A new approval is needed if the PR was updated (e.g. during code review).
82
88
- Once the PR is approved and all checks have passed, the pull request is
83
89
ready for merge.
84
90
- Sometimes unrelated fails can be observed in the PR. It' s author
85
91
responsibility to find/guess the reason of these fails and post a comment in
86
92
the PR with:
87
- - possible reason of fails, ideally with a link to the PR, which caused fails
88
- - link to other PR(s), which expected to fix fails
89
- - person who is currently looking into fails
90
- - link to existing open issue
91
- - if author cannot identify any of these, the minimal action expected is to
93
+ - Possible reason of fails, ideally with a link to the PR, which caused fails
94
+ - Link to other PR(s), which expected to fix fails
95
+ - Person who is currently looking into fails
96
+ - Link to existing open issue
97
+ - If author cannot identify any of these, the minimal action expected is to
92
98
open a new [issue](/../../issues)
93
- - list of unrelated tests failing in pre-commit CI. This would enable easy
99
+ - List of unrelated tests failing in pre-commit CI. This would enable easy
94
100
access to them via github search functionality.
95
101
96
102
### Merge
0 commit comments