Skip to content

Commit 8fe0449

Browse files
committed
[RISCV] Fix required features checking with empty string
In our downstream, we define some intrinsics that don't require any extra extension enabled. Such as TARGET_BUILTIN(__builtin_riscv_xxx, "LiLi", "nc", "") But `split` function's `KeepEmpty` argument is True. Got the error message error: builtin requires at least one of the following extensions support to be enabled : '' when we use our customized intrinsic. Reviewed By: craig.topper, wangpc Differential Revision: https://reviews.llvm.org/D154596
1 parent 7a328cf commit 8fe0449

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

clang/lib/Sema/SemaChecking.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4481,7 +4481,7 @@ bool Sema::CheckRISCVBuiltinFunctionCall(const TargetInfo &TI,
44814481
bool FeatureMissing = false;
44824482
SmallVector<StringRef> ReqFeatures;
44834483
StringRef Features = Context.BuiltinInfo.getRequiredFeatures(BuiltinID);
4484-
Features.split(ReqFeatures, ',');
4484+
Features.split(ReqFeatures, ',', -1, false);
44854485

44864486
// Check if each required feature is included
44874487
for (StringRef F : ReqFeatures) {

0 commit comments

Comments
 (0)