Skip to content

Commit 900de46

Browse files
committed
[SYCL][NFC] Add a TODO comment promised during review of #4101
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
1 parent 306c8d6 commit 900de46

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

sycl/source/detail/reduction.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,10 @@ __SYCL_EXPORT uint32_t reduGetMaxNumConcurrentWorkGroups(
5555
std::shared_ptr<sycl::detail::queue_impl> Queue) {
5656
device Dev = Queue->get_device();
5757
uint32_t NumThreads = Dev.get_info<info::device::max_compute_units>();
58-
// The heuristics require additional tuning for various devices and vendors.
59-
// For now assuming that each of execution units have about 8 working threads
60-
// gives good results on some known/supported GPU devices.
58+
// TODO: The heuristics here require additional tuning for various devices
59+
// and vendors. For now this code assumes that execution units have about
60+
// 8 working threads, which gives good results on some known/supported
61+
// GPU devices.
6162
if (Dev.is_gpu())
6263
NumThreads *= 8;
6364
return NumThreads;

0 commit comments

Comments
 (0)