Skip to content

Commit 923a6e6

Browse files
vladimirlazbader
andauthored
Apply suggestions from code review
Co-authored-by: Alexey Bader <[email protected]>
1 parent 3a4da9f commit 923a6e6

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ for more information.
2222

2323
**NB**: A change in compiler and runtime should be accompanied with
2424
corresponding test change.
25-
See [DPC++ test toolchain](sycl/doc/GetStartedGuide.md#test-dpc-toolchain)
26-
for more information.
25+
See [Test DPC++ toolchain](sycl/doc/GetStartedGuide.md#test-dpc-toolchain)
26+
section of Get Started guide for more information.
2727

2828
**Note (October, 2020)**: DPC++ runtime and compiler ABI is currently in frozen
2929
state. This means that no ABI-breaking changes will be accepted by default.

sycl/doc/GetStartedGuide.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ command:
281281
### Test DPC++ toolchain
282282
283283
There are 3 types of tests which are used for DPC++ toolchain validation:
284-
* DPC++ in-source LIT tests including [check-llvm](../../llvm/test),
284+
* DPC++ in-tree LIT tests including [check-llvm](../../llvm/test),
285285
[check-clang](../../clang/test), [check-llvm-spirv](../../llvm-spirv/test) and
286286
[check-sycl](../../sycl/test) targets stored in this repository. These tests
287287
should be not have hardware or external software dependencies (e.g OpenCL,
@@ -294,7 +294,7 @@ These tests cover full DPC++ stack including all dependencies (e.g. OpenCL,
294294
Level Zero, CUDA runtimes).
295295
296296
* SYCL-CTS are official [Khronos\* SYCL\* conformance tests](https://github.com/KhronosGroup/SYCL-CTS).
297-
They verify SYCL 1.2.1 specification compatibility. All implementation details
297+
They verify SYCL specification compatibility. All implementation details
298298
or extensions are out of scope for the tests.
299299
300300
#### Contribution to DPC++ tests
@@ -304,7 +304,7 @@ Every product change should be accompanied with corresponding test modification
304304
The test location is selected depending on test nature:
305305
306306
- A test which depends only on tools and libraries produced during build of
307-
the repository can be put to in-source LIT. Also the tests for a feature under
307+
the repository can be put to in-tree LIT. Also the tests for a feature under
308308
active development requiring atomic change for tests and product can be put to
309309
[sycl/test/on-device](../../sycl/test/on-device) temporarily. It is developer
310310
responsibility to move the tests to DPC++ E2E test suite once feature is
@@ -321,8 +321,6 @@ built with DPC++ compiler (defined in
321321
pull request should be created under
322322
[KhronosGroup/SYCL-CTS](https://github.com/KhronosGroup/SYCL-CTS) with required
323323
patch.
324-
325-
326324
#### Run in-source LIT tests
327325
328326
To verify that built DPC++ toolchain is working correctly, run:

0 commit comments

Comments
 (0)