Skip to content

Commit 9378081

Browse files
committed
[XPTIFW] Minor doc changes + include reordering
Signed-off-by: Vasanth Tovinkere <[email protected]>
1 parent dbc83eb commit 9378081

File tree

6 files changed

+17
-15
lines changed

6 files changed

+17
-15
lines changed

xptifw/basic_test/performance_tests.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@
1010
// scenarios and computing the average costs and maximum Events/sec that can
1111
// be serviced by the framework at a given max. overhead constraint.
1212
//---------------------------------------------------------------------------
13-
#include <atomic>
14-
#include <chrono>
15-
#include <random>
16-
1713
#include "tbb/concurrent_vector.h"
1814
#include "tbb/parallel_for.h"
1915
#include "tbb/spin_mutex.h"
@@ -23,6 +19,10 @@
2319
#include "cl_processor.hpp"
2420
#include "xpti_trace_framework.h"
2521

22+
#include <atomic>
23+
#include <chrono>
24+
#include <random>
25+
2626
namespace test {
2727
void registerCallbacks(uint8_t sid);
2828
namespace performance {

xptifw/basic_test/semantic_tests.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@
99
// Tests the correctness of the API by comparing it agains the spec and
1010
// expected results.
1111
//--------------------------------------------------------------------------
12-
#include <atomic>
13-
#include <chrono>
14-
#include <random>
15-
1612
#include "tbb/concurrent_vector.h"
1713
#include "tbb/parallel_for.h"
1814
#include "tbb/spin_mutex.h"
@@ -22,6 +18,10 @@
2218
#include "cl_processor.hpp"
2319
#include "xpti_trace_framework.h"
2420

21+
#include <atomic>
22+
#include <chrono>
23+
#include <random>
24+
2525
static void tpCallback(uint16_t trace_type, xpti::trace_event_data_t *parent,
2626
xpti::trace_event_data_t *event, uint64_t instance,
2727
const void *ud) {}

xptifw/doc/XPTI_Framework.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,10 @@ below.
281281
the performance of the framework in detail in the sections [Performance of the Framework](#performance-of-the-framework) and [Modeling and projection](#modeling-and-projection). For details on the command line arguments,
282282
please refer to these sections.
283283

284+
> **NOTE:** These tests rely on the availability of TBB for creating the
285+
multi-threaded tests and will not be created if TBB has not been enabled
286+
during the build process.
287+
284288
```bash
285289
% <xptifw-dir>/lib/Release/run_test --trace-points 1000 --type performance --overhead 1.5 --num-threads 0,1,2,3 --test-id 1,2 --tp-frequency 50
286290
```

xptifw/samples/basic_collector/basic_collector.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//
8+
#include "xpti_timers.hpp"
9+
#include "xpti_trace_framework.h"
10+
811
#include <chrono>
912
#include <iostream>
1013
#include <map>
@@ -14,9 +17,6 @@
1417
#include <thread>
1518
#include <unordered_map>
1619

17-
#include "xpti_timers.hpp"
18-
#include "xpti_trace_framework.h"
19-
2020
static uint8_t GStreamID = 0;
2121
std::mutex GIOMutex;
2222
xpti::ThreadID GThreadIDEnum;

xptifw/unit_test/xpti_api_tests.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,10 @@
55
//
66
#include "xpti_trace_framework.hpp"
77

8+
#include <gtest/gtest.h>
89
#include <iostream>
910
#include <set>
1011

11-
#include <gtest/gtest.h>
12-
1312
TEST(xptiApiTest, xptiInitializeBadInput) {
1413
auto Result = xptiInitialize(nullptr, 0, 0, nullptr);
1514
EXPECT_EQ(Result, xpti::result_t::XPTI_RESULT_INVALIDARG);

xptifw/unit_test/xpti_correctness_tests.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,10 @@
66
#include "xpti_trace_framework.h"
77
#include "xpti_trace_framework.hpp"
88

9+
#include <gtest/gtest.h>
910
#include <iostream>
1011
#include <set>
1112

12-
#include <gtest/gtest.h>
13-
1413
XPTI_CALLBACK_API void tpCallback(uint16_t trace_type,
1514
xpti::trace_event_data_t *parent,
1615
xpti::trace_event_data_t *event,

0 commit comments

Comments
 (0)