Skip to content

Commit 9a4c3b6

Browse files
committed
fix test failures, remove duplicated string from deprecation message
Signed-off-by: kbobrovs <[email protected]>
1 parent 6f6752c commit 9a4c3b6

File tree

2 files changed

+20
-16
lines changed

2 files changed

+20
-16
lines changed

sycl/include/CL/sycl/INTEL/esimd/esimd.hpp

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -503,9 +503,10 @@ template <typename Ty, int N> class simd {
503503
/// @param acc accessor to copy from.
504504
/// @param offset offset to copy from.
505505
template <typename AccessorT>
506-
ESIMD_INLINE EnableIfAccessor<AccessorT, accessor_mode_cap::can_read,
507-
sycl::access::target::global_buffer, void>
508-
copy_from(AccessorT acc, uint32_t offset) SYCL_ESIMD_FUNCTION;
506+
ESIMD_INLINE
507+
detail::EnableIfAccessor<AccessorT, detail::accessor_mode_cap::can_read,
508+
sycl::access::target::global_buffer, void>
509+
copy_from(AccessorT acc, uint32_t offset) SYCL_ESIMD_FUNCTION;
509510

510511
/// Copy all vector elements of this object into a contiguous block in memory.
511512
/// @param addr the memory address to copy to. Must be a pointer to the
@@ -518,9 +519,10 @@ template <typename Ty, int N> class simd {
518519
/// @param acc accessor to copy from.
519520
/// @param offset offset to copy from.
520521
template <typename AccessorT>
521-
ESIMD_INLINE EnableIfAccessor<AccessorT, accessor_mode_cap::can_write,
522-
sycl::access::target::global_buffer, void>
523-
copy_to(AccessorT acc, uint32_t offset) SYCL_ESIMD_FUNCTION;
522+
ESIMD_INLINE
523+
detail::EnableIfAccessor<AccessorT, detail::accessor_mode_cap::can_write,
524+
sycl::access::target::global_buffer, void>
525+
copy_to(AccessorT acc, uint32_t offset) SYCL_ESIMD_FUNCTION;
524526

525527
/// @} // Memory operations
526528
private:
@@ -562,9 +564,10 @@ template <typename T, int N> void simd<T, N>::copy_from(const T *const Addr) {
562564

563565
template <typename T, int N>
564566
template <typename AccessorT>
565-
ESIMD_INLINE EnableIfAccessor<AccessorT, accessor_mode_cap::can_read,
566-
sycl::access::target::global_buffer, void>
567-
simd<T, N>::copy_from(AccessorT acc, uint32_t offset) {
567+
ESIMD_INLINE
568+
detail::EnableIfAccessor<AccessorT, detail::accessor_mode_cap::can_read,
569+
sycl::access::target::global_buffer, void>
570+
simd<T, N>::copy_from(AccessorT acc, uint32_t offset) {
568571
constexpr unsigned Sz = sizeof(T) * N;
569572
static_assert(Sz >= detail::OperandSize::OWORD,
570573
"block size must be at least 1 oword");
@@ -600,9 +603,10 @@ template <typename T, int N> void simd<T, N>::copy_to(T *addr) {
600603

601604
template <typename T, int N>
602605
template <typename AccessorT>
603-
ESIMD_INLINE EnableIfAccessor<AccessorT, accessor_mode_cap::can_write,
604-
sycl::access::target::global_buffer, void>
605-
simd<T, N>::copy_to(AccessorT acc, uint32_t offset) {
606+
ESIMD_INLINE
607+
detail::EnableIfAccessor<AccessorT, detail::accessor_mode_cap::can_write,
608+
sycl::access::target::global_buffer, void>
609+
simd<T, N>::copy_to(AccessorT acc, uint32_t offset) {
606610
constexpr unsigned Sz = sizeof(T) * N;
607611
static_assert(Sz >= detail::OperandSize::OWORD,
608612
"block size must be at least 1 oword");

sycl/include/CL/sycl/INTEL/esimd/esimd_memory.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ scatter(T *p, simd<T, n * ElemsPerAddr> vals, simd<uint32_t, n> offsets,
166166
// This API, even though deprecated, can't be removed until then.
167167
template <typename T, int n, CacheHint L1H = CacheHint::None,
168168
CacheHint L3H = CacheHint::None>
169-
__SYCL_DEPRECATED("block_load is deprecated, use simd::copy_from.")
169+
__SYCL_DEPRECATED("use simd::copy_from.")
170170
ESIMD_INLINE ESIMD_NODEBUG simd<T, n> block_load(const T *const addr) {
171171
constexpr unsigned Sz = sizeof(T) * n;
172172
static_assert(Sz >= detail::OperandSize::OWORD,
@@ -185,7 +185,7 @@ ESIMD_INLINE ESIMD_NODEBUG simd<T, n> block_load(const T *const addr) {
185185
/// Accessor-based block-load.
186186
/// \ingroup sycl_esimd
187187
template <typename T, int n, typename AccessorTy>
188-
__SYCL_DEPRECATED("block_load is deprecated, use simd::copy_from.")
188+
__SYCL_DEPRECATED("use simd::copy_from.")
189189
ESIMD_INLINE ESIMD_NODEBUG simd<T, n> block_load(AccessorTy acc,
190190
uint32_t offset) {
191191
simd<T, n> Res;
@@ -198,7 +198,7 @@ ESIMD_INLINE ESIMD_NODEBUG simd<T, n> block_load(AccessorTy acc,
198198
// TODO the above note about cache hints applies to this API as well.
199199
template <typename T, int n, CacheHint L1H = CacheHint::None,
200200
CacheHint L3H = CacheHint::None>
201-
__SYCL_DEPRECATED("block_store is deprecated, use simd::copy_to.")
201+
__SYCL_DEPRECATED("use simd::copy_to.")
202202
ESIMD_INLINE ESIMD_NODEBUG void block_store(T *p, simd<T, n> vals) {
203203
constexpr unsigned Sz = sizeof(T) * n;
204204
static_assert(Sz >= detail::OperandSize::OWORD,
@@ -217,7 +217,7 @@ ESIMD_INLINE ESIMD_NODEBUG void block_store(T *p, simd<T, n> vals) {
217217
/// Accessor-based block-store.
218218
/// \ingroup sycl_esimd
219219
template <typename T, int n, typename AccessorTy>
220-
__SYCL_DEPRECATED("block_store is deprecated, use simd::copy_to.")
220+
__SYCL_DEPRECATED("use simd::copy_to.")
221221
ESIMD_INLINE ESIMD_NODEBUG
222222
void block_store(AccessorTy acc, uint32_t offset, simd<T, n> vals) {
223223
vals.copy_to(acc, offset);

0 commit comments

Comments
 (0)