Skip to content

Commit 9b167ab

Browse files
committed
Fix subsequent build failure
1 parent 39c4df8 commit 9b167ab

File tree

4 files changed

+15
-3
lines changed

4 files changed

+15
-3
lines changed

sycl/include/CL/sycl/detail/kernel_desc.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ enum class kernel_param_kind_t {
2727
kind_std_layout = 1, // standard layout object parameters
2828
kind_sampler = 2,
2929
kind_pointer = 3,
30-
kind_specialization_constants_buffer = 4
30+
kind_specialization_constants_buffer = 4,
3131
};
3232

3333
// describes a kernel parameter

sycl/include/CL/sycl/specialization_id.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@ template <typename T> class specialization_id {
2020

2121
template <class... Args>
2222
explicit constexpr specialization_id(Args &&... args)
23-
: MSpecializationConstantValue(std::forward<Args>(args)...) {}
23+
: MDefaultValue(std::forward<Args>(args)...) {}
2424

2525
specialization_id(const specialization_id &rhs) = delete;
2626
specialization_id(specialization_id &&rhs) = delete;
2727
specialization_id &operator=(const specialization_id &rhs) = delete;
2828
specialization_id &operator=(specialization_id &&rhs) = delete;
2929

3030
private:
31-
T MSpecializationConstantValue;
31+
T MDefaultValue;
3232
};
3333

3434
} // namespace sycl

sycl/source/detail/scheduler/commands.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,6 +1695,12 @@ pi_result ExecCGCommand::SetKernelParamsAndLaunch(
16951695
Arg.MSize, Arg.MPtr);
16961696
break;
16971697
}
1698+
case kernel_param_kind_t::kind_specialization_constants_buffer: {
1699+
throw cl::sycl::feature_not_supported(
1700+
"Specialization constants are not yet fully supported",
1701+
PI_INVALID_OPERATION);
1702+
break;
1703+
}
16981704
}
16991705
++NextTrueIndex;
17001706
}

sycl/source/handler.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,12 @@ void handler::processArg(void *Ptr, const detail::kernel_param_kind_t &Kind,
236236
Index + IndexShift);
237237
break;
238238
}
239+
case kernel_param_kind_t::kind_specialization_constants_buffer: {
240+
throw cl::sycl::feature_not_supported(
241+
"Specialization constants are not yet fully supported",
242+
PI_INVALID_OPERATION);
243+
break;
244+
}
239245
}
240246
}
241247

0 commit comments

Comments
 (0)