Skip to content

Commit 9c60d80

Browse files
committed
Apply CR comments
1 parent f92ccfe commit 9c60d80

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

sycl/include/CL/sycl/handler.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ class __SYCL_EXPORT handler {
498498
LambdaArgType>() &&
499499
MIsHost) {
500500
throw cl::sycl::feature_not_supported(
501-
"kernel_handler is not supported by host device.",
501+
"kernel_handler is not yet supported by host device.",
502502
PI_INVALID_OPERATION);
503503
}
504504
MHostKernel.reset(

sycl/include/CL/sycl/kernel_handler.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class kernel_handler {
3333
return getSpecializationConstantOnDevice<S>();
3434
#else
3535
throw cl::sycl::feature_not_supported(
36-
"kernel_handler::get_specialization_constant() is not supported by "
36+
"kernel_handler::get_specialization_constant() is not yet supported by "
3737
"host device.",
3838
PI_INVALID_OPERATION);
3939
#endif // __SYCL_DEVICE_ONLY__

sycl/include/CL/sycl/specialization_id.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ template <typename T> class specialization_id {
2020

2121
template <class... Args>
2222
explicit constexpr specialization_id(Args &&... args)
23-
: MSpecializationConstantValue(args...) {}
23+
: MSpecializationConstantValue(std::forward<Args>(args)...) {}
2424

2525
specialization_id(const specialization_id &rhs) = delete;
2626
specialization_id(specialization_id &&rhs) = delete;

sycl/test/on-device/basic_tests/specialization_constants/kernel_lambda_with_kernel_handler_arg.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
22
// RUN: %t.out
33

4+
// This test checks all possible scenarios of running single_task, parallel_for
5+
// and parallel_for_work_group to verify that this code compiles and runs
6+
// correctly with user's lambda with and without sycl::kernel_handler argument
7+
48
#include <CL/sycl.hpp>
59

610
int main() {

0 commit comments

Comments
 (0)