Skip to content

Commit a56f449

Browse files
author
Alexander Batashev
committed
Fix warnings
Signed-off-by: Alexander Batashev <[email protected]>
1 parent 405fd60 commit a56f449

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

sycl/include/CL/sycl/detail/image_impl.hpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ template <int Dimensions> class image_impl final : public SYCLMemObjT {
192192
size_t get_count() const { return MRange.size(); }
193193

194194
void *allocateMem(ContextImplPtr Context, bool InitFromUserData,
195-
void *HostPtr, RT::PiEvent &OutEventToWait);
195+
void *HostPtr, RT::PiEvent &OutEventToWait) override;
196196

197197
MemObjType getType() const override { return MemObjType::IMAGE; }
198198

@@ -288,10 +288,6 @@ template <int Dimensions> class image_impl final : public SYCLMemObjT {
288288
size_t MRowPitch = 0;
289289
size_t MSlicePitch = 0;
290290
};
291-
292-
template class image_impl<1>;
293-
template class image_impl<2>;
294-
template class image_impl<3>;
295291
} // namespace detail
296292
} // namespace sycl
297293
} // namespace cl

sycl/include/CL/sycl/detail/sycl_mem_obj_i.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ using ContextImplPtr = std::shared_ptr<detail::context_impl>;
2828
// objects.
2929
class SYCLMemObjI {
3030
public:
31+
virtual ~SYCLMemObjI() = default;
32+
3133
enum MemObjType { BUFFER, IMAGE };
3234

3335
virtual MemObjType getType() const = 0;

sycl/source/detail/image_impl.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,10 @@ image_impl<Dimensions>::image_impl(cl_mem MemObject, const context &SyclContext,
258258
switch (Dimensions) {
259259
case 3:
260260
getImageInfo(PI_IMAGE_INFO_DEPTH, MRange[2]);
261+
// fall through
261262
case 2:
262263
getImageInfo(PI_IMAGE_INFO_HEIGHT, MRange[1]);
264+
// fall through
263265
case 1:
264266
getImageInfo(PI_IMAGE_INFO_WIDTH, MRange[0]);
265267
}
@@ -401,6 +403,11 @@ bool image_impl<Dimensions>::checkImageFormat(
401403

402404
return true;
403405
}
406+
407+
template class image_impl<1>;
408+
template class image_impl<2>;
409+
template class image_impl<3>;
410+
404411
} // namespace detail
405412
} // namespace sycl
406413
} // namespace cl

0 commit comments

Comments
 (0)