Skip to content

Commit a82004b

Browse files
Revert "[SYCL] Link and include LLVMSupport in SYCL library" (#18572)
Reverts #16763 - Turns out UCRT is causing a problem for this on Windows. We need #18200 before we can reintroduce it.
1 parent 5424b11 commit a82004b

File tree

15 files changed

+90
-96
lines changed

15 files changed

+90
-96
lines changed

sycl/source/CMakeLists.txt

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,15 @@ function(add_sycl_rt_library LIB_NAME LIB_OBJ_NAME)
9191

9292
# Feature-specific compilation and link step setup
9393

94+
# Unlike for sycl library, for LLVMSupport we have only one version for a given build,
95+
# so, we link LLVMSupport lib to matching sycl version only.
9496
if (SYCL_ENABLE_STACK_PRINTING)
95-
target_compile_definitions(${LIB_OBJ_NAME} PUBLIC ENABLE_STACK_TRACE)
97+
if(NOT MSVC OR (CMAKE_BUILD_TYPE STREQUAL "Debug" AND ARG_COMPILE_OPTIONS MATCHES ".*MDd.*") OR
98+
(NOT CMAKE_BUILD_TYPE STREQUAL "Debug" AND NOT ARG_COMPILE_OPTIONS MATCHES ".*MDd.*"))
99+
add_dependencies(${LIB_NAME} LLVMSupport)
100+
target_compile_definitions(${LIB_OBJ_NAME} PUBLIC ENABLE_STACK_TRACE)
101+
target_link_libraries(${LIB_NAME} PRIVATE LLVMSupport)
102+
endif()
96103
endif()
97104

98105
# TODO: Enabled for MSVC
@@ -186,11 +193,6 @@ function(add_sycl_rt_library LIB_NAME LIB_OBJ_NAME)
186193
endif()
187194
endif()
188195

189-
# Link with LLVMSupport for shared utilities.
190-
add_dependencies(${LIB_NAME} LLVMSupport)
191-
target_link_libraries(${LIB_NAME} PRIVATE LLVMSupport)
192-
target_include_directories(${LIB_OBJ_NAME} SYSTEM PRIVATE ${LLVM_MAIN_INCLUDE_DIR})
193-
194196
check_linker_flag(CXX "-Wl,--gc-sections" LINKER_SUPPORTS_WL_GC_SECTIONS)
195197
if(LINKER_SUPPORTS_WL_GC_SECTIONS)
196198
# Reduces the size of the resulting library by having the linker perform

sycl/source/detail/compiler.hpp

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,45 @@
3535
#define __SYCL_DEVICE_BINARY_TARGET_LLVM_NVPTX64 "llvm_nvptx64"
3636
#define __SYCL_DEVICE_BINARY_TARGET_LLVM_AMDGCN "llvm_amdgcn"
3737

38+
/// Device binary image property set names recognized by the SYCL runtime.
39+
/// Name must be consistent with
40+
/// PropertySetRegistry::SYCL_SPECIALIZATION_CONSTANTS defined in
41+
/// PropertySetIO.h
42+
#define __SYCL_PROPERTY_SET_SPEC_CONST_MAP "SYCL/specialization constants"
43+
/// PropertySetRegistry::SYCL_SPEC_CONSTANTS_DEFAULT_VALUES defined in
44+
/// PropertySetIO.h
45+
#define __SYCL_PROPERTY_SET_SPEC_CONST_DEFAULT_VALUES_MAP \
46+
"SYCL/specialization constants default values"
47+
/// TODO: remove req mask when sycl devicelib online linking path is removed.
48+
/// PropertySetRegistry::SYCL_DEVICELIB_REQ_MASK defined in PropertySetIO.h
49+
#define __SYCL_PROPERTY_SET_DEVICELIB_REQ_MASK "SYCL/devicelib req mask"
50+
/// PropertySetRegistry::SYCL_DEVICELIB_METADATA defined in PropertySetIO.h
51+
#define __SYCL_PROPERTY_SET_DEVICELIB_METADATA "SYCL/devicelib metadata"
52+
/// PropertySetRegistry::SYCL_KERNEL_PARAM_OPT_INFO defined in PropertySetIO.h
53+
#define __SYCL_PROPERTY_SET_KERNEL_PARAM_OPT_INFO "SYCL/kernel param opt"
54+
/// PropertySetRegistry::SYCL_KERNEL_PROGRAM_METADATA defined in PropertySetIO.h
55+
#define __SYCL_PROPERTY_SET_PROGRAM_METADATA "SYCL/program metadata"
56+
/// PropertySetRegistry::SYCL_MISC_PROP defined in PropertySetIO.h
57+
#define __SYCL_PROPERTY_SET_SYCL_MISC_PROP "SYCL/misc properties"
58+
/// PropertySetRegistry::SYCL_ASSERT_USED defined in PropertySetIO.h
59+
#define __SYCL_PROPERTY_SET_SYCL_ASSERT_USED "SYCL/assert used"
60+
/// PropertySetRegistry::SYCL_EXPORTED_SYMBOLS defined in PropertySetIO.h
61+
#define __SYCL_PROPERTY_SET_SYCL_EXPORTED_SYMBOLS "SYCL/exported symbols"
62+
/// PropertySetRegistry::SYCL_IMPORTED_SYMBOLS defined in PropertySetIO.h
63+
#define __SYCL_PROPERTY_SET_SYCL_IMPORTED_SYMBOLS "SYCL/imported symbols"
64+
/// PropertySetRegistry::SYCL_DEVICE_GLOBALS defined in PropertySetIO.h
65+
#define __SYCL_PROPERTY_SET_SYCL_DEVICE_GLOBALS "SYCL/device globals"
66+
/// PropertySetRegistry::SYCL_DEVICE_REQUIREMENTS defined in PropertySetIO.h
67+
#define __SYCL_PROPERTY_SET_SYCL_DEVICE_REQUIREMENTS "SYCL/device requirements"
68+
/// PropertySetRegistry::SYCL_HOST_PIPES defined in PropertySetIO.h
69+
#define __SYCL_PROPERTY_SET_SYCL_HOST_PIPES "SYCL/host pipes"
70+
/// PropertySetRegistry::SYCL_VIRTUAL_FUNCTIONS defined in PropertySetIO.h
71+
#define __SYCL_PROPERTY_SET_SYCL_VIRTUAL_FUNCTIONS "SYCL/virtual functions"
72+
/// PropertySetRegistry::SYCL_IMPLICIT_LOCAL_ARG defined in PropertySetIO.h
73+
#define __SYCL_PROPERTY_SET_SYCL_IMPLICIT_LOCAL_ARG "SYCL/implicit local arg"
74+
/// PropertySetRegistry::SYCL_REGISTERED_KERNELS defined in PropertySetIO.h
75+
#define __SYCL_PROPERTY_SET_SYCL_REGISTERED_KERNELS "SYCL/registered kernels"
76+
3877
/// Program metadata tags recognized by the PI backends. For kernels the tag
3978
/// must appear after the kernel name.
4079
#define __SYCL_PROGRAM_METADATA_TAG_REQD_WORK_GROUP_SIZE "@reqd_work_group_size"

sycl/source/detail/device_binary_image.cpp

Lines changed: 16 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
// For device image compression.
1313
#include <detail/compression.hpp>
1414

15-
#include <llvm/Support/PropertySetIO.h>
16-
1715
#include <algorithm>
1816
#include <cstdlib>
1917
#include <cstring>
@@ -187,39 +185,28 @@ void RTDeviceBinaryImage::init(sycl_device_binary Bin) {
187185
// try to determine the format; may remain "NONE"
188186
Format = ur::getBinaryImageFormat(Bin->BinaryStart, getSize());
189187

190-
SpecConstIDMap.init(
191-
Bin, llvm::util::PropertySetRegistry::SYCL_SPECIALIZATION_CONSTANTS);
188+
SpecConstIDMap.init(Bin, __SYCL_PROPERTY_SET_SPEC_CONST_MAP);
192189
SpecConstDefaultValuesMap.init(
193-
Bin, llvm::util::PropertySetRegistry::SYCL_SPEC_CONSTANTS_DEFAULT_VALUES);
194-
DeviceLibReqMask.init(
195-
Bin, llvm::util::PropertySetRegistry::SYCL_DEVICELIB_REQ_MASK);
196-
DeviceLibMetadata.init(
197-
Bin, llvm::util::PropertySetRegistry::SYCL_DEVICELIB_METADATA);
198-
KernelParamOptInfo.init(
199-
Bin, llvm::util::PropertySetRegistry::SYCL_KERNEL_PARAM_OPT_INFO);
200-
AssertUsed.init(Bin, llvm::util::PropertySetRegistry::SYCL_ASSERT_USED);
201-
ImplicitLocalArg.init(
202-
Bin, llvm::util::PropertySetRegistry::SYCL_IMPLICIT_LOCAL_ARG);
203-
ProgramMetadata.init(Bin,
204-
llvm::util::PropertySetRegistry::SYCL_PROGRAM_METADATA);
190+
Bin, __SYCL_PROPERTY_SET_SPEC_CONST_DEFAULT_VALUES_MAP);
191+
DeviceLibReqMask.init(Bin, __SYCL_PROPERTY_SET_DEVICELIB_REQ_MASK);
192+
DeviceLibMetadata.init(Bin, __SYCL_PROPERTY_SET_DEVICELIB_METADATA);
193+
KernelParamOptInfo.init(Bin, __SYCL_PROPERTY_SET_KERNEL_PARAM_OPT_INFO);
194+
AssertUsed.init(Bin, __SYCL_PROPERTY_SET_SYCL_ASSERT_USED);
195+
ImplicitLocalArg.init(Bin, __SYCL_PROPERTY_SET_SYCL_IMPLICIT_LOCAL_ARG);
196+
ProgramMetadata.init(Bin, __SYCL_PROPERTY_SET_PROGRAM_METADATA);
205197
// Convert ProgramMetadata into the UR format
206198
for (const auto &Prop : ProgramMetadata) {
207199
ProgramMetadataUR.push_back(
208200
ur::mapDeviceBinaryPropertyToProgramMetadata(Prop));
209201
}
210-
ExportedSymbols.init(Bin,
211-
llvm::util::PropertySetRegistry::SYCL_EXPORTED_SYMBOLS);
212-
ImportedSymbols.init(Bin,
213-
llvm::util::PropertySetRegistry::SYCL_IMPORTED_SYMBOLS);
214-
DeviceGlobals.init(Bin, llvm::util::PropertySetRegistry::SYCL_DEVICE_GLOBALS);
215-
DeviceRequirements.init(
216-
Bin, llvm::util::PropertySetRegistry::SYCL_DEVICE_REQUIREMENTS);
217-
HostPipes.init(Bin, llvm::util::PropertySetRegistry::SYCL_HOST_PIPES);
218-
VirtualFunctions.init(
219-
Bin, llvm::util::PropertySetRegistry::SYCL_VIRTUAL_FUNCTIONS);
220-
RegisteredKernels.init(
221-
Bin, llvm::util::PropertySetRegistry::SYCL_REGISTERED_KERNELS);
222-
Misc.init(Bin, llvm::util::PropertySetRegistry::SYCL_MISC_PROP);
202+
ExportedSymbols.init(Bin, __SYCL_PROPERTY_SET_SYCL_EXPORTED_SYMBOLS);
203+
ImportedSymbols.init(Bin, __SYCL_PROPERTY_SET_SYCL_IMPORTED_SYMBOLS);
204+
DeviceGlobals.init(Bin, __SYCL_PROPERTY_SET_SYCL_DEVICE_GLOBALS);
205+
DeviceRequirements.init(Bin, __SYCL_PROPERTY_SET_SYCL_DEVICE_REQUIREMENTS);
206+
HostPipes.init(Bin, __SYCL_PROPERTY_SET_SYCL_HOST_PIPES);
207+
VirtualFunctions.init(Bin, __SYCL_PROPERTY_SET_SYCL_VIRTUAL_FUNCTIONS);
208+
RegisteredKernels.init(Bin, __SYCL_PROPERTY_SET_SYCL_REGISTERED_KERNELS);
209+
Misc.init(Bin, __SYCL_PROPERTY_SET_SYCL_MISC_PROP);
223210
}
224211

225212
std::atomic<uintptr_t> RTDeviceBinaryImage::ImageCounter = 1;

sycl/source/detail/jit_compiler.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
#include <sycl/detail/os_util.hpp>
1313
#include <sycl/detail/ur.hpp>
1414

15-
#include <llvm/Support/PropertySetIO.h>
16-
1715
namespace sycl {
1816
inline namespace _V1 {
1917
namespace detail {
@@ -267,7 +265,7 @@ sycl_device_binaries jit_compiler::createDeviceBinaries(
267265

268266
for (const auto &FPS : DevImgInfo.Properties) {
269267
bool IsDeviceGlobalsPropSet =
270-
FPS.Name == llvm::util::PropertySetRegistry::SYCL_DEVICE_GLOBALS;
268+
FPS.Name == __SYCL_PROPERTY_SET_SYCL_DEVICE_GLOBALS;
271269
PropertySetContainer PropSet{FPS.Name.c_str()};
272270
for (const auto &FPV : FPS.Values) {
273271
if (FPV.IsUIntValue) {

sycl/source/detail/program_manager/program_manager.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@
3434

3535
#include <sycl/ext/oneapi/matrix/query-types.hpp>
3636

37-
#include <llvm/Support/PropertySetIO.h>
38-
3937
#include <algorithm>
4038
#include <cassert>
4139
#include <cstdint>
@@ -1865,8 +1863,7 @@ static bool isBfloat16DeviceLibImage(sycl_device_binary RawImg,
18651863
for (ImgPS = RawImg->PropertySetsBegin; ImgPS != RawImg->PropertySetsEnd;
18661864
++ImgPS) {
18671865
if (ImgPS->Name &&
1868-
!strcmp(llvm::util::PropertySetRegistry::SYCL_DEVICELIB_METADATA,
1869-
ImgPS->Name)) {
1866+
!strcmp(__SYCL_PROPERTY_SET_DEVICELIB_METADATA, ImgPS->Name)) {
18701867
if (!LibVersion)
18711868
return true;
18721869

@@ -1894,8 +1891,7 @@ getExportedSymbolPS(sycl_device_binary RawImg) {
18941891
for (ImgPS = RawImg->PropertySetsBegin; ImgPS != RawImg->PropertySetsEnd;
18951892
++ImgPS) {
18961893
if (ImgPS->Name &&
1897-
!strcmp(llvm::util::PropertySetRegistry::SYCL_EXPORTED_SYMBOLS,
1898-
ImgPS->Name))
1894+
!strcmp(__SYCL_PROPERTY_SET_SYCL_EXPORTED_SYMBOLS, ImgPS->Name))
18991895
return ImgPS;
19001896
}
19011897

sycl/test/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ set(SYCL_THREADS_LIB ${CMAKE_THREAD_LIBS_INIT})
1616
# TEST_INCLUDE_PATH is used for syntax-only verification of type information.
1717
list(APPEND test_includes ${SYCL_INCLUDE})
1818
list(APPEND test_includes ${SYCL_SOURCE_DIR}/source)
19-
list(APPEND test_includes ${LLVM_MAIN_INCLUDE_DIR})
2019
list(APPEND test_includes ${BOOST_UNORDERED_INCLUDE_DIRS})
2120
if(SYCL_ENABLE_EXTENSION_JIT)
2221
list(APPEND test_includes ${LLVM_EXTERNAL_SYCL_JIT_SOURCE_DIR}/jit-compiler/include)

sycl/unittests/Extensions/DeviceGlobal.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
#include <sycl/sycl.hpp>
1010

11-
#include <llvm/Support/PropertySetIO.h>
12-
1311
#include "detail/context_impl.hpp"
1412
#include "detail/kernel_program_cache.hpp"
1513

@@ -66,7 +64,7 @@ static sycl::unittest::MockDeviceImage generateDeviceGlobalImage() {
6664
MockPropertySet PropSet;
6765
MockProperty DevGlobInfo =
6866
makeDeviceGlobalInfo(DeviceGlobalName, sizeof(int) * 2, 0);
69-
PropSet.insert(llvm::util::PropertySetRegistry::SYCL_DEVICE_GLOBALS,
67+
PropSet.insert(__SYCL_PROPERTY_SET_SYCL_DEVICE_GLOBALS,
7068
std::vector<MockProperty>{std::move(DevGlobInfo)});
7169

7270
std::vector<MockOffloadEntry> Entries =
@@ -89,7 +87,7 @@ static sycl::unittest::MockDeviceImage generateDeviceGlobalImgScopeImage() {
8987
MockPropertySet PropSet;
9088
MockProperty DevGlobInfo =
9189
makeDeviceGlobalInfo(DeviceGlobalImgScopeName, sizeof(int) * 2, 1);
92-
PropSet.insert(llvm::util::PropertySetRegistry::SYCL_DEVICE_GLOBALS,
90+
PropSet.insert(__SYCL_PROPERTY_SET_SYCL_DEVICE_GLOBALS,
9391
std::vector<MockProperty>{std::move(DevGlobInfo)});
9492

9593
std::vector<MockOffloadEntry> Entries =

sycl/unittests/Extensions/VirtualFunctions/RuntimeLinking.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
#include "ur_mock_helpers.hpp"
33
#include <sycl/sycl.hpp>
44

5-
#include <llvm/Support/PropertySetIO.h>
6-
75
#include <helpers/MockDeviceImage.hpp>
86
#include <helpers/MockKernelInfo.hpp>
97
#include <helpers/RuntimeLinkingCommon.hpp>
@@ -67,8 +65,7 @@ generateImage(std::initializer_list<std::string> KernelNames,
6765
SYCL_PROPERTY_TYPE_BYTE_ARRAY);
6866

6967
Props.push_back(Prop);
70-
PropSet.insert(llvm::util::PropertySetRegistry::SYCL_VIRTUAL_FUNCTIONS,
71-
std::move(Props));
68+
PropSet.insert(__SYCL_PROPERTY_SET_SYCL_VIRTUAL_FUNCTIONS, std::move(Props));
7269

7370
std::vector<unsigned char> Bin{Magic};
7471

sycl/unittests/helpers/MockDeviceImage.hpp

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020

2121
#include <sycl/detail/defines_elementary.hpp>
2222

23-
#include <llvm/Support/PropertySetIO.h>
24-
2523
namespace sycl {
2624
inline namespace _V1 {
2725
namespace unittest {
@@ -193,8 +191,7 @@ class MockPropertySet {
193191
// Value must be an all-zero 32-bit mask, which would mean that no fallback
194192
// libraries are needed to be loaded.
195193
MockProperty DeviceLibReqMask("", Data, SYCL_PROPERTY_TYPE_UINT32);
196-
insert(llvm::util::PropertySetRegistry::SYCL_DEVICELIB_REQ_MASK,
197-
std::move(DeviceLibReqMask));
194+
insert(__SYCL_PROPERTY_SET_DEVICELIB_REQ_MASK, std::move(DeviceLibReqMask));
198195
}
199196

200197
/// Adds a new property to the set.
@@ -464,8 +461,7 @@ inline void setKernelUsesAssert(const std::vector<std::string> &Names,
464461
std::vector<MockProperty> Value;
465462
for (const std::string &N : Names)
466463
Value.push_back({N, {0, 0, 0, 0}, SYCL_PROPERTY_TYPE_UINT32});
467-
Set.insert(llvm::util::PropertySetRegistry::SYCL_ASSERT_USED,
468-
std::move(Value));
464+
Set.insert(__SYCL_PROPERTY_SET_SYCL_ASSERT_USED, std::move(Value));
469465
}
470466

471467
/// Utility function to add specialization constants to property set.
@@ -474,14 +470,12 @@ inline void setKernelUsesAssert(const std::vector<std::string> &Names,
474470
inline void addSpecConstants(std::vector<MockProperty> &&SpecConstants,
475471
std::vector<char> ValData,
476472
MockPropertySet &Props) {
477-
Props.insert(llvm::util::PropertySetRegistry::SYCL_SPECIALIZATION_CONSTANTS,
478-
std::move(SpecConstants));
473+
Props.insert(__SYCL_PROPERTY_SET_SPEC_CONST_MAP, std::move(SpecConstants));
479474

480475
MockProperty Prop{"all", std::move(ValData), SYCL_PROPERTY_TYPE_BYTE_ARRAY};
481476

482-
Props.insert(
483-
llvm::util::PropertySetRegistry::SYCL_SPEC_CONSTANTS_DEFAULT_VALUES,
484-
std::move(Prop));
477+
Props.insert(__SYCL_PROPERTY_SET_SPEC_CONST_DEFAULT_VALUES_MAP,
478+
std::move(Prop));
485479
}
486480

487481
/// Utility function to add ESIMD kernel flag to property set.
@@ -490,8 +484,7 @@ inline void addESIMDFlag(MockPropertySet &Props) {
490484
ValData[0] = 1;
491485
MockProperty Prop{"isEsimdImage", ValData, SYCL_PROPERTY_TYPE_UINT32};
492486

493-
Props.insert(llvm::util::PropertySetRegistry::SYCL_MISC_PROP,
494-
std::move(Prop));
487+
Props.insert(__SYCL_PROPERTY_SET_SYCL_MISC_PROP, std::move(Prop));
495488
}
496489

497490
/// Utility function to generate offload entries for kernels without arguments.
@@ -604,8 +597,7 @@ addDeviceRequirementsProps(MockPropertySet &Props,
604597
std::vector<MockProperty> Value{makeAspectsProp(Aspects)};
605598
if (!ReqdWGSize.empty())
606599
Value.push_back(makeReqdWGSizeProp(ReqdWGSize));
607-
Props.insert(llvm::util::PropertySetRegistry::SYCL_DEVICE_REQUIREMENTS,
608-
std::move(Value));
600+
Props.insert(__SYCL_PROPERTY_SET_SYCL_DEVICE_REQUIREMENTS, std::move(Value));
609601
}
610602

611603
inline MockDeviceImage

sycl/unittests/pipes/host_pipe_registration.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
#include <cstring>
1010
#include <sycl/sycl.hpp>
1111

12-
#include <llvm/Support/PropertySetIO.h>
13-
1412
#include <detail/device_binary_image.hpp>
1513
#include <detail/host_pipe_map_entry.hpp>
1614
#include <gtest/gtest.h>
@@ -40,7 +38,7 @@ static sycl::unittest::MockDeviceImage generateDefaultImage() {
4038
MockPropertySet PropSet;
4139
MockProperty HostPipeInfo =
4240
makeHostPipeInfo("test_host_pipe_unique_id", sizeof(int));
43-
PropSet.insert(llvm::util::PropertySetRegistry::SYCL_HOST_PIPES,
41+
PropSet.insert(__SYCL_PROPERTY_SET_SYCL_HOST_PIPES,
4442
std::vector<MockProperty>{std::move(HostPipeInfo)});
4543

4644
std::vector<MockOffloadEntry> Entries = makeEmptyKernels({"TestKernel"});

sycl/unittests/program_manager/Cleanup.cpp

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -169,29 +169,28 @@ sycl::unittest::MockDeviceImage generateImage(const std::string &ImageId) {
169169
KernelEAM);
170170
std::vector<sycl::unittest::MockProperty> ImgKPOI{std::move(EAMKernelPOI)};
171171

172-
PropSet.insert(llvm::util::PropertySetRegistry::SYCL_EXPORTED_SYMBOLS,
172+
PropSet.insert(__SYCL_PROPERTY_SET_SYCL_EXPORTED_SYMBOLS,
173173
createPropertySet(ExportedSymbols));
174174

175-
PropSet.insert(llvm::util::PropertySetRegistry::SYCL_IMPORTED_SYMBOLS,
175+
PropSet.insert(__SYCL_PROPERTY_SET_SYCL_IMPORTED_SYMBOLS,
176176
createPropertySet(ImportedSymbols));
177177

178-
PropSet.insert(llvm::util::PropertySetRegistry::SYCL_VIRTUAL_FUNCTIONS,
178+
PropSet.insert(__SYCL_PROPERTY_SET_SYCL_VIRTUAL_FUNCTIONS,
179179
createVFPropertySet(VirtualFunctions));
180180
setKernelUsesAssert(std::vector<std::string>{KernelNames.begin()[0]},
181181
PropSet);
182182

183-
PropSet.insert(llvm::util::PropertySetRegistry::SYCL_IMPLICIT_LOCAL_ARG,
183+
PropSet.insert(__SYCL_PROPERTY_SET_SYCL_IMPLICIT_LOCAL_ARG,
184184
createPropertySet(ImplicitLocalArg));
185-
PropSet.insert(llvm::util::PropertySetRegistry::SYCL_KERNEL_PARAM_OPT_INFO,
186-
std::move(ImgKPOI));
185+
PropSet.insert(__SYCL_PROPERTY_SET_KERNEL_PARAM_OPT_INFO, std::move(ImgKPOI));
187186

188187
PropSet.insert(
189-
llvm::util::PropertySetRegistry::SYCL_DEVICE_GLOBALS,
188+
__SYCL_PROPERTY_SET_SYCL_DEVICE_GLOBALS,
190189
std::vector<sycl::unittest::MockProperty>{
191190
sycl::unittest::makeDeviceGlobalInfo(
192191
generateRefName(ImageId, "DeviceGlobal"), sizeof(int), 0)});
193192

194-
PropSet.insert(llvm::util::PropertySetRegistry::SYCL_HOST_PIPES,
193+
PropSet.insert(__SYCL_PROPERTY_SET_SYCL_HOST_PIPES,
195194
std::vector<sycl::unittest::MockProperty>{
196195
sycl::unittest::makeHostPipeInfo(
197196
generateRefName(ImageId, "HostPipe"), sizeof(int))});

sycl/unittests/program_manager/CompileTarget.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
#include <helpers/MockKernelInfo.hpp>
1010
#include <helpers/UrMock.hpp>
1111

12-
#include <llvm/Support/PropertySetIO.h>
13-
1412
#include <gtest/gtest.h>
1513

1614
using namespace sycl;
@@ -26,7 +24,7 @@ generateImageWithCompileTarget(std::string KernelName,
2624
MockProperty CompileTargetProperty("compile_target", Data,
2725
SYCL_PROPERTY_TYPE_BYTE_ARRAY);
2826
MockPropertySet PropSet;
29-
PropSet.insert(llvm::util::PropertySetRegistry::SYCL_DEVICE_REQUIREMENTS,
27+
PropSet.insert(__SYCL_PROPERTY_SET_SYCL_DEVICE_REQUIREMENTS,
3028
std::move(CompileTargetProperty));
3129

3230
std::vector<unsigned char> Bin(CompileTarget.begin(), CompileTarget.end());

0 commit comments

Comments
 (0)