Skip to content

Commit acb7a65

Browse files
committed
Minor changes to address comments and resolve branch merge conflicts
1 parent 3426ef0 commit acb7a65

6 files changed

+15
-35
lines changed

clang/test/SemaSYCL/check-indirect-attribute-propagation.cpp

Lines changed: 0 additions & 20 deletions
This file was deleted.

clang/test/SemaSYCL/check-notdirect-attribute-propagation.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %clang %s -fsyntax-only -Xclang -ast-dump -fsycl-device-only | FileCheck %s
1+
// RUN: %clang_cc1 %s -fsyntax-only -ast-dump -fsycl -fsycl-is-device -triple spir64 | FileCheck %s
22

33
[[intelfpga::no_global_work_offset]] void not_direct() {}
44

@@ -17,7 +17,7 @@ void parallel_for(Type lambda) {
1717

1818
void invoke_foo2() {
1919
// CHECK-LABEL: FunctionDecl {{.*}} invoke_foo2 'void ()'
20-
// CHECK: `-FunctionDecl {{.*}} _ZTSZ11invoke_foo2vE10KernelName 'void ()'
21-
// CHECK: -SYCLIntelNoGlobalWorkOffsetAttr {{.*}} Enabled
20+
// CHECK: `-FunctionDecl {{.*}}KernelName 'void ()'
21+
// CHECK: -SYCLIntelNoGlobalWorkOffsetAttr {{.*}} Enabled
2222
parallel_for<class KernelName>([]() {});
2323
}

clang/test/SemaSYCL/intel-max-global-work-dim.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ void foo() {
2121
#else // __SYCL_DEVICE_ONLY__
2222

2323
[[intelfpga::max_global_work_dim(2)]]
24-
void func_ignore() {}
24+
void func_do_not_ignore() {}
2525

2626
struct FuncObj {
2727
[[intelfpga::max_global_work_dim(1)]]
@@ -68,9 +68,9 @@ int main() {
6868
[]() [[intelfpga::max_global_work_dim(2)]] {});
6969

7070
// CHECK-LABEL: FunctionDecl {{.*}}test_kernel3
71-
// CHECK-NOT: SYCLIntelMaxGlobalWorkDimAttr {{.*}}
71+
// CHECK: SYCLIntelMaxGlobalWorkDimAttr {{.*}}
7272
kernel<class test_kernel3>(
73-
[]() {func_ignore();});
73+
[]() {func_do_not_ignore();});
7474

7575
kernel<class test_kernel4>(
7676
TRIFuncObjGood1());

clang/test/SemaSYCL/intel-max-work-group-size.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ void foo() {
2121
#else // __SYCL_DEVICE_ONLY__
2222

2323
[[intelfpga::max_work_group_size(2, 2, 2)]]
24-
void func_ignore() {}
24+
void func_do_not_ignore() {}
2525

2626
struct FuncObj {
2727
[[intelfpga::max_work_group_size(4, 4, 4)]]
@@ -53,9 +53,9 @@ int main() {
5353
[]() [[intelfpga::max_work_group_size(8, 8, 8)]] {});
5454

5555
// CHECK-LABEL: FunctionDecl {{.*}}test_kernel3
56-
// CHECK-NOT: SYCLIntelMaxWorkGroupSizeAttr {{.*}}
56+
// CHECK: SYCLIntelMaxWorkGroupSizeAttr {{.*}}
5757
kernel<class test_kernel3>(
58-
[]() {func_ignore();});
58+
[]() {func_do_not_ignore();});
5959

6060
#ifdef TRIGGER_ERROR
6161
[[intelfpga::max_work_group_size(1, 1, 1)]] int Var = 0; // expected-error{{'max_work_group_size' attribute only applies to functions}}

clang/test/SemaSYCL/intel-restrict.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// RUN: %clang_cc1 %s -fsyntax-only -ast-dump -fsycl -fsycl-is-device -triple spir64 | FileCheck %s
33

44
[[intel::kernel_args_restrict]]
5-
void func_ignore() {}
5+
void func_do_not_ignore() {}
66

77
struct FuncObj {
88
[[intel::kernel_args_restrict]]
@@ -29,7 +29,7 @@ int main() {
2929
[]() [[intel::kernel_args_restrict]] {});
3030

3131
// CHECK-LABEL: FunctionDecl {{.*}}test_kernel3
32-
// CHECK-NOT: SYCLIntelKernelArgsRestrictAttr
32+
// CHECK: SYCLIntelKernelArgsRestrictAttr
3333
kernel<class test_kernel3>(
34-
[]() {func_ignore();});
34+
[]() {func_do_not_ignore();});
3535
}

clang/test/SemaSYCL/num_simd_work_items.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ void foo() {
2121
#else // __SYCL_DEVICE_ONLY__
2222

2323
[[intelfpga::num_simd_work_items(2)]]
24-
void func_ignore() {}
24+
void func_do_not_ignore() {}
2525

2626
struct FuncObj {
2727
[[intelfpga::num_simd_work_items(42)]]
@@ -45,9 +45,9 @@ int main() {
4545
[]() [[intelfpga::num_simd_work_items(8)]] {});
4646

4747
// CHECK-LABEL: FunctionDecl {{.*}}test_kernel3
48-
// CHECK-NOT: SYCLIntelNumSimdWorkItemsAttr {{.*}} 2
48+
// CHECK: SYCLIntelNumSimdWorkItemsAttr {{.*}} 2
4949
kernel<class test_kernel3>(
50-
[]() {func_ignore();});
50+
[]() {func_do_not_ignore();});
5151

5252
#ifdef TRIGGER_ERROR
5353
[[intelfpga::num_simd_work_items(0)]] int Var = 0; // expected-error{{'num_simd_work_items' attribute only applies to functions}}

0 commit comments

Comments
 (0)