Skip to content

Commit ad11759

Browse files
committed
Address PR feedback
Signed-off-by: Lukas Sommer <[email protected]>
1 parent 982996d commit ad11759

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

sycl/doc/extensions/proposed/sycl_ext_oneapi_graph_fusion.asciidoc

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ references below to the "core SYCL specification" or to section numbers in the
4343
SYCL specification refer to that revision.
4444

4545
This extension builds on top of the proposed SYCL graphs
46-
https://github.com/reble/llvm/blob/sycl-graph-update/sycl/doc/extensions/proposed/sycl_ext_oneapi_graph.asciidoc[extension
46+
https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_graph.asciidoc[extension
4747
proposal]. All references to the "graphs proposal" refer to this proposal.
4848

4949
== Status
@@ -57,9 +57,9 @@ not rely on APIs defined in this specification.*
5757
== Overview
5858

5959
The SYCL graph
60-
https://github.com/reble/llvm/blob/sycl-graph-update/sycl/doc/extensions/proposed/sycl_ext_oneapi_graph.asciidoc[extension
60+
https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_graph.asciidoc[extension
6161
proposal] seeks to reduce the runtime overhead linked to SYCL kernel submission
62-
and expose additional optimization opportunities.
62+
and expose additional optimization opportunities.
6363

6464
One of those further optimizations enabled by the graphs proposal is _kernel
6565
fusion_. Fusing two or more kernels executing on the same device into a single
@@ -121,7 +121,7 @@ can be added to the property list to indicate that the kernels in the
121121
command-graph should be fused.
122122

123123
```c++
124-
sycl::ext::oneapi::experimental::property::command_graph::perform_fusion
124+
sycl::ext::oneapi::experimental::property::graph::perform_fusion
125125
```
126126

127127
The property is not prescriptive. Implementations are free to not perform fusion
@@ -140,14 +140,14 @@ The following property can be added to the `property_list` of the
140140
`command_graph<graph_state::modifiable>::finalize()` API.
141141

142142
```c++
143-
sycl::ext::oneapi::experimental::property::command_graph::no_barriers
143+
sycl::ext::oneapi::experimental::property::graph::no_barriers
144144
```
145145

146146
If the property list contains this property, no barriers are introduced between
147147
kernels in the fused kernel (see below section on synchronization on kernels).
148148

149149
The property only takes effect if the
150-
`sycl::ext::oneapi::experimental::property::command_graph::perform_fusion`
150+
`sycl::ext::oneapi::experimental::property::graph::perform_fusion`
151151
property is also part of the `property_list` of the same invocation of
152152
`command_graph<...>::finalize()`.
153153

@@ -530,7 +530,7 @@ int main() {
530530
// Trigger fusion during finalization.
531531
auto exec_graph =
532532
graph.finalize({sycl::ext::oneapi::experimental::property::
533-
command_graph::perform_fusion});
533+
graph::perform_fusion});
534534

535535
q.ext_oneapi_graph(exec_graph);
536536

@@ -608,7 +608,7 @@ int main() {
608608

609609
// Trigger fusion during finalization.
610610
auto exec = graph.finalize({sycl::ext::oneapi::experimental::property::
611-
command_graph::perform_fusion});
611+
graph::perform_fusion});
612612

613613
// use queue shortcut for graph submission
614614
q.ext_oneapi_graph(exec).wait();

0 commit comments

Comments
 (0)