Skip to content

Commit adc98e3

Browse files
Revert "[DeviceASAN] Enable e2e test "private_nullptr.cpp"" (#16084)
Reverts #15995 @AllanZyne - It looks like this still fails on Arc in post-commit.
1 parent 2e7c2ef commit adc98e3

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

sycl/test-e2e/AddressSanitizer/nullpointer/private_nullptr.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
// RUN: %{build} %device_asan_flags -O2 -g -o %t3.out
77
// RUN: %{run} not %t3.out 2>&1 | FileCheck %s
88

9+
// FIXME: There's an issue in gfx driver, so this test pending here.
10+
// XFAIL: *
11+
912
#include <sycl/detail/core.hpp>
1013
#include <sycl/ext/oneapi/experimental/address_cast.hpp>
1114

@@ -19,14 +22,15 @@ int main() {
1922
sycl::nd_range<1>(N, 1), [=](sycl::nd_item<1> item) {
2023
auto private_array =
2124
sycl::ext::oneapi::experimental::static_address_cast<
22-
sycl::access::address_space::private_space>(array);
25+
sycl::access::address_space::private_space,
26+
sycl::access::decorated::no>(array);
2327
private_array[0] = 0;
2428
});
2529
Q.wait();
2630
});
2731
// CHECK: ERROR: DeviceSanitizer: null-pointer-access on Unknown Memory
2832
// CHECK: WRITE of size 4 at kernel {{<.*MyKernel>}} LID(0, 0, 0) GID({{.*}}, 0, 0)
29-
// CHECK: {{.*private_nullptr.cpp}}:[[@LINE-6]]
33+
// CHECK: {{.*private_nullptr.cpp}}:[[@LINE-5]]
3034

3135
return 0;
3236
}

sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,13 @@
5151
// tests to match the required format and in that case you should just update
5252
// (i.e. reduce) the number and the list below.
5353
//
54-
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 141
54+
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 142
5555
//
5656
// List of improperly XFAIL-ed tests.
5757
// Remove the CHECK once the test has been properly XFAIL-ed.
5858
//
59-
// CHECK: Basic/aspects.cpp
59+
// CHECK: AddressSanitizer/nullpointer/private_nullptr.cpp
60+
// CHECK-NEXT: Basic/aspects.cpp
6061
// CHECK-NEXT: Basic/buffer/reinterpret.cpp
6162
// CHECK-NEXT: Basic/device_event.cpp
6263
// CHECK-NEXT: Basic/diagnostics/handler.cpp

0 commit comments

Comments
 (0)