[CI] Several fixes and improvements for AWS CI pipeline (#6575)

* Typo fix in lts_aws_matrix name
* Add missing lts_aws_matrix output
* Hardened security
* Do not report fail is instance was started after on subsequent attempts

Author: apstasen

.github/workflows/sycl_linux_build_and_test.yml

@@ -216,6 +216,7 @@ jobs:
     # FIXME cached_checkout fails here, but works everywhere else
     - uses: actions/checkout@v2
       with:
+        persist-credentials: false
         path: llvm
     # TODO should this action be packed into container as well?
     - uses: ./llvm/devops/actions/llvm_test_suite
@@ -233,7 +234,7 @@ jobs:
   aws-stop:
     name: Stop AWS
     needs: [ aws-start, llvm_test_suite ]
-    if: ${{ always() && inputs.lts_ats_matrix != '' }}
+    if: ${{ always() && inputs.lts_aws_matrix != '' }}
     runs-on: ubuntu-latest
     environment: aws
     steps:

.github/workflows/sycl_precommit.yml

@@ -17,6 +17,9 @@ on:
     - '**.md'
     - '**.rst'
 
+permissions:
+  contents: read
+
 jobs:
   lint:
     runs-on: ubuntu-latest

.github/workflows/sycl_resolve_test_matrix.yml

@@ -37,6 +37,7 @@ jobs:
     runs-on: ubuntu-latest
     outputs:
       lts_matrix: ${{ steps.work.outputs.lts_matrix }}
+      lts_aws_matrix: ${{ steps.work.outputs.lts_aws_matrix }}
     steps:
     - name: Download scripts and configs
       shell: bash

devops/actions/aws-ec2/aws-ec2.js

@@ -48,7 +48,7 @@ async function start(param_type, param_label, param_ami, param_spot, param_disk,
   // ephemeral runner will exit after one job so we will terminate instance sooner
   const ephemeral_str = onejob ? "--ephemeral" : "";
 
-  let ec2id;      // AWS EC2 instance id
+  let ec2id; // AWS EC2 instance id
   // last error that will be thrown in case all our attemps in instance creation will fails
   let last_error;
   // loop for spot/ondemand instances
@@ -99,7 +99,7 @@ async function start(param_type, param_label, param_ami, param_spot, param_disk,
     // we already created instance and do not need to iterate these loops
     if (ec2id) break;
   }
-  if (last_error) {
+  if (!ec2id && last_error) {
     core.error(`Error creating AWS EC2 instance with ${label} label`);
     throw last_error;
   }