Skip to content

Commit af18927

Browse files
authored
[SYCL][HIP] Fix HIP headers warning (#9550)
Using the headers in `hip/include/hip` is deprecated since ROCm 5.2, older versions of HIP also have this directory symlinked in `include` so we can just update to the new path. Fixes #9457 And reverts #9458
1 parent f4577ff commit af18927

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

sycl/plugins/hip/CMakeLists.txt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ set(SYCL_BUILD_PI_HIP_INCLUDE_DIR "" CACHE STRING "Override HIP include dir path
1212
set(SYCL_BUILD_PI_HIP_HSA_INCLUDE_DIR "" CACHE STRING "Override HSA include dir path (set to \"\" for default behavior)")
1313

1414
if("${SYCL_BUILD_PI_HIP_INCLUDE_DIR}" STREQUAL "")
15-
set(PI_HIP_INCLUDE_DIR "${SYCL_BUILD_PI_HIP_ROCM_DIR}/hip/include")
15+
set(PI_HIP_INCLUDE_DIR "${SYCL_BUILD_PI_HIP_ROCM_DIR}/include")
1616
else()
1717
set(PI_HIP_INCLUDE_DIR "${SYCL_BUILD_PI_HIP_INCLUDE_DIR}")
1818
endif()
@@ -98,12 +98,6 @@ add_sycl_plugin(hip
9898
)
9999
set_target_properties(pi_hip PROPERTIES LINKER_LANGUAGE CXX)
100100

101-
if (NOT WIN32)
102-
# TODO: Temporarily disable deprecation warnings from the HIP headers. Remove
103-
# this when https://github.com/intel/llvm/issues/9457 is addressed.
104-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-cpp")
105-
endif()
106-
107101
if("${SYCL_BUILD_PI_HIP_PLATFORM}" STREQUAL "AMD")
108102
# Import HIP runtime library
109103
add_library(rocmdrv SHARED IMPORTED GLOBAL)

0 commit comments

Comments
 (0)