reviewer feedback

Signed-off-by: Chris Perkins <[email protected]>

Author: cperkinsintel

sycl/doc/GetStartedGuide.md

@@ -740,12 +740,20 @@ the CMake.
 
 ### Code the program for a specific GPU
 
-To assist in finding a specific SYCL compatible device out of all that may be available, a "device selector" may be used. A "device selector" is a ranking function that will give an integer ranking value to all the
-devices on the system. It can be passed to `sycl::queue`, `sycl::device` and `sycl::platform` constructors. The highest ranking device is then selected. SYCL has built-in device selectors for selecting a generic GPU, CPU, or accelerator device, as well as one for a default device. Additionally, 
-a user can define their own as function, lambda, or functor class. Device selectors returning negative values will "reject" a device ensuring it is not selected, but values 0 or higher will be selected by the highest score with ties resolved by an internal algorithm (see Section 4.6.1 of the SYCL 2020 specification)
-
-The example below illustrates how to use a device selector to create
-device and queue objects bound to Intel GPU device:
+To assist in finding a specific SYCL compatible device out of all that may be
+available, a "device selector" may be used. A "device selector" is a ranking
+function (C++ Callable) that will give an integer ranking value to all the
+devices on the system. It can be passed to `sycl::queue`, `sycl::device` and
+`sycl::platform` constructors. The highest ranking device is then selected. SYCL
+has built-in device selectors for selecting a generic GPU, CPU, or accelerator
+device, as well as one for a default device. Additionally, a user can define
+their own as function, lambda, or functor class. Device selectors returning
+negative values will "reject" a device ensuring it is not selected, but values 0
+or higher will be selected by the highest score with ties resolved by an
+internal algorithm (see Section 4.6.1 of the SYCL 2020 specification)
+
+The example below illustrates how to use a device selector to create device and
+queue objects bound to Intel GPU device:
 
 ```c++
 #include <sycl/sycl.hpp>

sycl/test/scheduler/ReleaseResourcesTest.cpp

@@ -20,10 +20,12 @@ int main() {
 
   // Checks creating of the second host accessor while first one is alive.
   try {
+    sycl::default_selector device_selector;
+
     sycl::range<1> BufSize{1};
     sycl::buffer<int, 1> Buf(BufSize);
 
-    TestQueue Queue(sycl::default_selector{});
+    TestQueue Queue(device_selector);
 
     Queue.submit([&](sycl::handler &CGH) {
       auto BufAcc = Buf.get_access<sycl_access_mode::read_write>(CGH);

sycl/test/warnings/sycl_2020_deprecations.cpp

@@ -195,15 +195,15 @@ int main() {
   group.get_linear_id();
 
   // expected-warning@+1{{'default_selector' is deprecated: Use the callable sycl::default_selector_v instead.}}
-  sycl::default_selector ds{};
+  sycl::default_selector ds;
   // expected-warning@+1{{'cpu_selector' is deprecated: Use the callable sycl::cpu_selector_v instead.}}
-  sycl::cpu_selector cs{};
+  sycl::cpu_selector cs;
   // expected-warning@+1{{'gpu_selector' is deprecated: Use the callable sycl::gpu_selector_v instead.}}
-  sycl::gpu_selector gs{};
+  sycl::gpu_selector gs;
   // expected-warning@+1{{'accelerator_selector' is deprecated: Use the callable sycl::accelerator_selector_v instead.}}
-  sycl::accelerator_selector as{};
+  sycl::accelerator_selector as;
   // expected-warning@+1{{'host_selector' is deprecated: Use a callable function instead.}}
-  sycl::host_selector hs{};
+  sycl::host_selector hs;
 
   // expected-warning@+2{{'local' is deprecated: use `local_accessor` instead}}
   Queue.submit([&](sycl::handler &CGH) {

sycl/unittests/assert/assert.cpp

@@ -438,7 +438,7 @@ void ChildProcess(int StdErrFD) {
     exit(1);
   }
 
-  sycl::platform Plt{sycl::default_selector_v};
+  sycl::platform Plt;
 
   sycl::unittest::PiMock Mock{Plt};
 
@@ -516,7 +516,7 @@ void ParentProcess(int ChildPID, int ChildStdErrFD) {
 TEST(Assert, TestPositive) {
   // Preliminary checks
   {
-    sycl::platform Plt{sycl::default_selector_v};
+    sycl::platform Plt;
     if (Plt.is_host()) {
       printf("Test is not supported on host, skipping\n");
       return;
@@ -572,7 +572,7 @@ TEST(Assert, TestAssertServiceKernelHidden) {
 }
 
 TEST(Assert, TestInteropKernelNegative) {
-  sycl::platform Plt{sycl::default_selector_v};
+  sycl::platform Plt;
 
   if (Plt.is_host()) {
     printf("Test is not supported on host, skipping\n");
@@ -610,7 +610,7 @@ TEST(Assert, TestInteropKernelNegative) {
 }
 
 TEST(Assert, TestInteropKernelFromProgramNegative) {
-  sycl::platform Plt{sycl::default_selector_v};
+  sycl::platform Plt;
 
   if (Plt.is_host()) {
     printf("Test is not supported on host, skipping\n");

sycl/unittests/buffer/BufferLocation.cpp

@@ -71,7 +71,7 @@ static pi_result redefinedDeviceGetInfo(pi_device device,
 
 class BufferTest : public ::testing::Test {
 public:
-  BufferTest() : Plt{sycl::default_selector_v} {}
+  BufferTest() {}
 
 protected:
   void SetUp() override {