Skip to content

Commit b21b3c3

Browse files
[SYCL][NFC] Rename file and variables/methods (#4000)
Renaming file and variables for greater generality, so that we can support other offloading mechanisms if required in the future Signed-off-by: Elizabeth Andrews <[email protected]>
1 parent 7944294 commit b21b3c3

File tree

4 files changed

+16
-20
lines changed

4 files changed

+16
-20
lines changed

clang/include/clang/Basic/Diagnostic.h

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
#include "clang/Basic/DiagnosticIDs.h"
1818
#include "clang/Basic/DiagnosticOptions.h"
19+
#include "clang/Basic/OptReportHandler.h"
1920
#include "clang/Basic/SourceLocation.h"
2021
#include "clang/Basic/Specifiers.h"
21-
#include "clang/Basic/SyclOptReportHandler.h"
2222
#include "llvm/ADT/ArrayRef.h"
2323
#include "llvm/ADT/DenseMap.h"
2424
#include "llvm/ADT/IntrusiveRefCntPtr.h"
@@ -295,7 +295,7 @@ class DiagnosticsEngine : public RefCountedBase<DiagnosticsEngine> {
295295
DiagnosticConsumer *Client = nullptr;
296296
std::unique_ptr<DiagnosticConsumer> Owner;
297297
SourceManager *SourceMgr = nullptr;
298-
SyclOptReportHandler OptReportHandler;
298+
SyclOptReportHandler SyclOptReport;
299299

300300
/// Mapping information for diagnostics.
301301
///
@@ -549,11 +549,9 @@ class DiagnosticsEngine : public RefCountedBase<DiagnosticsEngine> {
549549
LLVM_DUMP_METHOD void dump() const;
550550
LLVM_DUMP_METHOD void dump(StringRef DiagName) const;
551551

552-
/// Retrieve the report SyclOptReport info.
553-
SyclOptReportHandler &getSYCLOptReportHandler() { return OptReportHandler; }
554-
const SyclOptReportHandler &getSYCLOptReportHandler() const {
555-
return OptReportHandler;
556-
}
552+
/// Retrieve the SyclOptReport info.
553+
SyclOptReportHandler &getSYCLOptReport() { return SyclOptReport; }
554+
const SyclOptReportHandler &getSYCLOptReport() const { return SyclOptReport; }
557555

558556
const IntrusiveRefCntPtr<DiagnosticIDs> &getDiagnosticIDs() const {
559557
return Diags;

clang/include/clang/Basic/SyclOptReportHandler.h renamed to clang/include/clang/Basic/OptReportHandler.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//===---------------------- SyclOptReportHandler.h --------------*- C++ -*-===//
1+
//===------------------------ OptReportHandler.h ----------------*- C++ -*-===//
22
//
33
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
44
// See https://llvm.org/LICENSE.txt for license information.
@@ -11,8 +11,8 @@
1111
///
1212
//===----------------------------------------------------------------------===//
1313

14-
#ifndef LLVM_CLANG_BASIC_SYCLOPTREPORTHANDLER_H
15-
#define LLVM_CLANG_BASIC_SYCLOPTREPORTHANDLER_H
14+
#ifndef LLVM_CLANG_BASIC_OPTREPORTHANDLER_H
15+
#define LLVM_CLANG_BASIC_OPTREPORTHANDLER_H
1616

1717
#include "clang/Basic/SourceLocation.h"
1818
#include "llvm/ADT/DenseMap.h"
@@ -56,12 +56,11 @@ class SyclOptReportHandler {
5656
assert(It != Map.end());
5757
return It->second;
5858
}
59-
6059
bool HasOptReportInfo(const FunctionDecl *FD) const {
6160
return Map.find(FD) != Map.end();
6261
}
6362
};
6463

6564
} // namespace clang
6665

67-
#endif // LLVM_CLANG_BASIC_SYCLOPTREPORTHANDLER_H
66+
#endif // LLVM_CLANG_BASIC_OPTREPORTHANDLER_H

clang/lib/CodeGen/CodeGenFunction.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1523,11 +1523,10 @@ void CodeGenFunction::GenerateCode(GlobalDecl GD, llvm::Function *Fn,
15231523
// Emit the standard function prologue.
15241524
StartFunction(GD, ResTy, Fn, FnInfo, Args, Loc, BodyRange.getBegin());
15251525

1526-
SyclOptReportHandler &OptReportHandler =
1527-
CGM.getDiags().getSYCLOptReportHandler();
1528-
if (OptReportHandler.HasOptReportInfo(FD)) {
1526+
SyclOptReportHandler &SyclOptReport = CGM.getDiags().getSYCLOptReport();
1527+
if (SyclOptReport.HasOptReportInfo(FD)) {
15291528
llvm::OptimizationRemarkEmitter ORE(Fn);
1530-
for (auto ORI : llvm::enumerate(OptReportHandler.GetInfo(FD))) {
1529+
for (auto ORI : llvm::enumerate(SyclOptReport.GetInfo(FD))) {
15311530
llvm::DiagnosticLocation DL =
15321531
SourceLocToDebugLoc(ORI.value().KernelArgLoc);
15331532
StringRef NameInDesc = ORI.value().KernelArgDescName;

clang/lib/Sema/SemaSYCL.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2405,7 +2405,7 @@ class SyclOptReportCreator : public SyclKernelFieldHandler {
24052405
unsigned KernelArgSize =
24062406
SemaRef.getASTContext().getTypeSizeInChars(KernelArgType).getQuantity();
24072407

2408-
SemaRef.getDiagnostics().getSYCLOptReportHandler().AddKernelArgs(
2408+
SemaRef.getDiagnostics().getSYCLOptReport().AddKernelArgs(
24092409
DC.getKernelDecl(), NameToEmitInDescription,
24102410
isWrappedField ? "Compiler generated" : KernelArgType.getAsString(),
24112411
KernelInvocationLoc, KernelArgSize, getKernelArgDesc(KernelArgDesc),
@@ -2428,7 +2428,7 @@ class SyclOptReportCreator : public SyclKernelFieldHandler {
24282428
KernelArgDescription KernelArgDesc) {
24292429
unsigned KernelArgSize =
24302430
SemaRef.getASTContext().getTypeSizeInChars(KernelArgType).getQuantity();
2431-
SemaRef.getDiagnostics().getSYCLOptReportHandler().AddKernelArgs(
2431+
SemaRef.getDiagnostics().getSYCLOptReport().AddKernelArgs(
24322432
DC.getKernelDecl(), KernelArgType.getAsString(),
24332433
KernelArgType.getAsString(), KernelInvocationLoc, KernelArgSize,
24342434
getKernelArgDesc(KernelArgDesc), "");
@@ -2438,7 +2438,7 @@ class SyclOptReportCreator : public SyclKernelFieldHandler {
24382438
void addParam(QualType KernelArgType, KernelArgDescription KernelArgDesc) {
24392439
unsigned KernelArgSize =
24402440
SemaRef.getASTContext().getTypeSizeInChars(KernelArgType).getQuantity();
2441-
SemaRef.getDiagnostics().getSYCLOptReportHandler().AddKernelArgs(
2441+
SemaRef.getDiagnostics().getSYCLOptReport().AddKernelArgs(
24422442
DC.getKernelDecl(), "", KernelArgType.getAsString(),
24432443
KernelInvocationLoc, KernelArgSize, getKernelArgDesc(KernelArgDesc),
24442444
"");
@@ -2470,7 +2470,7 @@ class SyclOptReportCreator : public SyclKernelFieldHandler {
24702470
unsigned KernelArgSize = SemaRef.getASTContext()
24712471
.getTypeSizeInChars(KernelArgType)
24722472
.getQuantity();
2473-
SemaRef.getDiagnostics().getSYCLOptReportHandler().AddKernelArgs(
2473+
SemaRef.getDiagnostics().getSYCLOptReport().AddKernelArgs(
24742474
DC.getKernelDecl(), FieldTy.getAsString(),
24752475
KernelArgType.getAsString(), KernelInvocationLoc, KernelArgSize,
24762476
getKernelArgDesc(

0 commit comments

Comments
 (0)