Skip to content

Commit b2851ae

Browse files
committed
Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser bug."
039cb03 (D93378) fixed the assembly separator, so the workaround is no longer necessary. This reverts commit 3000c19. Differential Revision: https://reviews.llvm.org/D93379
1 parent 039cb03 commit b2851ae

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

compiler-rt/lib/builtins/aarch64/lse.S

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ HIDDEN(__aarch64_have_lse_atomics)
113113
.endm
114114

115115
#ifdef L_cas
116-
DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED_START(NAME(cas))
117-
DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED_END(NAME(cas))
116+
DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED(NAME(cas))
118117
JUMP_IF_NOT_LSE 8f
119118
#if SIZE < 16
120119
#ifdef HAS_ASM_LSE
@@ -167,8 +166,7 @@ END_COMPILERRT_OUTLINE_FUNCTION(NAME(cas))
167166
#else
168167
#define SWP .inst 0x38208020 + B + N
169168
#endif
170-
DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED_START(NAME(swp))
171-
DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED_END(NAME(swp))
169+
DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED(NAME(swp))
172170
JUMP_IF_NOT_LSE 8f
173171
SWP // s(0), s(0), [x1]
174172
ret
@@ -211,8 +209,7 @@ END_COMPILERRT_OUTLINE_FUNCTION(NAME(swp))
211209
#define LDOP .inst 0x38200020 + OPN + B + N
212210
#endif
213211

214-
DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED_START(NAME(LDNM))
215-
DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED_END(NAME(LDNM))
212+
DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED(NAME(LDNM))
216213
JUMP_IF_NOT_LSE 8f
217214
LDOP // s(0), s(0), [x1]
218215
ret

compiler-rt/lib/builtins/assembly.h

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -243,16 +243,12 @@
243243
DECLARE_FUNC_ENCODING \
244244
name:
245245

246-
// TODO(ilinpv) START & END parts will be merged when assembly parser bug
247-
// (kristina) in MasmParser::parseDirectiveCFIStartProc() is fixed.
248-
#define DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED_START(name) \
246+
#define DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED(name) \
249247
DEFINE_CODE_STATE \
250248
FUNC_ALIGN \
251249
.globl name SEPARATOR \
252250
SYMBOL_IS_FUNC(name) SEPARATOR \
253-
DECLARE_SYMBOL_VISIBILITY(name)
254-
255-
#define DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED_END(name) \
251+
DECLARE_SYMBOL_VISIBILITY(name) SEPARATOR \
256252
CFI_START SEPARATOR \
257253
DECLARE_FUNC_ENCODING \
258254
name: SEPARATOR BTI_C

0 commit comments

Comments
 (0)