Skip to content

Commit b4b6749

Browse files
committed
address review comments
1 parent 9dd341e commit b4b6749

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

llvm/tools/sycl-post-link/ModuleSplitter.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -603,6 +603,9 @@ void ModuleDesc::renameDuplicatesOf(const Module &MA, StringRef Suff) {
603603
}
604604
}
605605

606+
// Attribute to save current function linkage in before replacement.
607+
// See more comments in ModuleSplitter::fixupLinkageOfDirectInvokeSimdTargets
608+
// declaration.
606609
constexpr char SYCL_ORIG_LINKAGE_ATTR[] = "__sycl_orig_linkage";
607610

608611
void ModuleDesc::fixupLinkageOfDirectInvokeSimdTargets() {
@@ -636,8 +639,8 @@ void ModuleDesc::restoreLinkageOfDirectInvokeSimdTargets() {
636639
}
637640
}
638641

639-
// TODO: try to move including all passes (cleanup, spec consts, compile time
640-
// properties) in one place and execute MPM.run() only once.
642+
// TODO: try to move all passes (cleanup, spec consts, compile time properties)
643+
// in one place and execute MPM.run() only once.
641644
void ModuleDesc::cleanup() {
642645
ModuleAnalysisManager MAM;
643646
MAM.registerPass([&] { return PassInstrumentationAnalysis(); });

0 commit comments

Comments
 (0)